From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 979E2C433FE for ; Sat, 15 Oct 2022 21:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n8TrFw7c1U769FpIaB1URL86vfCQR5/deQdjSa7uFTI=; b=2DpV/NupOEmohX TFgQriAcNC66LoAkj1+pWX8pW/h+3p+VDH1UfA6j8zJFCsYD4CcXRWZIny/sLNAyxvV7MfrjRrf0O eG7M7fSUNqrh0cTITPV0w1U0tb4AT92A0VmbbEf+9Uyrz/+sTOX8zqcfYtAFSfto/IzxKvg6rnjni 2jdbQVB54EhBK4WhIei9CQYBZnmFixBTN9RXfyTYY96kzIyZgfi51LbHeOvRfrFpChj0N8q+sIDIz 4XFWU/9JG3mpRMEBUVtpl5x+OXCyDmk2KV7gWrJvwEQvGYRJnSGCkO2b21elk5E7wdtVI+ano0B4G ke0uxNqwxz5+A4Qd+kbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojojf-0004l4-K3; Sat, 15 Oct 2022 21:30:23 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojojc-0004kJ-4Q for linux-arm-kernel@lists.infradead.org; Sat, 15 Oct 2022 21:30:21 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E090B84C60; Sat, 15 Oct 2022 23:30:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1665869416; bh=gGNhdSdYSgMq83bmJndDIz7hsraC7M6ZXTqA6z7FUb0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SSU71wsmJojX8P/dBJ2oSq/N0F5VZsQaYefNgCUQJ0TnrbnlMM74JFU4uQOuqtnA9 eDvX2uEK7+PXKWN6d/AzTj48SvD/D7m5XoXEuw6X1uKpVkU34/hA9RENji3mevCfI9 dYup5IGn7zf3UgEKqBmTDL0FKDeDDNEAjuE0d6V/gZMKAB3bHYidUI5XlY1b3+KG9b GMw7Hj2uFKYKzKlDPRyMweTPoXVNEMzJloFynKEF4YJviWjIcUFg9oXRux7HMGDJVE hWOhyN2cgsciT0CvB3PXnqcTJGRpiKjx/PeApcotEs1kO0zHBn3C5fItmh7gnlv9Ld tEeM9tRuf5nMg== Message-ID: Date: Sat, 15 Oct 2022 23:30:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v7 10/10] drm: bridge: samsung-dsim: Add i.MX8MM support Content-Language: en-US To: Jagan Teki , Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula References: <20221005151309.7278-1-jagan@amarulasolutions.com> <20221005151309.7278-11-jagan@amarulasolutions.com> From: Marek Vasut In-Reply-To: <20221005151309.7278-11-jagan@amarulasolutions.com> X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221015_143020_357469_AEB2D4AC X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/5/22 17:13, Jagan Teki wrote: [...] > +static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = { > + .reg_ofs = exynos5433_reg_ofs, > + .plltmr_reg = 0xa0, > + .has_clklane_stop = 1, > + .num_clks = 2, > + .max_freq = 2100, > + .wait_for_reset = 0, > + .num_bits_resol = 12, > + /** Should this really be kerneldoc style /** comment or plain /* comment ? If the later, please fix globally, there are multiple such FIXME comments. > + * FIXME: > + * Offset value used from downstream drivers/gpu/drm/bridge/sec-dsim.c > + * remove this comment if it is true else update the logic. > + */ > + .pll_p_offset = 14, > + .reg_values = imx8mm_dsim_reg_values, > +}; [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel