From: Waiman Long <longman@redhat.com>
To: Qian Cai <cai@lca.pw>, Will Deacon <will@kernel.org>
Cc: peterz@infradead.org, catalin.marinas@arm.com,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
mingo@redhat.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] arm64/spinlock: fix a -Wunused-function warning
Date: Thu, 23 Jan 2020 12:36:37 -0500 [thread overview]
Message-ID: <f95c27b1-a8ca-bac8-e6bb-07ca9e87bcd9@redhat.com> (raw)
In-Reply-To: <48DF011A-3074-422C-BFBA-1A9F2EF4A7BA@lca.pw>
On 1/23/20 12:31 PM, Qian Cai wrote:
>
>> On Jan 23, 2020, at 11:56 AM, Will Deacon <will@kernel.org> wrote:
>>
>> Damn, the whole point of this was to warn in the case that
>> vcpu_is_preempted() does get defined for arm64. Can we force it to evaluate
>> the macro argument instead (e.g. ({ (cpu), false; }) or something)?
> Actually, static inline should be better.
>
> #define vcpu_is_preempted vcpu_is_preempted
> static inline bool vcpu_is_preempted(int cpu)
> {
> return false;
> }
>
Yes, that may work.
Cheers,
Longman
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-23 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 16:29 [PATCH -next] arm64/spinlock: fix a -Wunused-function warning Qian Cai
2020-01-23 16:56 ` Will Deacon
2020-01-23 17:23 ` Qian Cai
2020-01-23 17:31 ` Qian Cai
2020-01-23 17:36 ` Waiman Long [this message]
2020-01-23 17:11 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f95c27b1-a8ca-bac8-e6bb-07ca9e87bcd9@redhat.com \
--to=longman@redhat.com \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).