From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE81C2D0DB for ; Thu, 23 Jan 2020 17:36:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80847214AF for ; Thu, 23 Jan 2020 17:36:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MDyz+ej2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gnrFCkM0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80847214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=evqh/tokJbpcO8E6jU+Z6ev+vGJirvM+pXl0nLM2gK8=; b=MDyz+ej2ggnXjX FylH+6FhIluIYiwOOnKWUA0YjPb0EOQoYPP8Jx5MmULxKWEtU+W/yRfHVLdX8u/cd2wivlNDTXUNP MuPpMmt62jXJ5pV0SZYeqXq6YG1oTYsyvK4UCSonvkDb+s2opyPM+tGL+aqv1PyxbC3pYW9uib3SK ry17E1beYswrxDAouwGwjcCS7MnLFrcuqDhVS8lTcOAmy4O+xgwrL+SIPW+a2DmB5HS9jzANpcVzS 5eKF+sdVbA1RX5uz/TVKsyali6W+oJFxRgpXCt3OZkp+AtSfAytrnLAOmgSxQme6A5eSg3rBAJPZq Pr7tJqJeraJ/QhH7BePg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iugPU-0000F6-W8; Thu, 23 Jan 2020 17:36:52 +0000 Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iugPS-0000ED-0W for linux-arm-kernel@lists.infradead.org; Thu, 23 Jan 2020 17:36:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579801006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D54wJCq+dcoWe+lOlchk/VMBTGpgOIcpCavPiOTlG1Y=; b=gnrFCkM0ISO8DmSWmwUpnYxPERc2I4THwxqZxbmifoyV/56vz8kP7FEl0k1d66QCFx/MKS Qo7Rzd65QOGQ19onYE6hqY946+P0HmCIhKbQ8v9zVGPNLlEVBQ0JKPW5l5d6kIQ018vyWa tj/YjET8iMF7qg/Vr1Nkrj4AfSDY1AE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-d4aV-R_nMuWLziZ8mN2NoA-1; Thu, 23 Jan 2020 12:36:41 -0500 X-MC-Unique: d4aV-R_nMuWLziZ8mN2NoA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF6A31005514; Thu, 23 Jan 2020 17:36:39 +0000 (UTC) Received: from llong.remote.csb (dhcp-17-59.bos.redhat.com [10.18.17.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7762F8644F; Thu, 23 Jan 2020 17:36:37 +0000 (UTC) Subject: Re: [PATCH -next] arm64/spinlock: fix a -Wunused-function warning To: Qian Cai , Will Deacon References: <20200123165614.GA20126@willie-the-truck> <48DF011A-3074-422C-BFBA-1A9F2EF4A7BA@lca.pw> From: Waiman Long Organization: Red Hat Message-ID: Date: Thu, 23 Jan 2020 12:36:37 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <48DF011A-3074-422C-BFBA-1A9F2EF4A7BA@lca.pw> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200123_093650_128973_CBFBA9DC X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peterz@infradead.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, mingo@redhat.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/23/20 12:31 PM, Qian Cai wrote: > >> On Jan 23, 2020, at 11:56 AM, Will Deacon wrote: >> >> Damn, the whole point of this was to warn in the case that >> vcpu_is_preempted() does get defined for arm64. Can we force it to evaluate >> the macro argument instead (e.g. ({ (cpu), false; }) or something)? > Actually, static inline should be better. > > #define vcpu_is_preempted vcpu_is_preempted > static inline bool vcpu_is_preempted(int cpu) > { > return false; > } > Yes, that may work. Cheers, Longman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel