From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Andrew Halaney <ahalaney@redhat.com>, <linux-kernel@vger.kernel.org>
Cc: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<vkoul@kernel.org>, <bhupesh.sharma@linaro.org>, <wens@csie.org>,
<jernej.skrabec@gmail.com>, <samuel@sholland.org>,
<mturquette@baylibre.com>, <peppe.cavallaro@st.com>,
<alexandre.torgue@foss.st.com>, <joabreu@synopsys.com>,
<mcoquelin.stm32@gmail.com>, <richardcochran@gmail.com>,
<linux@armlinux.org.uk>, <veekhee@apple.com>,
<tee.min.tan@linux.intel.com>, <mohammad.athari.ismail@intel.com>,
<jonathanh@nvidia.com>, <ruppala@nvidia.com>,
<bmasney@redhat.com>, <andrey.konovalov@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>, <ncai@quicinc.com>,
<jsuraj@qti.qualcomm.com>, <hisunil@quicinc.com>,
<echanude@redhat.com>, Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next v4 07/12] net: stmmac: Remove some unnecessary void pointers
Date: Tue, 11 Apr 2023 16:41:51 -0700 [thread overview]
Message-ID: <f96efb81-ac39-e64a-a8fc-f2f638e1f3c7@intel.com> (raw)
In-Reply-To: <20230411200409.455355-8-ahalaney@redhat.com>
On 4/11/2023 1:04 PM, Andrew Halaney wrote:
> There's a few spots in the hardware interface where a void pointer is
> used, but what's passed in and later cast out is always the same type.
>
> Just use the proper type directly.
>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Much better!
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-11 23:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 20:03 [PATCH net-next v4 00/12] Add EMAC3 support for sa8540p-ride Andrew Halaney
2023-04-11 20:03 ` [PATCH net-next v4 01/12] dt-bindings: net: snps,dwmac: Update interrupt-names Andrew Halaney
2023-04-11 20:03 ` [PATCH net-next v4 02/12] dt-bindings: net: snps,dwmac: Add Qualcomm Ethernet ETHQOS compatibles Andrew Halaney
2023-04-11 20:04 ` [PATCH net-next v4 03/12] dt-bindings: net: qcom,ethqos: Convert bindings to yaml Andrew Halaney
2023-04-11 20:04 ` [PATCH net-next v4 04/12] dt-bindings: net: qcom,ethqos: Add Qualcomm sc8280xp compatibles Andrew Halaney
2023-04-11 20:04 ` [PATCH net-next v4 05/12] net: stmmac: Remove unnecessary if statement brackets Andrew Halaney
2023-04-11 23:40 ` Jesse Brandeburg
2023-04-11 20:04 ` [PATCH net-next v4 06/12] net: stmmac: Fix DMA typo Andrew Halaney
2023-04-11 23:40 ` Jesse Brandeburg
2023-04-11 20:04 ` [PATCH net-next v4 07/12] net: stmmac: Remove some unnecessary void pointers Andrew Halaney
2023-04-11 23:41 ` Jesse Brandeburg [this message]
2023-04-11 20:04 ` [PATCH net-next v4 08/12] net: stmmac: Pass stmmac_priv in some callbacks Andrew Halaney
2023-04-11 23:40 ` Jesse Brandeburg
2023-04-11 20:04 ` [PATCH net-next v4 09/12] net: stmmac: dwmac4: Allow platforms to specify some DMA/MTL offsets Andrew Halaney
2023-04-11 23:41 ` Jesse Brandeburg
2023-04-11 20:04 ` [PATCH net-next v4 10/12] net: stmmac: dwmac-qcom-ethqos: Respect phy-mode and TX delay Andrew Halaney
2023-04-11 23:42 ` Jesse Brandeburg
2023-04-11 20:04 ` [PATCH net-next v4 11/12] net: stmmac: dwmac-qcom-ethqos: Use loopback_en for all speeds Andrew Halaney
2023-04-11 23:45 ` Jesse Brandeburg
2023-04-11 20:04 ` [PATCH net-next v4 12/12] net: stmmac: dwmac-qcom-ethqos: Add EMAC3 support Andrew Halaney
2023-04-11 23:47 ` Jesse Brandeburg
2023-04-11 20:49 ` [PATCH net-next v4 00/12] Add EMAC3 support for sa8540p-ride Andrew Halaney
2023-04-12 15:25 ` Brian Masney
2023-04-13 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f96efb81-ac39-e64a-a8fc-f2f638e1f3c7@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=bhupesh.sharma@linaro.org \
--cc=bmasney@redhat.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=echanude@redhat.com \
--cc=edumazet@google.com \
--cc=hisunil@quicinc.com \
--cc=jernej.skrabec@gmail.com \
--cc=joabreu@synopsys.com \
--cc=jonathanh@nvidia.com \
--cc=jsuraj@qti.qualcomm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=mohammad.athari.ismail@intel.com \
--cc=mturquette@baylibre.com \
--cc=ncai@quicinc.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ruppala@nvidia.com \
--cc=samuel@sholland.org \
--cc=simon.horman@corigine.com \
--cc=tee.min.tan@linux.intel.com \
--cc=veekhee@apple.com \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).