From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C8FBC433EF for ; Tue, 14 Jun 2022 13:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wpTTXsf01qKOvAyKAl6vnT7ojJ3HDiM7TCBgdfpuxyE=; b=lY8elSn+giDBPw Q1ejH7tqHaDX/uAzqTXQejHSTcTNXzSeGUnriuS3Na+IeXccKTXD0jZBBCDd/vB0XgB36/ZOi3mJt FgGk5uKuKH+jRFOk/m+M8q85MCa+W6Sb1oM87qirCqQX+N2NV2js/A5PVJhQD37IWbE0pw5GyVIy6 Y4LXlh2ULM8RyUAEWggKmaa+cBoU7G7ae+kWF6rJLgYzWHAP0PmkCjcWFu1zemLnL+ecMzEzlHpYT 6CfhpszO1rgpjM43bUSyxPICCVbHXqYFPY9N4nyZQaqNwdB53dHhb9VX1gTNt7eTWOBDK6PvzcPdi dXb1QTs1P6ZnY0q5heeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o16j0-009mCU-0C; Tue, 14 Jun 2022 13:36:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o16iw-009mBa-Nv for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 13:36:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 535161650; Tue, 14 Jun 2022 06:36:48 -0700 (PDT) Received: from [10.57.82.209] (unknown [10.57.82.209]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7E8703F73B; Tue, 14 Jun 2022 06:36:47 -0700 (PDT) Message-ID: Date: Tue, 14 Jun 2022 14:36:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] drm/arm/hdlcd: Take over EFI framebuffer properly Content-Language: en-GB To: Javier Martinez Canillas , liviu.dudau@arm.com Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org References: <0f96c44b10dcd1444ad43e6027fd5c6aff34e54d.1655211704.git.robin.murphy@arm.com> From: Robin Murphy In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_063650_873723_705431FF X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-06-14 14:26, Javier Martinez Canillas wrote: > Hello Robin, > > On 6/14/22 15:04, Robin Murphy wrote: >> The Arm Juno board EDK2 port has provided an EFI GOP display via HDLCD0 >> for some time now, which works nicely as an early framebuffer. However, >> once the HDLCD driver probes and takes over the hardware, it should >> take over the logical framebuffer as well, otherwise the now-defunct GOP >> device hangs about and virtual console output inevitably disappears into >> the wrong place most of the time. >> >> Signed-off-by: Robin Murphy >> --- >> drivers/gpu/drm/arm/hdlcd_drv.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c >> index af59077a5481..a5d04884658b 100644 >> --- a/drivers/gpu/drm/arm/hdlcd_drv.c >> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c >> @@ -331,6 +331,8 @@ static int hdlcd_drm_bind(struct device *dev) >> goto err_vblank; >> } >> >> + drm_fb_helper_remove_conflicting_framebuffers(NULL, "hdlcd", false); >> + > > Seems you are using an older base, since this function doesn't exist anymore > after commit 603dc7ed917f ("drm/aperture: Inline fbdev conflict helpers into > aperture helpers"). Ah, you got me! I'm having to work with a 5.10 kernel at the moment, but the randomly-disappearing console had finally sufficiently annoyed me into figuring out and fixing it. > Instead, you should use the drm_aperture_remove_framebuffers() function, i.e: > > + drm_aperture_remove_framebuffers(false, &hdlcd_driver); > > If you do that and re-spin the patch, feel free to add: > > Reviewed-by: Javier Martinez Canillas Thanks for the advice and review - I'll send a v2 later once I've had time to build and boot test 5.19-rc. Cheers, Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel