From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E507AC4345F for ; Wed, 24 Apr 2024 16:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VXkDKCA6iQoIYEgcLPyuF11iJpp+XU+m6E8wNkva8hk=; b=UR2bS/4Cm1Qmq/ TpPuaoRxb5YOCX+2GI2HwnRaUmOrja6QmF6RRdmZ296Bz+jLfq9R+dahGvVnmWs2WmJcqi2mKItro JsQVMFfRsopLcs7dDyejeSSO+0AgtxOQjsjOBa/0lXbCf3TPjye6CXy4rbgt+oponL6Aopm/mj4Py ylasr8ecRwlpCKaHDHtHJTookaYVuOpxdFMtvisrACkY3eywIkxy+tYaMiG2glQhpM1XvO1/BpxCT nvyCebtoVg5HKQqfoQh5Xplgi1k/5mkYfqMf1zcUEsUAI6AlkDyTDnljei+Z+BzIeg8vLDtJyD6kM 7dOnnfoTCKBmR2uy1dag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzfpW-000000051aZ-0Vro; Wed, 24 Apr 2024 16:50:46 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzfpT-000000051a3-4A9v for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 16:50:45 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6ed2170d89fso847877b3a.1 for ; Wed, 24 Apr 2024 09:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713977442; x=1714582242; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C0NdAJuF+6J2kXUl8f5yMWn7Na8Bw9VM1YHloavWwDc=; b=d+Egk+eGR0ig94NPTHir3zahPYJAb3XGs0SHb+qIgXsRbq7HBAwHl2f2ht0q8pPLQB tOzVX/RRWsyh+cZ6+i9deIGjSBXD0wAmKwNk3AJOJR/ClA11tNPE8RQCbvE+YB1UMPPG ElrSmBaRat3YlGamf0uK7EPysg/ecTabooTmyhj0sptac35M9Q160zhnKoXfbUofAb3V 8wKt7xPxwgCo2tn0ISY5b9mi+Eli4Owa1da2T1ns73qE7O0AGVzT5n3VAVyrsgeKaYxu Qd/2UZn5bQJgVErC2YNWryCRKA0ylh4+nbC7j8S8IhN9gtKsll0xRjdweGJt+vglC6VG 2cjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713977442; x=1714582242; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C0NdAJuF+6J2kXUl8f5yMWn7Na8Bw9VM1YHloavWwDc=; b=slil+GGhSadtZNTrpKmk/uLy9EIy4bidhHMUERMml2sKveNn6HmjEgUlMZ1mqYhTor T8wZxypM7+UNcFJWJggU9pfLPyxjhuJT/BP5oPIh1EYVj/7lsSdNT8w+FKJ+sxoJtCnQ xGco48/OBduz0i9JmlPAl3XdayYrYQrYVp5/o0EBIAuXn8NbRcCAh2Mu9fRyIvcB4O8/ DjPPNmng8gStDvysu47Uaa2SJliiObIbF1IAP14oi6hjozStzAa7z7kg56GV0zOs23/5 subr2jePyFqxijXLWnQgjvnGy7RfYdFiw3PiLmIpg3iSHc0tGg70pLdStd9vkGNDnxFS XvHg== X-Forwarded-Encrypted: i=1; AJvYcCWK9+gF3lq19r6otCQBaKihb07GK/IdTKfRKmhL/m3AGZ/pyJlXtFzV9ZaEiq2TT5AUch/W5VKS7JzyU1+1wyf3fDbnsEO8/tgg7mH334TE+zge8qw= X-Gm-Message-State: AOJu0Yx/U/VtUYMl5Shn0MIymQAptzMG+jMYKz7wnIhumDE39lZr9R+U PREQXGihjRX545yFlIdWi9yAqMeFoipu9en7WHA5y9BIzwVhhzWr X-Google-Smtp-Source: AGHT+IF7eqgzrHwVVGjjqO23Dkp/jyBqlHb26nGgNc0SrpkVDyhfZEK5f1RlgUaOzNYPEibfY3B/BQ== X-Received: by 2002:a05:6a20:564b:b0:1a9:509c:eba6 with SMTP id is11-20020a056a20564b00b001a9509ceba6mr326569pzc.25.1713977442298; Wed, 24 Apr 2024 09:50:42 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id ka1-20020a056a00938100b006ecfb733248sm12051094pfb.13.2024.04.24.09.50.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 09:50:41 -0700 (PDT) Message-ID: Date: Wed, 24 Apr 2024 09:50:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] irqchip/irq-brcmstb-l2: Avoid saving mask on shutdown To: Thomas Gleixner , Florian Fainelli , linux-kernel@vger.kernel.org Cc: opendmb@gmail.com, Tim Ross , Broadcom internal kernel review list , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20240416194343.469318-1-florian.fainelli@broadcom.com> <87le55ulw5.ffs@tglx> <958c27b1-26d7-4927-976b-4502f33f31f7@gmail.com> <87il09ufl4.ffs@tglx> Content-Language: en-US From: Florian Fainelli In-Reply-To: <87il09ufl4.ffs@tglx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_095044_069523_0AD0FC7B X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/22/24 16:45, Thomas Gleixner wrote: > On Mon, Apr 22 2024 at 15:26, Florian Fainelli wrote: >> On 4/22/24 14:29, Thomas Gleixner wrote: >>>> + if (save) >>>> + b->saved_mask = irq_reg_readl(gc, ct->regs.mask); >>> >>> what's the conditional actually buying you except more complex code? >> >> Not much this is an optimization that is simple to carry out. There can >> be dozens of such L2 interrupt controllers in a given system and the >> MMIO accesses start adding up eventually. > > I'm impressed by saving ~12 microseconds per one dozen of interrupt > controllers on system shutdown :) I know, right? More seriously are you willing to take that patch, should I write a better justification? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel