From: Adrian Hunter <adrian.hunter@intel.com>
To: "Asutosh Das (asd)" <asutoshd@codeaurora.org>,
cang@codeaurora.org, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v13 0/2] Enable power management for ufs wlun
Date: Tue, 30 Mar 2021 13:07:47 +0300 [thread overview]
Message-ID: <f9b27a18-777b-10db-71ab-90f29f79bffc@intel.com> (raw)
In-Reply-To: <e2aec2ba-b0ed-a478-7c01-1784f755a805@codeaurora.org>
On 30/03/21 1:48 am, Asutosh Das (asd) wrote:
> On 3/24/2021 6:39 PM, Asutosh Das wrote:
>> This patch attempts to fix a deadlock in ufs while sending SSU.
>> Recently, blk_queue_enter() added a check to not process requests if the
>> queue is suspended. That leads to a resume of the associated device which
>> is suspended. In ufs, that device is ufs device wlun and it's parent is
>> ufs_hba. This resume tries to resume ufs device wlun which in turn tries
>> to resume ufs_hba, which is already in the process of suspending, thus
>> causing a deadlock.
>>
>> This patch takes care of:
>> * Suspending the ufs device lun only after all other luns are suspended
>> * Sending SSU during ufs device wlun suspend
>> * Clearing uac for rpmb and ufs device wlun
>> * Not sending commands to the device during host suspend
>>
>> v12 -> v13:
>> - Addressed Adrian's comments
>> * Paired pm_runtime_get_noresume() with pm_runtime_put()
>> * no rpm_autosuspend for ufs device wlun
>> * Moved runtime-pm init functionality to ufshcd_wl_probe()
>> - Addressed Bart's comments
>> * Expanded abbrevs in commit message
>>
>
> Hi Adrian
> I did a limited testing on your fix in the pm framework along with this v13 patchset. I couldn't reproduce the issue.
>
> I'd appreciate if you can please take a look at the v13 changes.
> If all looks good in that, I'd do an extensive testing.
I made a couple of comments on the patch, but nothing major.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-03-30 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 1:39 [PATCH v13 0/2] Enable power management for ufs wlun Asutosh Das
2021-03-25 1:39 ` [PATCH v13 1/2] scsi: ufs: Enable power management for wlun Asutosh Das
2021-03-30 10:03 ` Adrian Hunter
[not found] ` <e2aec2ba-b0ed-a478-7c01-1784f755a805@codeaurora.org>
2021-03-30 10:07 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9b27a18-777b-10db-71ab-90f29f79bffc@intel.com \
--to=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).