From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59226CD4F54 for ; Thu, 21 May 2026 00:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VAyMNRwKRcog5AVZKDly66pNXBdsBjrhviVz0YQNz04=; b=kJQ4h83AMX82HTTjRTosoT0gt9 JPO5wc6KtQE/kjon+cvhAvZC17C1BX59UsQqgT1H5tYfq0ndPRv6Yac4vr+AIYMdg4S/+p1qnyOKl URW7u8DF/lL95Ve0iKzZwGkJXeLZ6zpQJdCXuEA2gwLJT4SZKsS5dEbebUIjFWGfmmMRDjKh40as3 5RfAXG1oY12AimXmyFSQzHyoqQTQjC4fbmkvcn95sWOuoD90EdCFj5ysL635jHhpsQJkoe7lBpFTn hhBb4dLUuPTGvWxQHSUfZZz+FFW0tpqhNDqdjt6MGFNvgXrb1zWPkufw1aoCtK/OkvFgEJznVNyvK Q39Rqi6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPrdG-00000006JKH-1Jzr; Thu, 21 May 2026 00:51:26 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPrdD-00000006JJa-0mr6; Thu, 21 May 2026 00:51:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1779324677; bh=arSk2JLb7QUS+XlkRypR39OwcccG3078jR5uHlxGM/k=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=T2f4YxCa1yBlYqFhB5tknvzvZ/liruTCLp8Vlzk35NLTNUxzOTDTuuzoQnp8XCsWe Ghikn3Lf74f2Uj3rnqv4EOw5AXbAl1QSsE5EeivXDMokOjeAmhNTjvsMb7qbEDSfVl 5/OL3fssk9U/qY5ShtJll1TE/6L8uXBWNN+xloTsZGQbfTAmTBiYo8siQ9Uuh5plOl /YyhJ7G0vnfHZbcPclW5Jgye2ufDD1mgz1yEialk6oR4pmapM9NCd6UKnuMPDVEVFD ryPHtLx1syLKd6hf25XWjY2yaVqJo27yLI9QJz8p05rBsVAp7JXW/mGiVUKh9810Ug TeSTMvc8Oqw1w== Received: from [100.64.0.214] (unknown [100.64.0.214]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id 750AD17E0234; Thu, 21 May 2026 02:51:16 +0200 (CEST) Message-ID: Subject: Re: [PATCH v2] media: rkvdec: fix PM runtime teardown ordering in remove From: Nicolas Dufresne To: Francesco Saverio Pavone , jonas@kwiboo.se, detlev.casanova@collabora.com, hverkuil@kernel.org, mchehab@kernel.org Cc: ezequiel@vanguardiasur.com.ar, heiko@sntech.de, stable@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 20 May 2026 20:51:14 -0400 In-Reply-To: <20260518145414.64514-1-pavone.lawyer@gmail.com> References: <20260518105413.42147-1-pavone.lawyer@gmail.com> <20260518145414.64514-1-pavone.lawyer@gmail.com> Autocrypt: addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Organization: Collabora Canada Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-9/VsCBjDISjI7Lc8ZtP/" User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260520_175123_385314_1CC45953 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --=-9/VsCBjDISjI7Lc8ZtP/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le lundi 18 mai 2026 =C3=A0 16:54 +0200, Francesco Saverio Pavone a =C3=A9c= rit=C2=A0: > From: Jonas Karlman >=20 > The current remove() path calls rkvdec_v4l2_cleanup() and > pm_runtime_disable() before pm_runtime_dont_use_autosuspend(), and > frees the empty IOMMU domain after that. With autosuspend still > armed when the domain goes away, the VDPU381 can be left in a dirty > state across module reload and suspend/resume cycles. >=20 > On RK3588 this surfaces as a VP9 inter-prediction bug: from the > second ALTREF frame onward, motion blocks decode with U=3DV=3D0 (BT.709 > green), while intra and static blocks stay correct. Reordering the > teardown to dont_use_autosuspend() -> iommu_domain_free() -> > pm_runtime_disable() -> v4l2_cleanup() makes the symptom go away. >=20 > Tested on a Radxa Rock 5B+ (RK3588, 8 GB LPDDR5) with both the > libva-v4l2-request mpv pipeline and Chromium's V4L2 stateless > decoder. With the fix, 300 random pixel samples on VP9 Profile 0 > clips at 1080p and 1440p match a libvpx software reference exactly > (worst delta 0). Without it, the same 1080p sample at frame 4, > pixel (960, 270) reads HW=3D(0,112,0) vs SW=3D(204,147,116). HEVC and > H.264 stateless decoding via mpv keep running on hardware with no > fallback. >=20 > Fixes: ff8c5622f9f7 ("media: rkvdec: Restore iommu addresses on errors") > Cc: > Signed-off-by: Jonas Karlman > Tested-by: Francesco Saverio Pavone > Signed-off-by: Francesco Saverio Pavone Tested-by: Nicolas Dufresne Reviewed-by: Nicolas Dufresne cheers, Nicolas > --- > Changes in v2: > =C2=A0- Add Cc: ; media-CI flagged that the > =C2=A0=C2=A0 Fixes: target (ff8c5622f9f7) is present in the 6.17, 6.18, 6= .19 > =C2=A0=C2=A0 and 7.0 stable branches, so the fix should reach them too. > =C2=A0=C2=A0 Link to v1: > https://lore.kernel.org/all/20260518105413.42147-1-pavone.lawyer@gmail.co= m/ > =C2=A0=C2=A0 Media-CI report: > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/100124= 849/artifacts/report.htm >=20 > =C2=A0drivers/media/platform/rockchip/rkvdec/rkvdec.c | 5 +++-- > =C2=A01 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c > b/drivers/media/platform/rockchip/rkvdec/rkvdec.c > index 6f5f0422d317..bb95b090a25b 100644 > --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c > +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c > @@ -2066,12 +2066,13 @@ static void rkvdec_remove(struct platform_device > *pdev) > =C2=A0 > =C2=A0 cancel_delayed_work_sync(&rkvdec->watchdog_work); > =C2=A0 > - rkvdec_v4l2_cleanup(rkvdec); > - pm_runtime_disable(&pdev->dev); > =C2=A0 pm_runtime_dont_use_autosuspend(&pdev->dev); > =C2=A0 > =C2=A0 if (rkvdec->empty_domain) > =C2=A0 iommu_domain_free(rkvdec->empty_domain); > + > + pm_runtime_disable(&pdev->dev); > + rkvdec_v4l2_cleanup(rkvdec); > =C2=A0} > =C2=A0 > =C2=A0#ifdef CONFIG_PM --=-9/VsCBjDISjI7Lc8ZtP/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCag5XAgAKCRDZQZRRKWBy 9NU5APwMFBluL6g6766QU+uMgGgxwYcXppMNPnkJlEEwmSVQ4QD/R4746MdSuHfn HqsiVSwonz4lYaPyLE/WF53aDG1G5QU= =9djU -----END PGP SIGNATURE----- --=-9/VsCBjDISjI7Lc8ZtP/--