From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FE69C433EF for ; Tue, 8 Mar 2022 08:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dr/yPws0VG4RXx5SO+XGis41s1xkqtlMpV05sWsOsQg=; b=VObsa2+gk8NxeE C62F5JASRSoFIIFuHbym5cTMusSK6s7ztZNzv7Zw9KFVx4CsW3fv5P7AEcUQBeW+O5zG24U/AYJB7 mm4bN5C5+y/2fXGRXXXn7CIEmrAaESzNQdW2gwqyh49zwyQzf7b6oI9JD9VNbIlcma3XD+AWKqZr8 oBi6gN3WGbnol2hTyegwX3B+iuNIVVe3cBuWFta/R6v/Z8Ixo5e60PJe2ZJtYp2YWAKyvX3NhUk0r SD0tDcq3gKTkaJqnL7HW5sZA5FD6rnhR5BPzsrPAZTH0TKi3vzgvFt6VftFntGeh5v+HgPB4PgiCd ac9xzly2Ny4kphexVrUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRVCG-003Fte-Hk; Tue, 08 Mar 2022 08:27:56 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRVCD-003Fs0-1u for linux-arm-kernel@lists.infradead.org; Tue, 08 Mar 2022 08:27:54 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 6264F3F60B for ; Tue, 8 Mar 2022 08:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646728070; bh=pUg50sDh5ymtm+MSkxgXE+QGITtwAzozR40OUJkKG5c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ofV3+7Ig3o/rtnHSn1WI/7WttcksPcfA/QoKk2p9IidMrDtHTkHeVM/A7kBCUni1y cDpMRLvAwSFGnBw5/k04zefrCqpzBMpWghtNC4DvdS78v04FIq57ZI7pohacBb6Rjt rkmLpptXF7a3gLJMFOKwl7F4vROQF/uInAjm+X231DSfb4dRjioyU6WdTuidz8IFyI z7RrO1JZQ5So0kNUhqOclT9OJt44370oHE8d1facb/F6YmrkOtsE847CTzW2LsNXfu Bw8Ly43qA42cT8zrD1FW+aZNE419OCIxy0oz+nV2FvxvSCLYUAakNQ7aB95lrhW3sx z7kQtrPgpxLBw== Received: by mail-ed1-f69.google.com with SMTP id bd4-20020a056402206400b004162b6d8618so4391377edb.19 for ; Tue, 08 Mar 2022 00:27:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pUg50sDh5ymtm+MSkxgXE+QGITtwAzozR40OUJkKG5c=; b=Qr4I8FG+K3ZhvkevWNrm+LqndGzyLCFK2/hHZaEd4mx4q+1hN/Ek4fqFmgBS/W1Q7E JDmhqsdQkbme4hG3lkTjnK7VAwUqZg5grvfWG85liECHv0MOJOJMrjPw8U9a80YN3B/8 vIV/0vku5PsN6E/HSWQWp1Tr9TAqXdIX/0GrDWavlkK/lwJ3IPIlJKSGkhuaHIdWVdwM Xy8qRVnrDp0tpdZMLU0IIOSOa9E/QS0hKkheBvwqALzOztJpmZQzlVsRnqrpaNSSeA6b 3mgOTSpt3i7t/kmcBWwmTVGuzcsPL1lmozwsp5oHfXn2sPdTL6uBX2jNStXnM/iIzCxj l7IA== X-Gm-Message-State: AOAM530yivHkqIrPdBnrK4nMta4OM+Ed3vqWgC7Nk427PEAYkXyvFoae wTK9qBWF2I30g/Ged4A7ENlnIjWqN/4/rDd7G6EZdW7L9KS2rGgH1we+UnAbj1i0EZP5roZL2nq cBVBji7huL+VB/xyF3z04+i+5PbAL/zpv+3cree7o9bJiDTOGKzLU X-Received: by 2002:a05:6402:442:b0:416:14b7:4d55 with SMTP id p2-20020a056402044200b0041614b74d55mr14782473edw.183.1646728070136; Tue, 08 Mar 2022 00:27:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3BGB0pMI+5hioCDtbikJ78d+wt3/4IPLNlM66bRumaAAzOEXIcoZ09B602Plxia66ZsA77Q== X-Received: by 2002:a05:6402:442:b0:416:14b7:4d55 with SMTP id p2-20020a056402044200b0041614b74d55mr14782463edw.183.1646728069971; Tue, 08 Mar 2022 00:27:49 -0800 (PST) Received: from [192.168.0.143] (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id g26-20020a50ee1a000000b0041631c5b1f3sm3572278eds.30.2022.03.08.00.27.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 00:27:49 -0800 (PST) Message-ID: Date: Tue, 8 Mar 2022 09:27:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 1/2] dt-bindings: spi: Update clocks property for ARM pl022 Content-Language: en-US To: Kuldeep Singh , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org Cc: Rob Herring , Robin Murphy , Linus Walleij References: <20220308072125.38381-1-singh.kuldeep87k@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220308072125.38381-1-singh.kuldeep87k@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220308_002753_335584_63E114A2 X-CRM114-Status: GOOD ( 21.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/03/2022 08:21, Kuldeep Singh wrote: > Add missing minItems property to clocks in ARM pl022 bindings. > > This helps in resolving below warnings: > clocks: [[4]] is too short > clock-names: ['apb_pclk'] is too short > > Signed-off-by: Kuldeep Singh > --- > v2: > - Keep actual warning and remove path to file > - Reword commit message a bit It still misses information whether it is actually correct from PL022 point of view to have just one clock. If the DTS are wrong, do not change the bindings to match such wrong DTS. If the DTS is correct, please explain why bindings are wrong. > > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 6d633728fc2b..7d36e15db5b3 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -34,6 +34,7 @@ properties: > maxItems: 1 > > clocks: > + minItems: 1 > maxItems: 2 This does not match clock-names which requires two clocks. It's not correct now. > > clock-names: Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel