From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24CCCC2B9F8 for ; Tue, 25 May 2021 16:01:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E14F2613F5 for ; Tue, 25 May 2021 16:01:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E14F2613F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=sAbcJgZyepN+GMYee0YPAl1DC6iqbHrxg32qT0PIbkE=; b=BTsF+TXQaVS+mrLeMISuO/plMR O9AjUszaz4+Uq55dSee0cqa6ngVWADTeb7wZ/q3qPYCGSnI5oTJkcX3NruKvL7UNXO1/WXsT3WM67 texv50ACAbiL2TQDR/UUyfSFqClqaw0UhNFpiV/QrYFPQghMhx94CnxUOsIXkzcMxeiLYnyldKMeR OA+9MFPYhewoiqBe/ZDSy/sVYDGew/Ez4RMxT5TuM4f0FuQxg81gFy7UoiUUfl2/qvewaU4FMn98l fr4aMxLlGdGI5S0mv2f5W5+1udjXzZVfzvfToK/bJHadFa0os+WUX8peTpBoRiUt/Ay+o3fD2/u04 ClMofJIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llZSr-006D6A-7I; Tue, 25 May 2021 15:59:30 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llYw9-005yi2-0O; Tue, 25 May 2021 15:25:42 +0000 Received: by mail-pj1-x1029.google.com with SMTP id gb21-20020a17090b0615b029015d1a863a91so13459788pjb.2; Tue, 25 May 2021 08:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jL+DBxWN5edIJOrVtHSuYvmFZqk3JNDdtDmQJkkStO8=; b=ADsWXFPQuNNtwHEJoJyXj5LyZS40qB6RUp/8KdRTz+SQQiOqa8lPfdkQHPDPKrCTkC 57WkUmg43+E1w/Tv4GssLcUeeQ3ruJGpOVJIzWiVkVd+vOJFeCdy+S76xch1GFZGW1Vk HZnJvLO+oME00P5s5Ljv09YiSEXvjrcjGTTQv+80Cpn2zh9zZCIpTLdVPdWfy14un5zK 6qrdGICT2DDsaTi+9xvggt6WpE8VwTWY9y389K6wcE2VjFJQ2nAw+om9OChuhy1NIkQ1 4ETtFDx7gN8gP4PNo49FXBG5sEs6QVNWagv1L8oI/nJhoDVDkGuNOwg6nO039jt/ne0S mANA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jL+DBxWN5edIJOrVtHSuYvmFZqk3JNDdtDmQJkkStO8=; b=jDfHGbdNHgWJQuqWvAUhzxceZzD2Dgo0a7ERkRzlO1QEFUl6TpRkoaTyG8ZrcxVY4j gdqIEYFq4R780tGF0LvD2UawOnX+UmpNXMz9BM0IW1qvCpCBSNMoQZNQU0/+eUhvIB1y u8A1lfHcT54FGo2ppe5fn3bUY319OCXFTzUFoL4T3B8+vYJTNkqT+FPP77PydXbjzrRK 9tfT9HFHCif4U5FO/3NvFX4WMlmJFgDr2qK/ODMe0GFZYND0u4Ng5iKmhfLPvCiGZadD 3ciW7+SETvUWX3jtV4AbqADmnx2T2PFqRPCtJpSfB6eVAhAlirc8CNocVmOvrfZcOJ63 0clA== X-Gm-Message-State: AOAM532yJFelsoLm/1+IMbpUm5srziQHidY1bn+SOTTpoWlNUv+W92MX HptKgAO+PlDCt5j2zC5qCWrdCklSRLXA4g== X-Google-Smtp-Source: ABdhPJys9nI4J83yBrIv1q0rF+gkI0iY2Ixso6WRntsxUf21NpnE4gjcHDdIeLCDFoCqGYe/yhkc0Q== X-Received: by 2002:a17:90a:9486:: with SMTP id s6mr5455853pjo.192.1621956340125; Tue, 25 May 2021 08:25:40 -0700 (PDT) Received: from [192.168.1.67] (99-44-17-11.lightspeed.irvnca.sbcglobal.net. [99.44.17.11]) by smtp.gmail.com with ESMTPSA id w15sm2311678pjy.1.2021.05.25.08.25.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 08:25:39 -0700 (PDT) Subject: Re: [PATCH v2 12/12] ARM: dts: bcm2711: Tune DMA parameters for HDMI audio To: Maxime Ripard , Jaroslav Kysela , Mark Brown , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Liam Girdwood , Takashi Iwai Cc: devicetree@vger.kernel.org, Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , linux-doc@vger.kernel.org, Eric Anholt , Nicolas Saenz Julienne , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Maxime Ripard , Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Daniel Vetter , linux-rpi-kernel@lists.infradead.org, Jonathan Corbet , Rob Herring , Dom Cobley References: <20210525132354.297468-1-maxime@cerno.tech> <20210525132354.297468-13-maxime@cerno.tech> From: Florian Fainelli Message-ID: Date: Tue, 25 May 2021 08:25:36 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210525132354.297468-13-maxime@cerno.tech> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_082541_112483_57B90624 X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/25/2021 6:23 AM, Maxime Ripard wrote: > From: Dom Cobley > > Enable NO_WAIT_RESP, DMA_WIDE_SOURCE, DMA_WIDE_DEST, and bump the DMA > panic and AXI priorities to avoid any DMA transfer error with HBR audio > (8 channel, 192Hz). > > Signed-off-by: Dom Cobley > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/bcm2711.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi > index 720beec54d61..9d1dde973680 100644 > --- a/arch/arm/boot/dts/bcm2711.dtsi > +++ b/arch/arm/boot/dts/bcm2711.dtsi > @@ -344,7 +344,7 @@ hdmi0: hdmi@7ef00700 { > interrupt-names = "cec-tx", "cec-rx", "cec-low", > "wakeup", "hpd-connected", "hpd-removed"; > ddc = <&ddc0>; > - dmas = <&dma 10>; > + dmas = <&dma (10 | (1 << 27) | (1 << 24)| (15 << 20) | (10 << 16))>; This uses DT as a configuration language rather than a description here, but this is most certainly an established practice that the bcm283-dma.c supports, with no validation of the various arguments.. great. Is there at least an option to move the meaning of this bitfields into include/dt-bindings/dma/bcm2835-dma.h or something like that? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel