From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D61CC4338F for ; Fri, 23 Jul 2021 15:20:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EC0F60ED7 for ; Fri, 23 Jul 2021 15:20:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5EC0F60ED7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X/s7+UZXteiWkUpTsDXsleX7F631ZN/oVN5gBRB2fL4=; b=qKu8Yi2bBusYrpwBxxZGJVFEEk p05iyYmHHglIbHVJBIGzzCirXkAILaLYWssTFvI7fEbGKkylXFJbrgR5UC7XOokuCSJH6S3r54hsK reRjlF37DjCT+h5XYZUDVptLUkHDZ5V38MMeatMN+wmj8bQw7MeB5vD6dHM7gVJJS+Ss2DmbcY3hW bGpwGr19E1beLd+/Cmm1Bd2Zn0onlP7iJzeSsIh2n7M/BDeed2KW0+nJK2MAUHSjelLDkwYzGE0YJ lrRMfI0O99pQRMUwDCd25wb6LJx+p/4V4Fm+g5mMvDL0D/4qCm3oCrTPHSpJmSXR9RXzXUZ35Mjcu 1sxmevZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6wwj-0057Nj-B4; Fri, 23 Jul 2021 15:18:41 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6wwf-0057ML-Mv for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 15:18:39 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16NFC8FS011862; Fri, 23 Jul 2021 17:18:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=2j6SdK3mmLEGfPB978OQB624qYQ2hLIoQGi0oDsLxCw=; b=MChELJEdxcjgENCWuPwovmlKyaMbik/o3beyUaVeMA++gaO8CSZmNCH/nXweO1axlpnv juSYwR8/zcmkvgajmEwejfzY1OB5gZfJHHMckZHAtpik8DXMdfVI50okhHoFe6nCZ/ys KFaJli5krU17MAebohH/L5k8L0bsgzHsdPrlvLPoPzjfcLcczY78Us/cSfb+IPVm/06c 6oKw7FmO2KjKnVsbShAYwACRvQO0Mg/7L0tJLv2x4go01wyu9k1MtOt3pU8IiuHaezEY 7gAa4V3sn6GooOSErWcpitV1VCfMUwW9jgb5k/zVevtIjA+BX29L84AdntetEj/i3sDU Ew== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 39ygng4kqg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jul 2021 17:18:28 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 02AA410002A; Fri, 23 Jul 2021 17:18:28 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id EAC41228E3D; Fri, 23 Jul 2021 17:18:27 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.47) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 23 Jul 2021 17:18:27 +0200 Subject: Re: [PATCH] ARM: dts: stm32: Fix touchscreen IRQ line assignment on DHCOM To: Marek Vasut , CC: , Patrice Chotard , Patrick Delaunay , References: <20210721181040.126714-1-marex@denx.de> From: Alexandre TORGUE Message-ID: Date: Fri, 23 Jul 2021 17:18:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210721181040.126714-1-marex@denx.de> Content-Language: en-US X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-23_08:2021-07-23, 2021-07-23 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_081838_135071_56378B87 X-CRM114-Status: GOOD ( 29.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek On 7/21/21 8:10 PM, Marek Vasut wrote: > While 7e5f3155dcbb4 ("ARM: dts: stm32: Fix LED5 on STM32MP1 DHCOM PDK2") > fixed the LED0 assignment on the PDK2 board, the same commit did not > update the touchscreen IRQ line assignment, which is the same GPIO line, > shared between the LED0 output and touchscreen IRQ input. To make this > more convoluted, the same EXTI input (not the same GPIO line) is shared > between Button B which is Active-Low IRQ, and touchscreen IRQ which is > Edge-Falling IRQ, which cannot be used at the same time. In case the LCD > board with touchscreen is in use, which is the case here, LED0 must be > disabled, Button B must be polled, so the touchscreen interrupt works as > it should. > > Update the touchscreen IRQ line assignment, disable LED0 and use polled > GPIO button driver for Button B, since the DT here describes baseboard > with LCD board. > > Fixes: 7e5f3155dcbb4 ("ARM: dts: stm32: Fix LED5 on STM32MP1 DHCOM PDK2") > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board") I think you need to keep only one fixes tag. > Signed-off-by: Marek Vasut > Cc: Alexandre Torgue > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > --- > arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi | 24 +++++++++++-------- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi > index 4f6b94f10f4a9..fbf3826933e4d 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi > @@ -38,7 +38,7 @@ gpio-keys-polled { > poll-interval = <20>; > > /* > - * The EXTi IRQ line 3 is shared with touchscreen and ethernet, > + * The EXTi IRQ line 3 is shared with ethernet, > * so mark this as polled GPIO key. > */ > button-0 { > @@ -47,6 +47,16 @@ button-0 { > gpios = <&gpiof 3 GPIO_ACTIVE_LOW>; > }; > > + /* > + * The EXTi IRQ line 6 is shared with touchscreen, > + * so mark this as polled GPIO key. > + */ > + button-1 { > + label = "TA2-GPIO-B"; > + linux,code = ; > + gpios = <&gpiod 6 GPIO_ACTIVE_LOW>; > + }; > + > /* > * The EXTi IRQ line 0 is shared with PMIC, > * so mark this as polled GPIO key. > @@ -61,13 +71,6 @@ button-2 { > gpio-keys { > compatible = "gpio-keys"; > > - button-1 { > - label = "TA2-GPIO-B"; > - linux,code = ; > - gpios = <&gpiod 6 GPIO_ACTIVE_LOW>; > - wakeup-source; > - }; > - > button-3 { > label = "TA4-GPIO-D"; > linux,code = ; > @@ -83,6 +86,7 @@ led-0 { > label = "green:led5"; > gpios = <&gpioc 6 GPIO_ACTIVE_HIGH>; > default-state = "off"; > + status = "disabled"; > }; > > led-1 { > @@ -202,8 +206,8 @@ sgtl5000_rx_endpoint: endpoint@1 { > touchscreen@38 { > compatible = "edt,edt-ft5406"; > reg = <0x38>; > - interrupt-parent = <&gpiog>; > - interrupts = <2 IRQ_TYPE_EDGE_FALLING>; /* GPIO E */ > + interrupt-parent = <&gpioc>; > + interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* GPIO E */ > }; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel