From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, Val Packett <val@packett.cool>
Cc: "Mattijs Korpershoek" <mkorpershoek@baylibre.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Fabien Parent" <fparent@baylibre.com>,
"Bernhard Rosenkränzer" <bero@baylibre.com>,
"Alexandre Mergnat" <amergnat@baylibre.com>,
"Amjad Ouled-Ameur" <aouledameur@baylibre.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: mediatek,mt6779-keypad: add more compatibles
Date: Thu, 2 Jan 2025 13:52:57 +0100 [thread overview]
Message-ID: <fa2033e4-0cb5-47cb-bbe7-cbcdb9318c54@collabora.com> (raw)
In-Reply-To: <2cikysv5mwmc4utckjg7iaqx66ncwu3nsxd4kqipj3gw4mymbf@3gipwanf44ji>
Il 27/12/24 10:12, Krzysztof Kozlowski ha scritto:
> On Wed, Dec 25, 2024 at 04:26:19PM -0300, Val Packett wrote:
>> Add compatibles for SoCs using this device (mt8183, mt8365, mt8516).
>
> This we see from the diff. Say what is less visible, e.g. are they fully
> compatible with other variants? Partially?
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Yeah saying that they are fully compatible would be good here, but anyway
the change is self-explanatory (just IMO - but I know MTK SoCs so stuff appears
obvious to me from time to time, and might not be obvious for others).
Anyway, input maintainers, please let me know if you want to take this (or the
next version) through the input tree or if I should take it in the MediaTek tree
along with the devicetree changes.
Cheers,
Angelo
> ---
>
> <form letter>
> This is an automated instruction, just in case, because many review tags
> are being ignored. If you know the process, you can skip it (please do
> not feel offended by me posting it here - no bad intentions intended).
> If you do not know the process, here is a short explanation:
>
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions of patchset, under or above your Signed-off-by tag, unless
> patch changed significantly (e.g. new properties added to the DT
> bindings). Tag is "received", when provided in a message replied to you
> on the mailing list. Tools like b4 can help here. However, there's no
> need to repost patches *only* to add the tags. The upstream maintainer
> will do that for tags received on the version they apply.
>
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> </form letter>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2025-01-02 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-25 19:26 [PATCH 0/3] mt6779-keypad: fix compatibles and add to mt8516 Val Packett
2024-12-25 19:26 ` [PATCH 1/3] dt-bindings: mediatek,mt6779-keypad: add more compatibles Val Packett
2024-12-27 9:12 ` Krzysztof Kozlowski
2025-01-02 12:52 ` AngeloGioacchino Del Regno [this message]
2024-12-25 19:26 ` [PATCH 2/3] arm64: dts: mediatek: add per-SoC compatibles for keypad nodes Val Packett
2024-12-27 9:11 ` Krzysztof Kozlowski
2024-12-25 19:26 ` [PATCH 3/3] arm64: dts: mediatek: mt8516: add keypad node Val Packett
2025-01-02 10:29 ` [PATCH 0/3] mt6779-keypad: fix compatibles and add to mt8516 AngeloGioacchino Del Regno
2025-01-03 10:58 ` Mattijs Korpershoek
2025-01-07 12:12 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa2033e4-0cb5-47cb-bbe7-cbcdb9318c54@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=amergnat@baylibre.com \
--cc=aouledameur@baylibre.com \
--cc=bero@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fparent@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@baylibre.com \
--cc=robh@kernel.org \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).