From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84883C433B4 for ; Tue, 20 Apr 2021 13:29:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3604460E08 for ; Tue, 20 Apr 2021 13:29:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3604460E08 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7oDm9joJiQ71v1BeKz36YcRzQMqSSfIePuIFO8MeoEE=; b=Alz+NvR+iPQ4T5KjWyInD4kG+ o86IG3fStM7E0pfI2mUbNWRmHw6p8LcJYhFJmcfhj0RNBO+zT8C5xocoMEvnHuDd7p7/tq7gX5tOI z5eb1dB97FRgdX40tNoYTEMCTdsfTrmIIbEhbAbZhDmfrIOuer5SJFxDoawLFa6qDUhVW7xBnaa2O XvwWB1U3IDmy20U4jSVxpfHlWvdtvvFWo61Ok23l73SLWi6u+qgM69OzN4YDCR09fanI7XhKRTQmc O0qm62rbGgmsgby6aP+E816izswnsmw8T8CccTd6cueDbpt0F9ilESXRV7Klfjj5gK3WxsnCPCPm4 qbjVCtFaQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYqQ1-00CDCC-4o; Tue, 20 Apr 2021 13:27:57 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYqPe-00CD3d-Ar for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 13:27:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Message-ID:References:In-Reply-To: Subject:Cc:To:From:Date:Content-Transfer-Encoding:Content-Type:MIME-Version: Sender:Reply-To:Content-ID:Content-Description; bh=cqPRIy4v2i/c1w7ayO1W45KlATKGUfD4CdFjLYlm4kE=; b=SmQdluq7S9NuHxr5LdtGyrY4i2 x9AE+1MQg/kedfXBaNXiFWwzkTyAgf4yj7asslngTOdXMN/PzfA/0U5Gbie5Ohw2jvKhVrYQf2/GI s+/uTWqAAAhLX2WTRB9Bt0bNMg7t5mjvOL4SJpsaZZzQoNiQGY2HT7PcsFFpUtV9ldBEN2xdWepOw 7YJs26eo7h77s6KwxlWilHNeegPS0vnr2+wX53gPqz0YCFfgO/PPEmBOvVHbZ9opOv6tOFQlrHfCm GyNXVrkOgsCW8nRk7R20C/9hjjo+0DJSAQZraVPCzjF9Ps98yL+KxLEojF7xxH4XyIWfWgIqPFCjc NeBufnmg==; Received: from ssl.serverraum.org ([176.9.125.105]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYqPZ-00C96B-1e for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 13:27:33 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 4FBD422249; Tue, 20 Apr 2021 15:27:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1618925244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cqPRIy4v2i/c1w7ayO1W45KlATKGUfD4CdFjLYlm4kE=; b=Li6Cd6/DW5gL1MTAQkmCrunz2p8blk2b9L2zzdexi8NYTetq9sIeaQuqUUgEexHUrNHesb uii8wsgu/3oOz/+/o6JWQbFucGnDZstSqF2ogHqwPYZxYceqQF5R54h8WBHMbwSMJrqmRO zzaVh/gcW6bBQvu4KxdrVS3CnMaE2x0= MIME-Version: 1.0 Date: Tue, 20 Apr 2021 15:27:24 +0200 From: Michael Walle To: Vladimir Oltean Cc: Jakub Kicinski , "David S. Miller" , netdev@vger.kernel.org, Po Liu , Claudiu Manoil , Alex Marginean , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Russell King - ARM Linux admin , Andrew Lunn , Vladimir Oltean Subject: Re: [PATCH net-next 0/5] Flow control for NXP ENETC In-Reply-To: <20210416234225.3715819-1-olteanv@gmail.com> References: <20210416234225.3715819-1-olteanv@gmail.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_062729_273122_0EEF62B1 X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vladimir, Am 2021-04-17 01:42, schrieb Vladimir Oltean: > From: Vladimir Oltean > > This patch series contains logic for enabling the lossless mode on the > RX rings of the ENETC, and the PAUSE thresholds on the internal FIFO > memory. > > During testing it was found that, with the default FIFO configuration, > a sender which isn't persuaded by our PAUSE frames and keeps sending > will cause some MAC RX frame errors. To mitigate this, we need to > ensure > that the FIFO never runs completely full, so we need to fix up a > setting > that was supposed to be configured well out of reset. Unfortunately > this > requires the addition of a new mini-driver. What happens if the mini driver is not enabled? Then the fixes aren't applied and bad things happen (now with the addition of flow control), right? I'm asking because, if you have the arm64 defconfig its not enabled. shouldn't it be something like: diff --git a/drivers/net/ethernet/freescale/enetc/Kconfig b/drivers/net/ethernet/freescale/enetc/Kconfig index d88f60c2bb82..cdc0ff89388a 100644 --- a/drivers/net/ethernet/freescale/enetc/Kconfig +++ b/drivers/net/ethernet/freescale/enetc/Kconfig @@ -2,7 +2,7 @@ config FSL_ENETC tristate "ENETC PF driver" depends on PCI && PCI_MSI - depends on FSL_ENETC_IERB || FSL_ENETC_IERB=n + select FSL_ENETC_IERB select FSL_ENETC_MDIO select PHYLINK select PCS_LYNX -michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel