Re: TI: X15 the connected SSD is not detected on Linux next 20221006 tag

From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Serge Semin <fancer.lancer@gmail.com>, Arnd Bergmann <arnd@arndb.de>
Cc: Anders Roxell <anders.roxell@linaro.org>,
	Niklas Cassel <Niklas.Cassel@wdc.com>,
	Naresh Kamboju <naresh.kamboju@linaro.org>,
	Praneeth Bajjuri <praneeth@ti.com>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	open list <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
	<linux-ide@vger.kernel.org>,
	"lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Carlos Hernandez <ceh@ti.com>,
	Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006 tag
Date: Tue, 6 Dec 2022 18:12:48 +0900	[thread overview]
Message-ID: <fa2bc2b9-d74a-51a3-cb5f-80d04e145b27@opensource.wdc.com> (raw)
In-Reply-To: <20221206084637.olaflvqmxwoo467a@mobilestation>

On 12/6/22 17:46, Serge Semin wrote:
> On Mon, Dec 05, 2022 at 10:24:22PM +0900, Damien Le Moal wrote:
>> On 12/5/22 19:08, Arnd Bergmann wrote:
>>> On Mon, Dec 5, 2022, at 02:11, Serge Semin wrote:
>>>> On Thu, Dec 01, 2022 at 12:48:32PM +0100, Anders Roxell wrote:
>>>
>>>>>
>>>>>   for (i = 0; i < hpriv->n_clks; i++) {
>>>>> - if (!strcmp(hpriv->clks[i].id, con_id))
>>>>> + if (hpriv->clks && hpriv->clks[i].id &&
>>>>> +    !strcmp(hpriv->clks[i].id, con_id))
>>>>>   return hpriv->clks[i].clk;
>>>>>   }
>>>>
>>>> Indeed I should have taken into account that devm_clk_bulk_get_all()
>>>> can get unnamed clocks too. But checking the hpriv->clks pointer for
>>>> being not null is redundant, since the ahci_platform_get_resources()
>>>> procedure makes sure that the array is always allocated. At the very
>>>> least you shouldn't check the pointer in the loop, but can make sure
>>>> that the clks array is available before it.
>>>
> 
>>> Do you think this is otherwise the correct fix then? Any chance we
>>> can still get a version of it into 6.1?
> 
> I'll think of a better solution. But at this stage it seems like the
> best choice seeing the bindings permit having unnamed clocks
> specified.
> 
>>
>> If someone sends me a proper patch to apply, I can send a last PR for 6.1
>> to Linus before week end.
> 
> I'll submit the patch today. Thanks.

Anders just posted one. Can you review it please ?

> 
> -Serge(y)
> 
>>
>>
>>>
>>>      Arnd
>>
>> -- 
>> Damien Le Moal
>> Western Digital Research
>>

-- 
Damien Le Moal
Western Digital Research

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel