From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF6B4C352A1 for ; Tue, 6 Dec 2022 09:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SDomBIPynFRvrCnVaPevoNP8LTrAjfth6Kr8E7YdLbI=; b=tN+Psi8u57v7w8 vdqqOQ/bUCjRFYvMP2XJwZbI2oGLJ0vikdbQYblYcfXxtTBSib9cmLTB+Lwf9nV0Zw/AVhOOX7q+x wAOcMl227Ou61UCkzjMuT2mBy0iqyBwxnlHkuBZZfjdkB/SpcNnVBTFeT5yfprbtg6RDf0xa6AuAn wsK/f0lBIgAav3zJd8xIDItUMo/ISHWYXsE1H3jJ3cb6/QxmyZcr1BZbrqnHkldDfo9+tDjrOWSrn gNxksIMntQzBKMk+cBLxjKZxT4zo/FiHS3kl9Q36rXInwVbkMiIz1PFeY2hE0rtQUVB41eKEDcgxl hWuPDwoI9Jm6EGipk25g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2U0q-005cKt-NQ; Tue, 06 Dec 2022 09:13:16 +0000 Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2U0m-005blW-0n for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 09:13:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1670317991; x=1701853991; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=4mt0j/vdtWfJcSSBLLsGjJ3hTgh4e+ZqWrii34fueUY=; b=Qa8zMTUkIglwzqJ/4WfVkhRj7zQh/3nCf0oDDLagoKKaD/XEEA4t0/8l TOLcR+yJa3Pf0WYHnIAWiJzW5DfDLfq6RlPUQbo7cH4afqht236h+o7hk jCEqoAs6YQd/uxLm4GNlCQNyoeyuK6YobM8HsoWGmptiUO0m0QyfbXD2r mktvBUcUs2JY5D1FVRcoP4kyBz38j4VIe5nv+oAfpcrj5m40VxYWmzgGL 9RxcT5lmN764zp2xmQFK7VeQoU+nz+uL/nMqAnIgt55FJPilcxVTtTWxT 9edu/q8VPgN7ZF8EoyJR0IGh9imrn3VZasRkNoI+VVHzp26l1zgfTQlqj w==; X-IronPort-AV: E=Sophos;i="5.96,220,1665417600"; d="scan'208";a="216215435" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 06 Dec 2022 17:12:53 +0800 IronPort-SDR: IMdMFn8jwgsW21j9vy0JfptNphhtsEihvLE6MSU+utJfr//7OH2Qn6MWimt6oSdR6nxYnV1A+5 zojs4siESO3vtWnDDW7Pkk1yNcC4m0w4l1BBbKxK2vp+1wPQYcB4J/3OBnl16R3qkQIH+nvqT1 AXGVgpZ5rgH50mqpG188gWdNKoLyaqRp2pPtf+7Z0F+BPUvzPx7Vikiw6cn3jEInrn9vTMhakO mX2anm7sP6sA48V38GCzPpMTwaePv0jWNciKnmW6vlvw8FltZVj+etVVLzDJ1gBVKs7s5WPXHM b8A= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Dec 2022 00:25:41 -0800 IronPort-SDR: gYgDdHleLKLMQl4HhvWYNI+kceyYsCVDxoPNlQTzX+MUwPwE2Zcvj+U198uRYP5bUnfsN7sHoo oMdPKDWWpd8ap90ylHVIDV14VGMQHNzaUrRhQYvmFDI4PqwnGVNno6UEz3BYbnuoBMxdc/ZYfw oBcLjOoe8OWdTDzoiQAeevUpC4ioAJ9vwQJU4hOtj/PZ/C+UV4kscp6Dy433Wy74ZwGcYjD7pR LPPA6bSF4KzSlzntbFzDyLj2LD6kpqxQ8I7Tr8qEYjoovK053Chq5OSQPQYLcK6sjDwW79qxEd wQ8= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Dec 2022 01:12:55 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4NRF7T2nn8z1RwqL for ; Tue, 6 Dec 2022 01:12:53 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1670317972; x=1672909973; bh=4mt0j/vdtWfJcSSBLLsGjJ3hTgh4e+ZqWri i34fueUY=; b=YNSyUHBzaAuo3ULsinKsC2zO2BLGCy3UVeDKqHthvVvj2MyBt8d KEQA8yVLkKSd3gfSQAQb+PnVDFrHNJOPeOWDJTZnqxUSC+Ho0Ti2B+p1EvLvsL/N YTcAFyY8G5NhmSY53yzHQKnA7VFtc0lu/fSJpEVtfTWx5DDw/bF0bn3He25govb3 nsUWOBFCbvrWuB2DMh5kxLd8RuDY3UW9CQTp+uwXVKKZA10yT8vlvP5mtgB5qAM4 6jsBpQKjgFNZczbuGXW4p5vOYBipJ4SzaNettuVsPzfmMC8JZtXYdENAZWY6nrpp Fa3zaxB3wUKjUdIMUf6tSq6VWTIjmxUTasw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VcDR7pAIikM1 for ; Tue, 6 Dec 2022 01:12:52 -0800 (PST) Received: from [10.225.163.74] (unknown [10.225.163.74]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4NRF7Q0fHvz1RvLy; Tue, 6 Dec 2022 01:12:49 -0800 (PST) Message-ID: Date: Tue, 6 Dec 2022 18:12:48 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006 tag Content-Language: en-US To: Serge Semin , Arnd Bergmann Cc: Anders Roxell , Niklas Cassel , Naresh Kamboju , Praneeth Bajjuri , Serge Semin , open list , Linux ARM , "regressions@lists.linux.dev" , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "lkft-triage@lists.linaro.org" , Lukas Bulwahn , Carlos Hernandez , Sumit Semwal References: <20221014140633.mlypet7skkxvt453@mobilestation> <20221017155246.zxal2cfehjgaajcu@mobilestation> <20221205011105.4do4trbytq4bfw5b@mobilestation> <98670e23-6553-4788-8662-9403c480af82@app.fastmail.com> <20221206084637.olaflvqmxwoo467a@mobilestation> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20221206084637.olaflvqmxwoo467a@mobilestation> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_011312_157054_F930D21C X-CRM114-Status: GOOD ( 21.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/6/22 17:46, Serge Semin wrote: > On Mon, Dec 05, 2022 at 10:24:22PM +0900, Damien Le Moal wrote: >> On 12/5/22 19:08, Arnd Bergmann wrote: >>> On Mon, Dec 5, 2022, at 02:11, Serge Semin wrote: >>>> On Thu, Dec 01, 2022 at 12:48:32PM +0100, Anders Roxell wrote: >>> >>>>> >>>>> for (i = 0; i < hpriv->n_clks; i++) { >>>>> - if (!strcmp(hpriv->clks[i].id, con_id)) >>>>> + if (hpriv->clks && hpriv->clks[i].id && >>>>> + !strcmp(hpriv->clks[i].id, con_id)) >>>>> return hpriv->clks[i].clk; >>>>> } >>>> >>>> Indeed I should have taken into account that devm_clk_bulk_get_all() >>>> can get unnamed clocks too. But checking the hpriv->clks pointer for >>>> being not null is redundant, since the ahci_platform_get_resources() >>>> procedure makes sure that the array is always allocated. At the very >>>> least you shouldn't check the pointer in the loop, but can make sure >>>> that the clks array is available before it. >>> > >>> Do you think this is otherwise the correct fix then? Any chance we >>> can still get a version of it into 6.1? > > I'll think of a better solution. But at this stage it seems like the > best choice seeing the bindings permit having unnamed clocks > specified. > >> >> If someone sends me a proper patch to apply, I can send a last PR for 6.1 >> to Linus before week end. > > I'll submit the patch today. Thanks. Anders just posted one. Can you review it please ? > > -Serge(y) > >> >> >>> >>> Arnd >> >> -- >> Damien Le Moal >> Western Digital Research >> -- Damien Le Moal Western Digital Research _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel