From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 074EAC52D7C for ; Mon, 12 Aug 2024 13:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Oz+QDOX3MjRcz606HQtmkNBM13LcKcsPU8wGmL/TJ5E=; b=ZJ5TPXkMlzMT1z7g9MjH//NwYW GIMI8G8VDk626KoX/6iqVvkcIqFXgqdpjna3anZrrODiOtyabgcyCII7Xt1f2/tWLUMT6YfqnFBB3 hr+CLh341iBhLoMjDJdnWBXxx5OPthdHyAtws3Ulm1T3Sz2OXYnu3M37+iTFX8Xq9pUbkn7fAd6Wv Abid3ZkywkzDnB/dQKGvgo23o51o4vEpL2fphxiJXacG1dRP9tNwK54m0ERf+dswEcGjY3cptitqf TsCT4egR9Cfn/CJVzZxZrWtUWL1rpcACyZLK7Ouf2Lzug0mxd+2z+7MvyB2jhuqzfGgquKPc9HbEm Rp54yCNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdUpm-00000000MsQ-2SoI; Mon, 12 Aug 2024 13:11:38 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdUpB-00000000Mo0-1UPL; Mon, 12 Aug 2024 13:11:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 80D7261213; Mon, 12 Aug 2024 13:11:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F0DBC32782; Mon, 12 Aug 2024 13:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723468260; bh=9pceFmA6z72sxXOnjaTJNtiGDc0SYLeSFqZUE6qpFJ8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nQRlUWwh5V08H11ZQcdD8ZiQk+rCMZMm7Fn1PkF6FaTY8q5k5DtgYuTz7IoTxLYF/ PdOZRQTsCs9CbWtjp2InABfukKIA/x6cyArzEXeu1DW/4VCHoZ6PUGX7oNJiflh0Yv cHofsaiv6CQfJmeWhw9kMISyKLGSnGaXw8Bxhqw/4QXx6vjYCHT7J884YbxEKr975B 0gUpp/uSuJffqI/sCV5KfkQ8jZdRHATGQv75Hxi1wAuGAzDKPIyk1ymlDfKSvtwEUV ErOstJZr6Y0rRWfCMti2qti7r071pcL+gBuVJqfBqVVRCEO0TVKlYGJAS8f3+nbH+w rw6IGcHWfeH1A== Message-ID: Date: Mon, 12 Aug 2024 15:10:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/8] hwmon: (amc6821) add support for tsd,mule To: Quentin Schulz , Guenter Roeck , Farouk Bouabid Cc: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Rosin , Jean Delvare , Heiko Stuebner , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20240725-dev-mule-i2c-mux-v6-0-f9f6d7b60fb2@cherry.de> <20240725-dev-mule-i2c-mux-v6-4-f9f6d7b60fb2@cherry.de> <5d5c44cd-6320-4fcd-9409-f3fc97bc5389@roeck-us.net> <40ff0c23-f037-454c-9d79-05dd72655052@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240812_061101_549214_56E7B60F X-CRM114-Status: GOOD ( 27.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/08/2024 13:58, Quentin Schulz wrote: > Hi Krzysztof, > > On 8/12/24 1:38 PM, Krzysztof Kozlowski wrote: >> [Some people who received this message don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] >> >> On 31/07/2024 17:12, Guenter Roeck wrote: >>> On Thu, Jul 25, 2024 at 03:27:50PM +0200, Farouk Bouabid wrote: >>>> Theobroma Systems Mule is an MCU that emulates a set of I2C devices, >>>> among which is an amc6821 and other devices that are reachable through >>>> an I2C-mux. >>>> >>>> The devices on the mux can be selected by writing the appropriate device >>>> number to an I2C config register (amc6821: reg 0xff) >>>> >>>> Implement "tsd,mule" compatible to instantiate the I2C-mux platform device >>>> when probing the amc6821. >>>> >>>> Signed-off-by: Farouk Bouabid >>>> Reviewed-by: Guenter Roeck >>> >>> Applied. >> >> Eh, there is undocumented dependency on I2C here. Next has warning >> because of this. >> > > I think you meant to comment this on > https://lore.kernel.org/linux-i2c/20240725-dev-mule-i2c-mux-v6-0-f9f6d7b60fb2@cherry.de/T/#mdb7976f1dc16fce0b7db9abee6fd0b1fd0a2e2ba > (patch 3 and not 4 of the series). This patch (4) is fine on its own I > believe, no dependency on anything else. (well, except if we expect > bindings to be absolutely merged before the drivers? I think what > matters is the Device Tree changes making use of the new binding be > merged after dt-binding changes?). Yeah, this was about DT binding. > > I agree that there's a somewhat non-obvious dependency between patch 1 > and 3 (the dt-bindings) and 5-8 with everything before, we could have > made this more explicit. > >> Farouk, please *always mention* the dependencies between patches. >> > > I wasn't aware of that rule, my apologies for not catching this before > upstream submission. > > For anyone wondering the rule is made explicit here: > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes > > "If one patch depends on another patch in order for a change to be > complete, that is OK. Simply note “this patch depends on patch X” in > your patch description." > > Question about b4 workflow though. I encourage using b4 to avoid as many > mistakes as possible and make the workflow as painless as possible. I > believe b4 doesn't allow you to have per-patch notes, only in the > cover-letter. "Patch description" or "per patch notes" is whatever you write in changelog, so under ---. > a) is this dependency list in cover-letter acceptable, or > b) need to add it to the patch note (below the ---), or One of above should be enough, both are more welcomed because many maintainers ignore completely cover letters. > c) can add it to the patch commit log No, if patches go through separate trees then it would be just confusing and not helping at all. Best regards, Krzysztof