From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 069BFC433DF for ; Wed, 14 Oct 2020 15:47:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EEA52222C for ; Wed, 14 Oct 2020 15:47:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S/4RwgrQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="X4aAHpmK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EEA52222C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k7Hekya6Qn2+9OBlz2fx6lK4oFF22qrz1KPOyBD7pFk=; b=S/4RwgrQUsTmnWhhugBRVB0Q3 vj8lt74t6UG3vYiGg/FxSWZlHFIC/W7Vwm/If9h70KeaTEJRlbvllEMeyoXBPthYcqUf7Eh/67PDs O4JljriKKfhVR6zpDhl4ppzbnsxmRglFIhIHYsKAEBeef4H4ufPuidWxbfip7VCKVyNG9t16PArdC vRRnCHvHFDT3XCcJzYrNPaBSSxVRu2oydwSOv7utPLUOV6JD+psMKYwO8ix3tA2fOUsJIZ0kT9eFU EQC0UwnZEe/+aIRvc39DGv40exvTK7LVKoYrO7A/BUQrY0oy4iqVhbS6/FwE6VT+Sew+k4xNrxS5P pNR48mi1g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSiyT-00019f-0V; Wed, 14 Oct 2020 15:45:57 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSiyP-00017s-LW for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 15:45:54 +0000 Received: by mail-io1-xd44.google.com with SMTP id u19so5780631ion.3 for ; Wed, 14 Oct 2020 08:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GVsFzR74egr+o93/X35XS2maZ1vLsmxHPBrJlJDsuhI=; b=X4aAHpmKSHgU3/84qpUaV903w1xkwCtvsv7XMV8dUuc9QnpjmB/jKfLFcdpqh7UmY4 IG9lWFz+HRgkE8tRa/pOXAXobj0l94fXgiNfyoap+V7yrzg1LQqQgDVrbGZk1Qt7MpXw IsWNMw7UDTAPcoV7udFaMBNkFCpbRweWEvQFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GVsFzR74egr+o93/X35XS2maZ1vLsmxHPBrJlJDsuhI=; b=nT8+h6VyiTtKYi1tzFU6ESkkUSEmoVs5UuGsoIfFVtoBdDi9lE5xyPh8R6kJkpCzh2 7gUX15RvwTfbac83SIj0NVQPpQ+UgZ2xOSgPs+vo1IPuOUzUYotVRez26nK9EdBzbnHR Q/bmQhqAsR7qjuK3yfCozzU/KWqYItMbbQbGRuiXAkyw+wQtkuP+nHOmfrtikcEASpUo t1aD6NoUXE62ltmv6rKH0tSjaQ3yvOlq8hpROy61JsMJEot7cTUvp5PXuugb9+uzuN8k GUaTSQ/swm/cjsk5Z6JPuKW8DHzBsXrHk93vPMQj6AADFWNeI/o9bP+vxdFbRBiaj1c+ ch0A== X-Gm-Message-State: AOAM532obGaHqeDXUmJx3AhlxOTh+/6K3T8lYKsyROwYde5t+6cMgh/Y 2Tcge1LQ1O11OOLwhSBclbxjZQ== X-Google-Smtp-Source: ABdhPJxFL0dEO8+kC0xlhiweNLkyf1APFnjIPT9B9l6CjUgbzU9W6XQstgVJjfauCC4EZCo/jPEspg== X-Received: by 2002:a02:a510:: with SMTP id e16mr43790jam.51.1602690351653; Wed, 14 Oct 2020 08:45:51 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id t22sm3922965ili.9.2020.10.14.08.45.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 08:45:50 -0700 (PDT) Subject: Re: [patch 07/12] usbip: Remove in_interrupt() check To: Thomas Gleixner , LKML References: <20201014145215.518912759@linutronix.de> <20201014145727.828083323@linutronix.de> From: Shuah Khan Message-ID: Date: Wed, 14 Oct 2020 09:45:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201014145727.828083323@linutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_114553_760987_A95B9816 X-CRM114-Status: GOOD ( 21.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Thomas Winischhofer , Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , Sebastian Andrzej Siewior , linux-usb@vger.kernel.org, Valentina Manea , Krzysztof Kozlowski , Johan Hovold , linux-samsung-soc@vger.kernel.org, Kukjin Kim , Alan Stern , Duncan Sands , "Ahmed S. Darwish" , Shuah Khan , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/14/20 8:52 AM, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_interrupt() in drivers is phased out and Linus clearly > requested that code which changes behaviour depending on context should > either be separated or the context be conveyed in an argument passed by the > caller, which usually knows the context. > > usbip_recv() uses in_interrupt() to conditionally print context information > for debugging messages. The value is zero as the function is only called > from various *_rx_loop() kthread functions. Remove it. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Valentina Manea > Cc: Shuah Khan > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > > --- > drivers/usb/usbip/usbip_common.c | 5 ----- > 1 file changed, 5 deletions(-) > > --- a/drivers/usb/usbip/usbip_common.c > +++ b/drivers/usb/usbip/usbip_common.c > @@ -324,11 +324,6 @@ int usbip_recv(struct socket *sock, void > } while (msg_data_left(&msg)); > > if (usbip_dbg_flag_xmit) { > - if (!in_interrupt()) > - pr_debug("%-10s:", current->comm); > - else > - pr_debug("interrupt :"); > - > pr_debug("receiving....\n"); > usbip_dump_buffer(buf, size); > pr_debug("received, osize %d ret %d size %zd total %d\n", > > Looks good to me. Acked-by: Shuah Khan thanks, -- Shuah _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel