From mboxrd@z Thu Jan 1 00:00:00 1970 From: grant.likely@secretlab.ca (Grant Likely) Date: Wed, 3 Feb 2010 09:35:12 -0700 Subject: [PATCHv2 04/11] mxc: changes to common plat-mxc code to add support for i.MX5 In-Reply-To: References: <0511204199ab83aed2340e70a4639500c0528dab.1265173480.git.amit.kucheria@canonical.com> <9fa7a3c70c46a1f776c6520051481cff6525ef02.1265173480.git.amit.kucheria@canonical.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 2, 2010 at 10:16 PM, Amit Kucheria wrote: > Changes separted to help in the review process Commit log needs to talk about what the patch is, not how it has changed. Please state what the patch does and why. It is also helpful to have testing information. The goal is to make it easy for both patch reviewers on the mailing list *and* people looking at the commit in git after it is merged. This commit message doesn't provide the reader with any helpful information. Patch version/review information like your comment above typically goes below the '---' line. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.