[spi-devel-general] PATCH [1/1] SPI: AMBA_PL022: Limit TX FIFO fills based on current RX FIFO used

[spi-devel-general] PATCH [1/1] SPI: AMBA_PL022: Limit TX FIFO fills based on current RX FIFO used

[Linus Walleij]

2010/1/20 Kevin Wells <kevin.wells@nxp.com>:

> Added logic to cap TX FIFO fill size based on current free RX
> FIFO entries instead of TX status flags. This is to prevent
> an issue with RX FIFO overflows

Excellent patch and works like a charm on the U300. My loopback code
would generate
spurious overfill errors before and now it *never* fails so you hit
exactly the right spot.
I remember being intrigued by this when I worked on the driver and now
it is finally
nailed.

As some sort of maintainer of this file I have signed it off and put
it into Russells
patch tracker for inclusion, OK? See;
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=5893/1

Linus Walleij

[spi-devel-general] PATCH [1/1] SPI: AMBA_PL022: Limit TX FIFO fills based on current RX FIFO used

[Grant Likely]

On Fri, Jan 22, 2010 at 5:56 AM, Linus Walleij
<linus.ml.walleij@gmail.com> wrote:
> 2010/1/20 Kevin Wells <kevin.wells@nxp.com>:
>
>> Added logic to cap TX FIFO fill size based on current free RX
>> FIFO entries instead of TX status flags. This is to prevent
>> an issue with RX FIFO overflows
>
> Excellent patch and works like a charm on the U300. My loopback code
> would generate
> spurious overfill errors before and now it *never* fails so you hit
> exactly the right spot.
> I remember being intrigued by this when I worked on the driver and now
> it is finally
> nailed.
>
> As some sort of maintainer of this file I have signed it off and put
> it into Russells
> patch tracker for inclusion, OK? See;
> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=5893/1

I'm actively maintaining SPI now.  In general, I'd prefer SPI patches
to go through the SPI tree, unless there are commit ordering issues
with arch code.  I'm tracking SPI patches with patchwork:

http://patchwork.kernel.org/project/spi-devel-general/list/

Thanks,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

[spi-devel-general] PATCH [1/1] SPI: AMBA_PL022: Limit TX FIFO fills based on current RX FIFO used

[Linus Walleij]

2010/2/3 Grant Likely <grant.likely@secretlab.ca>:

> I'm actively maintaining SPI now. ?In general, I'd prefer SPI patches
> to go through the SPI tree, unless there are commit ordering issues
> with arch code.

Sorry, will queue them in your tree next time, and thanks for picking
up SPI.

Yours,
Linus Walleij