* Re: [PATCH v4 1/3] MAINTAINERS: add ac5 to list of maintained Marvell dts files
[not found] ` <20231029174814.559583-2-enachman@marvell.com>
@ 2023-10-29 17:52 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2023-10-29 17:52 UTC (permalink / raw)
To: Elad Nachman
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, gregory.clement,
sebastian.hesselbarth, pali, mrkiko.rs, chris.packham, devicetree,
linux-kernel, linux-arm-kernel, cyuval
On Sun, Oct 29, 2023 at 07:48:12PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
>
> Add ac5 dts files to the list of maintained Marvell Armada dts files
>
> Signed-off-by: Elad Nachman <enachman@marvell.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 3/3] arm64: dts: cn913x: add device trees for COM Express boards
[not found] ` <20231029174814.559583-4-enachman@marvell.com>
@ 2023-10-29 18:03 ` Andrew Lunn
2023-10-30 13:32 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2023-10-29 18:03 UTC (permalink / raw)
To: Elad Nachman
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, gregory.clement,
sebastian.hesselbarth, pali, mrkiko.rs, chris.packham, devicetree,
linux-kernel, linux-arm-kernel, cyuval
> +++ b/arch/arm64/boot/dts/marvell/ac5x-rd-carrier.dtsi
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2023 Marvell International Ltd.
> + *
> + * Device tree for the AC5X RD Type 7 Com Express carrier board,
> + * This specific board only maintains a PCIe link with the CPU CPU module
> + * module, which does not require any special DTS definitions.
> + */
> +
> +/ {
> + model = "Marvell Armada AC5X RD COM EXPRESS type 7 carrier board";
> + compatible = "marvell,rd-ac5x-carrier", "marvell,cn9131", "marvell,cn9130",
> + "marvell,armada-ap807-quad", "marvell,armada-ap807";
This sees wrong to me. Say i mount a congatec Module in it. Its then
is not compatible with marvell,cn9131 etc. I think you should just
list the carrier compatible here.
> +#include "cn9130-db.dtsi"
> +
> +/ {
> + model = "Marvell Armada CN9130-DB COM EXPRESS type 7 CPU module board";
> + compatible = "marvell,cn9130-cpu-module", "marvell,cn9130",
> + "marvell,armada-ap807-quad", "marvell,armada-ap807";
> +
> + memory@0 {
> + device_type = "memory";
> + reg = <0x0 0x0 0x2 0x00000000>;
Is the memory soldered down, or socketed?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/3] dt-bindings: arm64: dts: add dt-bindings for Marvell COM Express boards
[not found] ` <20231029174814.559583-3-enachman@marvell.com>
@ 2023-10-30 12:48 ` Rob Herring
2023-10-30 13:22 ` Rob Herring
2023-10-30 13:31 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-10-30 12:48 UTC (permalink / raw)
To: Elad Nachman
Cc: chris.packham, linux-kernel, krzysztof.kozlowski+dt, pali, cyuval,
gregory.clement, devicetree, linux-arm-kernel,
sebastian.hesselbarth, andrew, conor+dt, mrkiko.rs, robh+dt
On Sun, 29 Oct 2023 19:48:13 +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
>
> Add dt bindings for:
> CN9130 COM Express CPU module
> CN9131 COM Express CPU module
> AC5X RD COM Express Type 7 carrier board.
> AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module.
>
> Signed-off-by: Elad Nachman <enachman@marvell.com>
> ---
> .../bindings/arm/marvell/armada-7k-8k.yaml | 15 +++++++++++++++
> .../bindings/arm/marvell/marvell,ac5.yaml | 14 ++++++++++++++
> 2 files changed, 29 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml:37:12: [warning] wrong indentation: expected 10 but found 11 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231029174814.559583-3-enachman@marvell.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/3] dt-bindings: arm64: dts: add dt-bindings for Marvell COM Express boards
[not found] ` <20231029174814.559583-3-enachman@marvell.com>
2023-10-30 12:48 ` [PATCH v4 2/3] dt-bindings: arm64: dts: add dt-bindings for Marvell COM Express boards Rob Herring
@ 2023-10-30 13:22 ` Rob Herring
2023-10-30 13:31 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-10-30 13:22 UTC (permalink / raw)
To: Elad Nachman
Cc: krzysztof.kozlowski+dt, conor+dt, andrew, gregory.clement,
sebastian.hesselbarth, pali, mrkiko.rs, chris.packham, devicetree,
linux-kernel, linux-arm-kernel, cyuval
On Sun, Oct 29, 2023 at 07:48:13PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
Drop 'dts:' from the subject. This is not a .dts file.
Also drop the 2nd 'dt-bindings'. Subject line space is precious.
>
> Add dt bindings for:
> CN9130 COM Express CPU module
> CN9131 COM Express CPU module
> AC5X RD COM Express Type 7 carrier board.
> AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module.
>
> Signed-off-by: Elad Nachman <enachman@marvell.com>
> ---
> .../bindings/arm/marvell/armada-7k-8k.yaml | 15 +++++++++++++++
> .../bindings/arm/marvell/marvell,ac5.yaml | 14 ++++++++++++++
> 2 files changed, 29 insertions(+)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/3] dt-bindings: arm64: dts: add dt-bindings for Marvell COM Express boards
[not found] ` <20231029174814.559583-3-enachman@marvell.com>
2023-10-30 12:48 ` [PATCH v4 2/3] dt-bindings: arm64: dts: add dt-bindings for Marvell COM Express boards Rob Herring
2023-10-30 13:22 ` Rob Herring
@ 2023-10-30 13:31 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-30 13:31 UTC (permalink / raw)
To: Elad Nachman, robh+dt, krzysztof.kozlowski+dt, conor+dt, andrew,
gregory.clement, sebastian.hesselbarth, pali, mrkiko.rs,
chris.packham, devicetree, linux-kernel, linux-arm-kernel
Cc: cyuval
On 29/10/2023 18:48, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
>
A nit, subject: drop second/last, redundant "dt-bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
> Add dt bindings for:
> CN9130 COM Express CPU module
> CN9131 COM Express CPU module
> AC5X RD COM Express Type 7 carrier board.
> AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module.
>
> Signed-off-by: Elad Nachman <enachman@marvell.com>
> ---
> .../bindings/arm/marvell/armada-7k-8k.yaml | 15 +++++++++++++++
> .../bindings/arm/marvell/marvell,ac5.yaml | 14 ++++++++++++++
> 2 files changed, 29 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> index 52d78521e412..7e0ac5110eef 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> @@ -60,4 +60,19 @@ properties:
> - const: marvell,armada-ap807-quad
> - const: marvell,armada-ap807
>
> + - description: Armada CN9130 SoC without external CP as COM Express CPU module
> + items:
> + - const: marvell,cn9130-cpu-module
How CPU module can be used alone?
> + - const: marvell,cn9130
> + - const: marvell,armada-ap807-quad
> + - const: marvell,armada-ap807
> +
> + - description: Armada CN9131 SoC with one external CP as COM Express CPU module
> + items:
> + - const: marvell,cn9131-cpu-module
> + - const: marvell,cn9131
> + - const: marvell,cn9130
> + - const: marvell,armada-ap807-quad
> + - const: marvell,armada-ap807
> +
> additionalProperties: true
> diff --git a/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml b/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml
> index 8960fb8b2b2f..734e1716a3e9 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml
> @@ -27,6 +27,20 @@ properties:
> - const: marvell,ac5x
> - const: marvell,ac5
>
> + - description: Alleycat5X (98DX35xx) Reference Design as COM Express Carrier
> + items:
> + - enum:
> + - marvell,rd-ac5x-carrier
> + - const: marvell,ac5x
> +
> + - description:
> + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus
> + Armada CN9131 COM Express CPU module
> + items:
> + - enum:
> + - marvell,rd-ac5x-carrier-with-cn9131
> + - const: marvell,ac5x
You never responded to me concerns, so I still do not know what's this.
This claims it has CN9131, but compatibles are missing.
Can anyone help us understand why AC5 has CN9130 but these are in
different files?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 3/3] arm64: dts: cn913x: add device trees for COM Express boards
[not found] ` <20231029174814.559583-4-enachman@marvell.com>
2023-10-29 18:03 ` [PATCH v4 3/3] arm64: dts: cn913x: add device trees for " Andrew Lunn
@ 2023-10-30 13:32 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-30 13:32 UTC (permalink / raw)
To: Elad Nachman, robh+dt, krzysztof.kozlowski+dt, conor+dt, andrew,
gregory.clement, sebastian.hesselbarth, pali, mrkiko.rs,
chris.packham, devicetree, linux-kernel, linux-arm-kernel
Cc: cyuval
On 29/10/2023 18:48, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
>
> Add support for CN9130 and CN9131 COM Express Type 7 CPU
> module boards by Marvell.
> Define these COM Express CPU modules as dtsi and
> provide a dtsi file for a carrier board (Marvell AC5X RD
> COM Express type 7 carrier board).
> This Carrier board only utilizes the PCIe link, hence no
> special device / driver support is provided by this dtsi file.
> Finally, provide a dts file for the com express carrier and
> CPU module combination.
>
> These COM Express boards differ from the existing CN913x DB
> boards by the type of ethernet connection (RGMII),
> the type of voltage regulators (not i2c expander based)
> and the USB phy (not UTMI based).
> Note - PHY + RGMII connector is OOB on CPU module.
> CN9131 COM Express board is basically CN9130 COM Express board
> with an additional CP115 I/O co-processor, which in this case
> provides an additional USB host controller on the board.
>
> Signed-off-by: Elad Nachman <enachman@marvell.com>
> ---
> arch/arm64/boot/dts/marvell/Makefile | 1 +
> .../marvell/ac5x-rd-carrier-with-cn9131.dts | 20 ++++
> .../boot/dts/marvell/ac5x-rd-carrier.dtsi | 15 +++
> .../dts/marvell/cn9130-db-comexpress.dtsi | 101 ++++++++++++++++
> .../dts/marvell/cn9131-db-comexpress.dtsi | 113 ++++++++++++++++++
> 5 files changed, 250 insertions(+)
> create mode 100644 arch/arm64/boot/dts/marvell/ac5x-rd-carrier-with-cn9131.dts
> create mode 100644 arch/arm64/boot/dts/marvell/ac5x-rd-carrier.dtsi
> create mode 100644 arch/arm64/boot/dts/marvell/cn9130-db-comexpress.dtsi
> create mode 100644 arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi
>
> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
> index 79ac09b58a89..88c0f357a778 100644
> --- a/arch/arm64/boot/dts/marvell/Makefile
> +++ b/arch/arm64/boot/dts/marvell/Makefile
> @@ -26,4 +26,5 @@ dtb-$(CONFIG_ARCH_MVEBU) += cn9132-db.dtb
> dtb-$(CONFIG_ARCH_MVEBU) += cn9132-db-B.dtb
> dtb-$(CONFIG_ARCH_MVEBU) += cn9130-crb-A.dtb
> dtb-$(CONFIG_ARCH_MVEBU) += cn9130-crb-B.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += ac5x-rd-carrier-with-cn9131.dtb
> dtb-$(CONFIG_ARCH_MVEBU) += ac5-98dx35xx-rd.dtb
> diff --git a/arch/arm64/boot/dts/marvell/ac5x-rd-carrier-with-cn9131.dts b/arch/arm64/boot/dts/marvell/ac5x-rd-carrier-with-cn9131.dts
> new file mode 100644
> index 000000000000..9ca2725184e2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/marvell/ac5x-rd-carrier-with-cn9131.dts
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2023 Marvell International Ltd.
> + *
> + * Device tree for the AC5X RD Type 7 Com Express carrier board,
> + * Utilizing the CN913x COM Express CPU module board.
> + * This specific board only maintains a PCIe link with the CPU CPU module
> + * module, which does not require any special DTS definitions.
> + */
> +
> +#include "cn9131-db-comexpress.dtsi"
> +#include "ac5x-rd-carrier.dtsi"
> +
> +/ {
> + model = "Marvell Armada AC5X RD COM EXPRESS type 7 carrier board with CN9131 CPU module";
> + compatible = "marvell,rd-ac5x-carrier-with-cn9131", "marvell,rd-ac5x-carrier",
> + "marvell,cn9131", "marvell,cn9130",
> + "marvell,armada-ap807-quad", "marvell,armada-ap807";
So you clearly did not test what you wrote.
This is v4, so at this point testing should be obvious. You must test
your bindings and you must test your DTS against bindings.
Successful test means: ZERO warnings.
Standard disclaimer:
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-30 13:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231029174814.559583-1-enachman@marvell.com>
[not found] ` <20231029174814.559583-2-enachman@marvell.com>
2023-10-29 17:52 ` [PATCH v4 1/3] MAINTAINERS: add ac5 to list of maintained Marvell dts files Andrew Lunn
[not found] ` <20231029174814.559583-3-enachman@marvell.com>
2023-10-30 12:48 ` [PATCH v4 2/3] dt-bindings: arm64: dts: add dt-bindings for Marvell COM Express boards Rob Herring
2023-10-30 13:22 ` Rob Herring
2023-10-30 13:31 ` Krzysztof Kozlowski
[not found] ` <20231029174814.559583-4-enachman@marvell.com>
2023-10-29 18:03 ` [PATCH v4 3/3] arm64: dts: cn913x: add device trees for " Andrew Lunn
2023-10-30 13:32 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).