From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5391BC04FF8 for ; Tue, 23 Apr 2024 08:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kWpNl7X/R1lx0j7kxwqRUPuRUqXXmtxfjlWMexiLcGY=; b=xkmoRFL4HkSiBN 2oeAlt/MGtlti/Yfd4LpArZ/cJtMaejtbNitSVSFOsixPrfbjp0rJt9Axdzq2YNiACtof8UKb55T7 qiY3LSD7+vLietoMc3OwwKKGfJeFDn5Osy7l5ex5Fl2KZ+qz+8Xuo50nkWKFIPLHkjPy3MRAGFTha XN+FKoAz3MI7fTXvpDXMQLPUC+I9fw/7O1AhXi7oIMtJLYKZYDMZ5kS0kJogjMX+VBKMPIeIk9Vqf fI/eDuXK1V3NCBg2SW3YfmBRdLc+WILQnKKJnOsrXXtlPE10kA+GSwJ5crRYRNT8e+pUK5HhOKste xMBfR6uueGqYoQ5Sis1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBSq-0000000GRoM-0bCM; Tue, 23 Apr 2024 08:25:20 +0000 Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBSl-0000000GRla-21jT for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 08:25:17 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 2AECB1140118; Tue, 23 Apr 2024 04:25:12 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 23 Apr 2024 04:25:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1713860712; x=1713947112; bh=YOQwmEQ3OK YOltcTnTIuJveOsHYPT9RcReX5fldj/AU=; b=moPIfHvqDIJn/A5L0IBZa3RAmk RvXImpm5Owevp859N1gWIZhINTLqHtOm2qFTCU7mlpkA4Lv7+np85vHUOj2+Y5rY rXYEvWFRFP+bS9rT9YJrhrA0u4MVdt0HZp8YlH1pMXKjnhU244TB+kqFuWxpp+H9 9zwjivqwZwsxIxN+mA5dkzkMtMqqMhUflmtP0LbhcVNm4jBNMmPe9L/Hb1MBApSs r+12OZfFfqZPntcC7+W1g4zJXX1/rJ+oPmiKT75PhmBiSNYiyQjZzMvZEdE7jr7K N+VhEQsekgADTkfGmMFLEcgM4rgS8cji7wF/nwhexaYQBBt6c9Pn8vUOzBvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1713860712; x=1713947112; bh=YOQwmEQ3OKYOltcTnTIuJveOsHYP T9RcReX5fldj/AU=; b=X1b0WsSlIbZtsp0Prpz/nv+JW5g7EoUTVI6dtlKU+z1J xVkLTKipfeNEHJNUdAqI1+xGoB3VoRy4EolwkdGPaZDuua1i2FayB8vG/nqjhb4Z 2OPvt9/uMSp/bXL2gZftEb2mvg/U2aIbrj0TVErzR6Z0/7Pd3VTfQMcmtv1Hp8w/ wYiHWzCgcB2ih/DqFwvEHENLR879mvNAJDx+/yJoOuMrukCkw8qo4JLP1G2WTw8K LLnjE22L1hJyoHypdO/LjkXP4my/jmAtkwID/9osxhisGxNzQQh8TL5oZF5qeUVj AmaqP2zSPv9I7GAWjoRa7mN188Zd6Hd9gCuNR/ZB2g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeluddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 71B22B6008D; Tue, 23 Apr 2024 04:25:11 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-386-g4cb8e397f9-fm-20240415.001-g4cb8e397 MIME-Version: 1.0 Message-Id: In-Reply-To: <20240422224849.2238222-1-maz@kernel.org> References: <20240422224849.2238222-1-maz@kernel.org> Date: Tue, 23 Apr 2024 10:24:49 +0200 From: "Arnd Bergmann" To: "Marc Zyngier" , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Cc: "James Morse" , "Suzuki K Poulose" , "Oliver Upton" , "Zenghui Yu" , "Mark Rutland" , "Joey Gouly" , "Will Deacon" , "Naresh Kamboju" , "Linaro Kernel Functional Testing" Subject: Re: [PATCH] KVM: arm64: nv: Work around lack of pauth support in old toolchains X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_012515_899868_79D3150F X-CRM114-Status: GOOD ( 15.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 23, 2024, at 00:48, Marc Zyngier wrote: > We still support GCC 8.x, and it appears that this toolchain > does not understand "pauth" as a valid architectural extension. > After all, it's only been 8 years since ARMv8.3 was released... Just to clarify: I'm fairly sure that all supported toolchains support ARMv8.3 and PACGA, the problem with ".arch_extension pauth\n" seems to be that it was retroactively made an optional feature for earlier architecture versions a few years after ARMv8.3, so most binutils versions we support understand pacga as an armv8.3 feature but reject the pauth name for the extension. > This results in the NV ERETAx code breaking the build, as it relies > on this extention to make use of the PACGA instruction. > > Work around it by hand-assembling the instruction using a mind-bending > trick lifted from an old patch by Will. Magic. > > Fixes: e09faab353a6 ("KVM: arm64: nv: Add emulation for ERETAx instructions") > Reported-by: Linaro Kernel Functional Testing > Signed-off-by: Marc Zyngier I usually try to enclose these in a version check like "#if CONFIG_AS_VERSION >= 22800" so we can be sure we clean them up whenever the minimum version changes, but I assume you'll remember this one. Acked-by: Arnd Bergmann _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel