From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sky Huang <SkyLake.Huang@mediatek.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Daniel Golle <daniel@makrotopia.org>,
Qingfang Deng <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: Steven Liu <Steven.Liu@mediatek.com>,
"paul-pl.chen" <paul-pl.chen@mediatek.com>,
Fei Shao <fshao@chromium.org>
Subject: Re: [PATCH net-next 1/3] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib
Date: Thu, 16 Jan 2025 13:55:00 +0100 [thread overview]
Message-ID: <fa77f4e0-aa5c-4ac6-8223-29b20374dd01@kernel.org> (raw)
In-Reply-To: <20250116012159.3816135-2-SkyLake.Huang@mediatek.com>
On 16/01/2025 02:21, Sky Huang wrote:
> From: "SkyLake.Huang" <skylake.huang@mediatek.com>
>
> This patch adds TR(token ring) manipulations and adds correct
> macro names for those magic numbers. TR is a way to access
> proprietary registers on page 52b5. Use these helper functions
> so we can see which fields we're going to modify/set/clear.
>
> This patch doesn't really change registers' settings but just
> enhances readability and maintainability.
>
> Signed-off-by: SkyLake.Huang <skylake.huang@mediatek.com>
Few days ago I complained the Mediatek too frequent uses login as full
name. Several different Mediatek contributors repeat the same mistake,
so I asked to fix this internally with some sort of
guideline/checklist/internal reviews.
Other patches here look OK, so there is some progress, but not complete
- please fix here as well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-16 12:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 1:21 [PATCH net-next 0/3] net: phy: mediatek: Add token-ring ops Sky Huang
2025-01-16 1:21 ` [PATCH net-next 1/3] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib Sky Huang
2025-01-16 12:55 ` Krzysztof Kozlowski [this message]
2025-01-19 17:12 ` Andrew Lunn
2025-02-13 7:39 ` SkyLake Huang (黃啟澤)
2025-02-13 13:29 ` Andrew Lunn
2025-02-13 13:43 ` Daniel Golle
2025-02-13 15:34 ` Andrew Lunn
2025-02-14 3:35 ` SkyLake Huang (黃啟澤)
2025-02-16 16:39 ` Andrew Lunn
2025-01-16 1:21 ` [PATCH net-next 2/3] net: phy: mediatek: Move some macros to phy-lib for later use Sky Huang
2025-01-19 17:20 ` Andrew Lunn
2025-01-16 1:21 ` [PATCH net-next 3/3] net: phy: mediatek: add driver for built-in 2.5G ethernet PHY on MT7988 Sky Huang
2025-01-16 1:58 ` Daniel Golle
2025-01-19 17:35 ` Andrew Lunn
2025-02-14 13:13 ` SkyLake Huang (黃啟澤)
2025-01-16 12:45 ` Krzysztof Kozlowski
2025-02-14 13:23 ` SkyLake Huang (黃啟澤)
2025-02-14 15:31 ` Krzysztof Kozlowski
2025-01-16 12:51 ` Krzysztof Kozlowski
2025-01-19 17:31 ` Andrew Lunn
2025-02-14 13:25 ` SkyLake Huang (黃啟澤)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa77f4e0-aa5c-4ac6-8223-29b20374dd01@kernel.org \
--to=krzk@kernel.org \
--cc=SkyLake.Huang@mediatek.com \
--cc=Steven.Liu@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=fshao@chromium.org \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul-pl.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).