From: Dev Jain <dev.jain@arm.com>
To: Mark Brown <broonie@kernel.org>, Will Deacon <will@kernel.org>
Cc: shuah@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, Catalin.Marinas@arm.com,
ryan.roberts@arm.com, Anshuman.Khandual@arm.com,
aneesh.kumar@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/arm64: Fix build warnings for abi
Date: Thu, 29 Aug 2024 11:58:22 +0530 [thread overview]
Message-ID: <fa7fed62-8049-4e85-8568-f2f1c3a98c02@arm.com> (raw)
In-Reply-To: <c808efdf-fc78-40c3-90bf-948f65a6d133@sirena.org.uk>
On 8/28/24 16:31, Mark Brown wrote:
> On Tue, Aug 27, 2024 at 01:33:47PM +0100, Will Deacon wrote:
>> On Tue, Aug 27, 2024 at 10:48:51AM +0530, Dev Jain wrote:
>>> A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly
>>> introduced ksft_exit_fail_perror(). Also, uint64_t corresponds to
>>> unsigned 64-bit integer, so use %lx instead of %llx.
>> What's wrong with using %llx for a uint64_t? I think that part of the
>> code is fine as-is.
> IIRC there's some printf format specifiers specific to uint64_t which
> are probably a better choice here.
Well, then I will just send a patch fixing only the %s thing; I don't
want to get lost into format specifiers right now :)
next prev parent reply other threads:[~2024-08-29 6:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 5:18 [PATCH] selftests/arm64: Fix build warnings for abi Dev Jain
2024-08-27 12:33 ` Will Deacon
2024-08-28 3:49 ` Dev Jain
2024-08-28 11:01 ` Mark Brown
2024-08-29 6:28 ` Dev Jain [this message]
2024-08-28 10:40 ` Mark Brown
2024-08-29 6:25 ` Dev Jain
2024-08-29 11:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa7fed62-8049-4e85-8568-f2f1c3a98c02@arm.com \
--to=dev.jain@arm.com \
--cc=Anshuman.Khandual@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=aneesh.kumar@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).