From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BA3DC77B7F for ; Thu, 29 Aug 2024 06:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u1bZjXEfd4QeR8zYa2+PjCmELtmuLXYSV2CUdufcxlU=; b=k+1CiHtW8EkbS82kznS/3EUXv2 uQdQqNcoGqsGJ2YCjIhOyb0+u4MSsKlbZ5zWn+0N88I+ZWq6K44zj948mNWxVFgwekBa4nSmme8Jj tU9f0KV8elqPxTwb7XIPOlpnqJ8DFscGXmARJzGNTTFQIB8hFuapnnkTY6MOEK4P0QbdX2z2ZL9fz iU03L59IwpV0RZiSELFSijYw4I4IVlXSfA3ALgwPt3KfdbWZzOiPtBxT6rLjRJNqO5/KPc6RhLEni j2t0aLjQUFe5p36vG30C8lo5H+sRI36bvqrNwq1xFxnZ+d3ZqxJuHdhJtARCUwKtTtAT7t8FQE4+5 AoC5V1yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjYnI-00000000oD8-14SL; Thu, 29 Aug 2024 06:38:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjYdy-00000000m70-1XWb for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 06:28:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 59FDADA7; Wed, 28 Aug 2024 23:28:55 -0700 (PDT) Received: from [10.162.41.23] (e116581.arm.com [10.162.41.23]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E40493F66E; Wed, 28 Aug 2024 23:28:25 -0700 (PDT) Message-ID: Date: Thu, 29 Aug 2024 11:58:22 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/arm64: Fix build warnings for abi To: Mark Brown , Will Deacon Cc: shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, Catalin.Marinas@arm.com, ryan.roberts@arm.com, Anshuman.Khandual@arm.com, aneesh.kumar@kernel.org, linux-kernel@vger.kernel.org References: <20240827051851.3738533-1-dev.jain@arm.com> <20240827123347.GC4679@willie-the-truck> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_232830_495876_073609B8 X-CRM114-Status: GOOD ( 10.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/28/24 16:31, Mark Brown wrote: > On Tue, Aug 27, 2024 at 01:33:47PM +0100, Will Deacon wrote: >> On Tue, Aug 27, 2024 at 10:48:51AM +0530, Dev Jain wrote: >>> A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly >>> introduced ksft_exit_fail_perror(). Also, uint64_t corresponds to >>> unsigned 64-bit integer, so use %lx instead of %llx. >> What's wrong with using %llx for a uint64_t? I think that part of the >> code is fine as-is. > IIRC there's some printf format specifiers specific to uint64_t which > are probably a better choice here. Well, then I will just send a patch fixing only the %s thing; I don't want to get lost into format specifiers right now :)