From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB7EC433DF for ; Thu, 4 Jun 2020 15:26:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10053207D8 for ; Thu, 4 Jun 2020 15:26:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f3JIZRI1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HNPHDr5S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10053207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4OiIUeUiQr0hT2VehjK+UshERcPQYCqDoFlCXmL0bAo=; b=f3JIZRI1hJMoGHN6CNZPGwVx0 eqPMMER6g7AGSzfDtbM5pHTpd0gEkEKtuW06O4pJeeKW9fzd74FMG+er87LzFRncpSKNJDSIFcMUC Jcw78SQCVEgXtDrCWFLLqZvzBbR5v6Il/qtC5mmFKnLl8wRrNRXlUc1fmxy9IlO49A8zmklXHoQQ5 o464T9zTFO7NjgWEzTYA9bTHqkwf1TJZFEkCFV27k907yRXxIENAIGv95C3DKNQH8kKLOziEFwnyl 3BuLbG20jGgmXtmNyhTYg/wexW97gSXh/tjWZm5GWToV/G++B+hpS0g1mTlfccyVoe0DZiNfZS0at TImuvT5/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgrkm-0004xm-Cm; Thu, 04 Jun 2020 15:26:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgrkd-0004x4-GP for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2020 15:25:59 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 037392063A; Thu, 4 Jun 2020 15:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591284351; bh=3NdFHDaY9HllPwJPcfCKGbdFqO+3yifo5hEKT887Uy4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HNPHDr5SXEA1XDXd8X3W9d7+FSC7XNV7kbTcsToB4pwfruti+OYCKAcds7BVWdcz4 /W7jTcdotRFstbDm6q4ARPCosrTlU/fm4NRspRfvPFlfPmbJMctd/wd7ReKcOJGwJo CXzZr/u6FU5wt7nyGJZE4UNvxqwhn9neu3R86bpM= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jgrkb-000HeM-HZ; Thu, 04 Jun 2020 16:25:49 +0100 MIME-Version: 1.0 Date: Thu, 04 Jun 2020 16:25:49 +0100 From: Marc Zyngier To: Will Deacon Subject: Re: [PATCH] arm64: set TEXT_OFFSET to 0x0 in preparation for removing it entirely In-Reply-To: <20200604150122.GA3650@willie-the-truck> References: <20200415082922.32709-1-ardb@kernel.org> <158808120907.217905.4632288691847383619.b4-ty@kernel.org> <20200604154141.4983aeaa@why> <20200604150122.GA3650@willie-the-truck> User-Agent: Roundcube Webmail/1.4.4 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: will@kernel.org, ardb@kernel.org, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, catalin.marinas@arm.com, james.morse@arm.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_082557_678953_0DC66ED5 X-CRM114-Status: GOOD ( 17.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, james.morse@arm.com, Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-06-04 16:01, Will Deacon wrote: > On Thu, Jun 04, 2020 at 03:41:41PM +0100, Marc Zyngier wrote: >> Hi all, >> >> On Tue, 28 Apr 2020 15:49:35 +0100 >> Will Deacon wrote: >> >> > On Wed, 15 Apr 2020 10:29:22 +0200, Ard Biesheuvel wrote: >> > > TEXT_OFFSET on arm64 is a historical artifact from the early days of >> > > the arm64 port where the boot protocol was basically 'copy this image >> > > to the base of memory + 512k', giving us 512 KB of guaranteed BSS space >> > > to put the swapper page tables. When the arm64 port was merged for >> > > v3.10, the Image header already carried the actual value of TEXT_OFFSET, >> > > to allow the bootloader to discover it dynamically rather than hardcode >> > > it to 512 KB. >> > > >> > > [...] >> > >> > Applied to arm64 (for-next/misc), thanks! >> > >> > [1/1] arm64: set TEXT_OFFSET to 0x0 in preparation for removing it entirely >> > https://git.kernel.org/arm64/c/cfa7ede20f13 >> >> This breaks a guest kernel booted with kvmtool (tested on my d05). >> Reverting it on top of 6929f71e46bd makes it work again. I haven't yet >> investigated what is happening here though. > > Weird, that's a combination I test, just not on d05. Are you using > defconfig? Can you share your full kvmtool invication please? Ah, good point. Not defconfig, but one that allows me to run the same kernel on my whole zoo[1]. As for the kvmtool invocation, it is pretty basic: lkvm run -m 512 -c 4 -p earlycon -k arch/arm64/boot/Image Thanks, M. [1] http://www.loen.fr/tmp/Config-arm64-full -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel