From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21926C433F5 for ; Sun, 15 May 2022 09:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l46LTWwfWqzb2IaAGiOcysBhbZl5SdhWI/tQ/EKGg/s=; b=QMa35d7yBGZTxl 8dt6wXW3e/ehcEP6EMF77B2HfK0qfSV4HevjA+w2TKQcNXYJb0Jr4dZoDgHtBg32K47vZmeIJThJU S+6ssZyDtfE6dJTbHeFfP8GuaU6DasJXPGqbbKMppOj57gLxMBYP/K8xWP0TBmpRVS6UNjfqTzEkO As6/Sauu4bcjZ5ifswPWxhAjPqKKff/R1Vs9EDqwyK/OzdUfZDfVneT9VXoOEPrGnwR5fpTr+u0Ad MeB8SvbYYkwiXdjClYW7xO5+PGPBjj2lTsuoM86ZCWDh0QdN9vMSMP6tbius5orTvgN1cHqPEcOR7 Y7ntggktMOivfUSrLMwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqAtr-003eZC-V4; Sun, 15 May 2022 09:50:56 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqAtn-003eXW-7n for linux-arm-kernel@lists.infradead.org; Sun, 15 May 2022 09:50:53 +0000 Received: by mail-lf1-x12b.google.com with SMTP id p26so21245952lfh.10 for ; Sun, 15 May 2022 02:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=shicjTKBtrtuDcaN2NsbxhwfQnbe4P6u6jZjTty+jvI=; b=P4NpdP8gMX4y3C6YTYYB9Nre+Yy7M1p6asm/4EkODj179NE84yTYgfBRBKmG8Z7SA0 +ua4WeNEU0y+fUYbcz1fsVq6rVZkM9D+ElBVUTpacF2Rgfh2f5pXnwHtUQSlb3EVGCKh 7UthSL65O/YTpmLBRbVWkLaIb118nbb/DK9CESGDMIL1Kc5H3hUtl/54+KL6dHmx2oiI ZZhDJRQDk3A0HxN1FemJc8XmsRjhBSLMWWuV4zvea5C4vtaNOrfwhG5mPykKNCW2y44x OcEOqIUkJHeWiDivadQf0ROtZnh6CsTtQ105UIGXWmQyk37RZiIIyzpjYrgEODD/9Ox2 uMiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=shicjTKBtrtuDcaN2NsbxhwfQnbe4P6u6jZjTty+jvI=; b=lXdOicV+upFa+dcTg43MQF+uNOrryDxnRFl1jAfjpv2sY4eENWOV5pufXqdlFxl2OE skXX7nhQP8xuBegb3gZfacN3ZNFDHesmM87T4uBPAz0TJ0rPfzr7FFIZiPQZRlYJPRz5 XXLZUuzxWJ7MCF8zFB1gOXP0Pb8KpY9eviRO9MSOPeQQB3gKbsaSFjLOG+FPkxiG9UDT /G9gdCfSOLCIbfF+8TDT/XCHiffdOGFJ6lEyVU4D3Snxi4ionGWjP1wpXYuuMD3XLCfT yGci3MopN1+eFdLuy2pyF6Ni5iqLbT4dROeaoJf5O4Zw1pWRA/DkjID4K17wKh/d0g7r jTPw== X-Gm-Message-State: AOAM5337y0JkxtkHs3FPgnQW/aV5yxHYvZ5cqs5S65PjcH5c59tLgD9u vWQ50gQTdp00Vw9nv1REVhYmug== X-Google-Smtp-Source: ABdhPJwOLry/chcSZ6wRRTHJAPGCWa4sZSHfMWq3GnThJ/DjNvArBBCY0ab9VZbRJdVQtzEcryDExA== X-Received: by 2002:a05:6512:3993:b0:473:1953:59 with SMTP id j19-20020a056512399300b0047319530059mr9067511lfu.269.1652608249643; Sun, 15 May 2022 02:50:49 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id d21-20020a2e96d5000000b0024f3d1daec7sm1129326ljj.79.2022.05.15.02.50.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 May 2022 02:50:49 -0700 (PDT) Message-ID: Date: Sun, 15 May 2022 11:50:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCHv2 2/6] thermal: exynos: Reorder the gpu clock initialization for exynos5420 SoC Content-Language: en-US To: Anand Moon , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220515064126.1424-1-linux.amoon@gmail.com> <20220515064126.1424-3-linux.amoon@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220515064126.1424-3-linux.amoon@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220515_025051_328430_19D3ED7F X-CRM114-Status: UNSURE ( 7.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/05/2022 08:41, Anand Moon wrote: > Reorder the tmu_gpu clock initialization for exynos5422 SoC. Some more thoughts: where is the GPU here? This is a TMU driver... In subject you also describe GPU. My comments about unusual code order from [1] were not answered. https://lore.kernel.org/lkml/CANAwSgS=08fVsqn95WHzSF71WTTyD2-=K2C6-BEz0tY0t6A1-g@mail.gmail.com/T/#m3edd1fa357eb3e921e51eb09e2e32d68496332eb Please respond/address to all comments before resending. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel