From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15BC7C3DA59 for ; Mon, 22 Jul 2024 14:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f63c3R5AaO3G4m+kG7QYQwof/dHA1YfJmkPVkwVDp3s=; b=jcYBg28QS0KJNGIKj96NHpYEoV ix+AcNVwDWDWMwZs1dyisCMpLtqIPBrcIvYgUksrpY5rK323+j8XBJlPnPDW+OaN43FbB/CLItwP3 ZfBZP4L1pOYTy+VfuTvI6Cu5UtnSH1exLmJ1as15t4tHwOBNUF/KpLmrLKoN0nBJFeZAPpQpwsLnH w10sgi6QsABUshOgkQ+bX5rV3tOzafoWyETpDJXd/uG3sJSXGYh1YYeokKkh49uOh0gfo42Gp3KLH M5CP2Ou9ROQXGO+YhD1WXtSaMeDMqzy+F1sO0H/ZPCkmpAtXjlaINluGsmkJ0DDFRWvo9QR7ncwDx raFC8ZQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVuQU-00000009qQH-3IXK; Mon, 22 Jul 2024 14:54:10 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVuQ7-00000009qJq-0yk6; Mon, 22 Jul 2024 14:53:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1721660022; bh=ReJ6PIw4rNKKvjtKFWY7U3j9FDNjTAGJ375FqNKVD1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QE6SvFrZXY9RlL7OIqqF0pMEBZndfkhJcS49Wvl3dyWdMPjVDqoWFPTnE6C452FEP ZRe+0qzLzTJKR1XuZbZbiXzunsc/SiyBL0AsygI5DMztO2nxLHtQji0JgtG6juH/n7 yhY4feI+mVqEZdxMMc/GDrUX8j4qLpXn9xy2oGY8sPqU0HiaOs6N18Mk6yqt138M9A LCnR7UacjOIcQRwXsaHpLt7Y+f/6zmErQCJhnp09ypYfFQuRbYICX+UGiSP217mep/ zSSoOQFcV5WwAcEWihxAo0qaqwKur74BpWYPB5W49T9aFc36+KT+mpw0BUz7YblgUE L2x6ncpUeYHjQ== Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 6B6783780523; Mon, 22 Jul 2024 14:53:40 +0000 (UTC) Date: Mon, 22 Jul 2024 10:53:38 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: AngeloGioacchino Del Regno Cc: Macpaul Lin , Chunfeng Yun , Matthias Brugger , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Chen-Yu Tsai , Bear Wang , Pablo Sun Subject: Re: Probe failure of usb controller @11290000 on MT8195 after next-20231221 Message-ID: References: <9fce9838-ef87-4d1b-b3df-63e1ddb0ec51@notapiano> <064935d8-fbda-4eda-b013-8c8fc63b561c@collabora.com> <375b2345-657a-4b8f-b5e3-dc16784ffde9@notapiano> <2dba1638-f155-463b-8f87-421101b8f4f2@collabora.com> <521df3a8-5bc2-4e81-a819-02b755c88d3a@notapiano> <9f12777b-b8b6-4d34-b336-7637e551b552@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9f12777b-b8b6-4d34-b336-7637e551b552@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_075347_441438_0051082F X-CRM114-Status: GOOD ( 12.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 15, 2024 at 02:04:54PM +0200, AngeloGioacchino Del Regno wrote: [..] > Besides, I also noticed that the CLK_APMIXED_PLL_SSUSB26M is missing from u2port1 > and the reason why it works is because other u3phy0 should be enabling that before > u3phy1 inits and/or before the USB controller using U3P1 tries to initialize, so > while you're at it ... if you can please also add that to the u3p1, I appreciate. > > u2port1: usb-phy@0 { > reg = <0x0 0x700>; > clocks = <&apmixedsys CLK_APMIXED_PLL_SSUSB26M>, > <&topckgen CLK_TOP_SSUSB_PHY_P1_REF>; > clock-names = "ref", "da_ref"; > #phy-cells = <1>; > }; I'm not familiar with the clock topology on MT8195, but I noticed the CLK_APMIXED_PLL_SSUSB26M clock is currently only present in the USB3 phy nodes: u3port1 and u3port0. You're suggesting to add it to a USB2 phy node here. Is it needed by all USB2 phy nodes (u2port0, u2port1, u2port2, u2port3) then? Thanks, Nícolas