From: "Adivi, Sai Sree Kartheek" <s-adivi@ti.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
<dmaengine@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <praneeth@ti.com>,
<vigneshr@ti.com>, <u-kumar1@ti.com>, <a-chavda@ti.com>,
<p-mantena@ti.com>
Subject: Re: [PATCH v2 03/17] dmaengine: ti: k3-udma: move static inline helper functions to header file
Date: Wed, 18 Jun 2025 13:34:53 +0530 [thread overview]
Message-ID: <fabe8565-cd27-4117-ba64-23022f1942ae@ti.com> (raw)
In-Reply-To: <acc1217d-50ce-4851-829d-38294b0a4d81@ti.com>
Hi Siddharth,
On 6/12/2025 4:35 PM, Siddharth Vadapalli wrote:
> On Thu, Jun 12, 2025 at 12:45:07PM +0530, Sai Sree Kartheek Adivi wrote:
>> Move static inline helper functions in k3-udma.c to k3-udma.h header
>> file for better separation and re-use.
>>
>> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
>> ---
>> drivers/dma/ti/k3-udma.c | 108 --------------------------------------
>> drivers/dma/ti/k3-udma.h | 109 +++++++++++++++++++++++++++++++++++++++
>
> Since this patch and the previous two patches seem to have the same
> objective of moving contents from "k3-udma.c" to "k3-udma.h" for the
> purpose of re-use, could they be squashed?
I split them up to make the changes easier to review, bisect or revert
if needed. They're logically distinct changes even if the overall goal
is similar.
If there's a strong preference to squash them, I can do that but I'd
prefer keeping them separate.
>
> Regards,
> Siddharth.
next prev parent reply other threads:[~2025-06-18 8:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 7:15 [PATCH v2 00/17] dmaengine: ti: Add support for BCDMA v2 and PKTDMA v2 Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 01/17] dmaengine: ti: k3-udma: move macros to header file Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 02/17] dmaengine: ti: k3-udma: move structs and enums " Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 03/17] dmaengine: ti: k3-udma: move static inline helper functions " Sai Sree Kartheek Adivi
2025-06-12 11:05 ` Siddharth Vadapalli
2025-06-18 8:04 ` Adivi, Sai Sree Kartheek [this message]
2025-06-12 7:15 ` [PATCH v2 04/17] dmaengine: ti: k3-udma: move descriptor management to k3-udma-common.c Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 05/17] dmaengine: ti: k3-udma: move ring management functions " Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 06/17] dmaengine: ti: k3-udma: Add variant-specific function pointers to udma_dev Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 07/17] dmaengine: ti: k3-udma: move udma utility functions to k3-udma-common.c Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 08/17] dmaengine: ti: k3-udma: move resource management " Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 09/17] dmaengine: ti: k3-udma: refactor resource setup functions Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 10/17] dmaengine: ti: k3-udma: move inclusion of k3-udma-private.c to k3-udma-common.c Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 11/17] drivers: soc: ti: k3-ringacc: handle absence of tisci Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 12/17] dt-bindings: dma: ti: Add document for K3 BCDMA V2 Sai Sree Kartheek Adivi
2025-06-12 8:55 ` Rob Herring (Arm)
2025-06-12 12:27 ` Rob Herring
2025-06-12 7:15 ` [PATCH v2 13/17] dt-bindings: dma: ti: Add document for K3 PKTDMA V2 Sai Sree Kartheek Adivi
2025-06-12 8:55 ` Rob Herring (Arm)
2025-06-12 7:15 ` [PATCH v2 14/17] dmaengine: ti: k3-psil-am62l: Add AM62Lx PSIL and PDMA data Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 15/17] dmaengine: ti: k3-udma-v2: New driver for K3 BCDMA_V2 Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 16/17] dmaengine: ti: k3-udma-v2: Add support for PKTDMA V2 Sai Sree Kartheek Adivi
2025-06-12 7:15 ` [PATCH v2 17/17] dmaengine: ti: k3-udma-v2: Update glue layer to support " Sai Sree Kartheek Adivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabe8565-cd27-4117-ba64-23022f1942ae@ti.com \
--to=s-adivi@ti.com \
--cc=a-chavda@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=peter.ujfalusi@gmail.com \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=ssantosh@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox