[PATCH] smccc/kvm_guest: Remove the accidental semicolon

[PATCH] smccc/kvm_guest: Remove the accidental semicolon

[Shameer Kolothum]

Fixes cocci reported warning:Unneeded semicolon

Fixes: 86edf6bdcf05 ("smccc/kvm_guest: Enable errata based on implementation CPUs")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504020941.VEeL6nVJ-lkp@intel.com/
Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
---
 drivers/firmware/smccc/kvm_guest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/smccc/kvm_guest.c b/drivers/firmware/smccc/kvm_guest.c
index 5767aed25cdc..ffe9f3c013df 100644
--- a/drivers/firmware/smccc/kvm_guest.c
+++ b/drivers/firmware/smccc/kvm_guest.c
@@ -103,7 +103,7 @@ void  __init kvm_arm_target_impl_cpu_init(void)
 		target[i].midr = res.a1;
 		target[i].revidr = res.a2;
 		target[i].aidr = res.a3;
-	};
+	}
 
 	if (!cpu_errata_set_target_impl(max_cpus, target)) {
 		pr_warn("Failed to set target implementation CPUs\n");
-- 
2.47.0

Re: [PATCH] smccc/kvm_guest: Remove the accidental semicolon

[Sudeep Holla]

On Wed, Apr 02, 2025 at 02:44:01PM +0100, Shameer Kolothum wrote:
> Fixes cocci reported warning:Unneeded semicolon
> 

There was similar patch on the list [1] few days ago.

> Fixes: 86edf6bdcf05 ("smccc/kvm_guest: Enable errata based on implementation CPUs")

^^^ Is this really necessary as they get backported as well ?

Since, KVM maintainers are in cc-ed, let me know if you guys want to pick
this ? Else I can send it as part of my firmware (ffa/scmi) fixes.

-- 
Regards,
Sudeep

[1] https://lore.kernel.org/all/20250326040659.1190696-1-nichen@iscas.ac.cn

RE: [PATCH] smccc/kvm_guest: Remove the accidental semicolon

[Shameerali Kolothum Thodi]

> -----Original Message-----
> From: Sudeep Holla <sudeep.holla@arm.com>
> Sent: Wednesday, April 2, 2025 2:58 PM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
> Cc: kvmarm@lists.linux.dev; linux-arm-kernel@lists.infradead.org;
> oliver.upton@linux.dev; maz@kernel.org; mark.rutland@arm.com;
> lpieralisi@kernel.org; catalin.marinas@arm.com; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] smccc/kvm_guest: Remove the accidental semicolon
> 
> On Wed, Apr 02, 2025 at 02:44:01PM +0100, Shameer Kolothum wrote:
> > Fixes cocci reported warning:Unneeded semicolon
> >
> 
> There was similar patch on the list [1] few days ago.

Ah.. I missed that. Please take that.
> 
> > Fixes: 86edf6bdcf05 ("smccc/kvm_guest: Enable errata based on
> > implementation CPUs")
> 
> ^^^ Is this really necessary as they get backported as well ?

Actually I was of two minds on this. Not sure.

> 
> Since, KVM maintainers are in cc-ed, let me know if you guys want to pick
> this ? Else I can send it as part of my firmware (ffa/scmi) fixes.

Thanks,
Shameer

Re: [PATCH] smccc/kvm_guest: Remove the accidental semicolon

[Oliver Upton]

Hi Sudeep,

On Wed, Apr 02, 2025 at 02:58:06PM +0100, Sudeep Holla wrote:
> On Wed, Apr 02, 2025 at 02:44:01PM +0100, Shameer Kolothum wrote:
> > Fixes cocci reported warning:Unneeded semicolon
> > 
> 
> There was similar patch on the list [1] few days ago.
> 
> > Fixes: 86edf6bdcf05 ("smccc/kvm_guest: Enable errata based on implementation CPUs")
> 
> ^^^ Is this really necessary as they get backported as well ?

The blamed commit was introduced this release cycle so no concern about
backports.

> Since, KVM maintainers are in cc-ed, let me know if you guys want to pick
> this ? Else I can send it as part of my firmware (ffa/scmi) fixes.

I can grab the fix here in a moment, I've already got one queued up [*]
for the KVM guest driver anyway.

[*]: https://git.kernel.org/kvmarm/kvmarm/c/acfcaf90db1f

Thanks,
Oliver

Re: [PATCH] smccc/kvm_guest: Remove the accidental semicolon

[Sudeep Holla]

On Wed, Apr 02, 2025 at 09:43:40AM -0700, Oliver Upton wrote:
> Hi Sudeep,
> 
> On Wed, Apr 02, 2025 at 02:58:06PM +0100, Sudeep Holla wrote:
> > On Wed, Apr 02, 2025 at 02:44:01PM +0100, Shameer Kolothum wrote:
> > > Fixes cocci reported warning:Unneeded semicolon
> > > 
> > 
> > There was similar patch on the list [1] few days ago.
> > 
> > > Fixes: 86edf6bdcf05 ("smccc/kvm_guest: Enable errata based on implementation CPUs")
> > 
> > ^^^ Is this really necessary as they get backported as well ?
> 
> The blamed commit was introduced this release cycle so no concern about
> backports.
> 

Ah OK, sorry didn't look at the details.

> > Since, KVM maintainers are in cc-ed, let me know if you guys want to pick
> > this ? Else I can send it as part of my firmware (ffa/scmi) fixes.
> 
> I can grab the fix here in a moment, I've already got one queued up [*]
> for the KVM guest driver anyway.
> 

Thanks!

-- 
Regards,
Sudeep