From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F88DC46CA1 for ; Mon, 18 Sep 2023 12:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bCiVSqAaiFycGShIcxCBtlquA1mGXYBOTCDsQ28yLcc=; b=iDhKxpWio4i6nb WfOJ92d7DGXn+OpZeQOPcvIE8jQhjqyYthW9Uma7lz1/SxoI66Hwha/dljVuxgrRZNZBf8/69BW6J rm+dNxij2esHHQqRzZ6Oj+3J2QxpLyduyjigNLHXQBR2rMYbkE6cb7FqDxnjKJj1ksmE5NErGFKgk 4lzQxenzYzga23LnzKsYYdqbMx1l8kTerfIQglsKWR0A4Cf+QjnmXvuSIvTlfuNtoflNp1g3Dcegw NlHztJWfMTEhuVviWt8Gv0Vm22JtpoQ3EWL3IGDuByjFBz12SHDmTZdVAvxyyCLsc2hXNc/J4AVVQ 7oowTxrbWPX3xR+nAizQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiCua-00FNIL-1X; Mon, 18 Sep 2023 11:59:32 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiCuW-00FNFu-37 for linux-arm-kernel@lists.infradead.org; Mon, 18 Sep 2023 11:59:30 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9ada6b0649fso590058766b.1 for ; Mon, 18 Sep 2023 04:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695038366; x=1695643166; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mx+1LEKjG08mHXdWiW0HFl/U3LRaOvUzyjCNt5ITLZc=; b=c9lVzMu609WWFHI9Dx/HzUi4jLUqox+g5CR7MBYzpRQcXmQy/5vHNRTGbfGiuUP264 8ZBZf7peus6zxu5TATagHajOmoi8LYLvLr0gBgXV7YfGkdHH3vDyrH1bHfWn3NAYA7p/ YHTF1GfUqs5yYaG9ARsN/k7lFBKl0UBe8LFnOGS2uGmhv8Jr1l7RQuv+KX7cjLDeVvoS 12yaKbFZT6er65anfOItnYyePRJ3AyY5e8ErpKX/bsF6WvCcZYIYYDvZQVxwmrZzAPLY oaLLu7PKqglsg4upAL5muQSKCEJs+nfg5Nm4AkEdHnMudrmwxkorB/JwHK2hge465dmU ADJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695038366; x=1695643166; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mx+1LEKjG08mHXdWiW0HFl/U3LRaOvUzyjCNt5ITLZc=; b=uGjheEI+ywUnRqzUqsEG9j7RXskl8SnE0pdRBp+gc3uFUyV4ig+r8LmGwCtZHlBTgc aQwFtgfUFHdx8ushEK7sEMdg2Otna8nKNmCe6seWd9qJcdc2seF1qdhlL9Do8AkLLCFd 7982MGXvlsWiUsOWPH4ZfcP8hy9/dwKYK11mozwu3elqtiMeLYvXSAWKmPYUHb9UE+KA 5SCMJXpgWS2KwD1/0gTJn7VKrYcZNsUsZPajQ3GUNnlVV8Bx/VamzkMnd2C7/C8Jka7o xpUt4j60dlEXO+4isvI9YwyVzZ3QvaZeKKjZgQ/0RNreYikgJ64cpNW7KuwVPkYaN7zu mrwQ== X-Gm-Message-State: AOJu0YyaMqFTvLUUC+IHFDGhLA6KOrOZ2+Nxc9oy+7X6Okv7KOU9aJLx Idd8e+qdAcHYy3u7Jn0YnG/ieQ== X-Google-Smtp-Source: AGHT+IEQU5aP9n0ZpbF9FIWm05VurFH/Lgko0yhluHa5UJmuOfDQoNjoIOALZWR4TY4wUZ0dcYYJAQ== X-Received: by 2002:a17:906:5188:b0:9a1:db97:62a1 with SMTP id y8-20020a170906518800b009a1db9762a1mr7333228ejk.46.1695038366283; Mon, 18 Sep 2023 04:59:26 -0700 (PDT) Received: from [172.25.80.114] ([217.67.225.27]) by smtp.gmail.com with ESMTPSA id j9-20020a170906410900b0099cc3c7ace2sm6466812ejk.140.2023.09.18.04.59.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 04:59:25 -0700 (PDT) Message-ID: Date: Mon, 18 Sep 2023 13:59:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 3/3] dt-bindings: hwinfo: Add mtk-socinfo driver Content-Language: en-US To: AngeloGioacchino Del Regno , William-tw Lin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Kevin Hilman Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20230915152607.18116-1-william-tw.lin@mediatek.com> <20230915152607.18116-4-william-tw.lin@mediatek.com> <3e7bc476-ffc7-fb07-8e64-246427da736c@linaro.org> <9acc8d99-e3db-3df8-4051-21d95450b28d@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <9acc8d99-e3db-3df8-4051-21d95450b28d@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_045929_003543_0F645504 X-CRM114-Status: GOOD ( 21.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/09/2023 10:47, AngeloGioacchino Del Regno wrote: > Il 17/09/23 10:26, Krzysztof Kozlowski ha scritto: >> On 15/09/2023 17:26, William-tw Lin wrote: >>> dt-binding documentation for mtk-socinfo driver. >> >> Here and in subject, drop driver and instead descrbe hardware. >> >>> mtk-socinfo driver provides SoC-related information. >>> Such information includes manufacturer information, SoC name, >>> SoC segment name, and SoC marketing name. >>> >>> Signed-off-by: William-tw Lin >>> --- >>> .../bindings/hwinfo/mtk-socinfo.yaml | 48 +++++++++++++++++++ >>> 1 file changed, 48 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml b/Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml >>> new file mode 100644 >>> index 000000000000..74f03f1dc404 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml >> >> Nothing improved. >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all >> requested changes or keep discussing them. >> >> Thank you. >> >>> @@ -0,0 +1,48 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/hwinfo/mtk-socinfo.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: MediaTek SoC ChipID >>> + >>> +maintainers: >>> + - William Lin >>> + - Matthias Brugger >>> + - Kevin Hilman >>> + - AngeloGioacchino Del Regno >>> + >>> +description: >>> + MediaTek SoCs store various product information in eFuses, including >>> + Chip ID and Revision fields, usable to identify the manufacturer, >>> + SoC version, plus segment and marketing names. >>> + >>> +properties: >>> + compatible: >>> + const: mediatek,socinfo >> >> What happened to compatibles? No, this is just wrong and no explained. >> You ignored other comments as well. Really, that's not the way to go. >> > > Practically, having different compatibles for each SoC is not needed, as > the only thing that changes between SoCs is the eFuse(s) that you read to > get the information - and that's all. And how do you guarantee that no future SoC will have any difference? How can you even predict it? > > So ... we either use this driver with devicetree, giving it the right eFuses I am talking about bindings, no driver. > to read from, or we duplicate the mtk-efuse driver, or we statically assign > the eFuses in the driver itself and we set compatibles like > "mediatek,mt8195-socinfo" to select that... ideas? Device specific compatibles followed by fallback, just like for every other review coming from me. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel