From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE61CC3A59B for ; Mon, 19 Aug 2019 07:23:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA57E2086C for ; Mon, 19 Aug 2019 07:23:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lk3wVgDR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="Hw7ZH9mS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA57E2086C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=geni7XjAKi6wYItwPKZFdvYtxk3iCiNPnPPLZTAFKnw=; b=Lk3wVgDRjl12DD tOIgTe5LY01Hl03eCQltoNdaKbYH13///g5z0vHgcsj8te9xGDvYzbXRl3oFVSjfzXFvKzpihiGHi ec5yknnbPBO+J5vacoHYrl+SA+V8VOACsLmRqQ/o6qRoL70CWe7Z+gGNKD75xnYn/b3nQ8wA+5+A9 vJMv9Or9EDCXO27qdoTMkEQq42FTX5h2oAfSHW5vSJqg2wir+QHPdO8r7t4HK2wV+6ZclQHOyXWVi jh3AwYqb5Sq8bhUqDj+z56HZm3Pg6VCrd7lTWkrtxMT7v8246Nj5b5LDqPsfOhg/O6+WLognSzXyg Hn63SyKIErr6loTWilKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzc0u-0003C9-1N; Mon, 19 Aug 2019 07:23:36 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzc0p-0003BS-Uk for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 07:23:33 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7J7MCgC019108; Mon, 19 Aug 2019 09:23:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=IBOE9ThChyn3HPj0nzP6E2WkbMPsLIygBXtx/PEdxeI=; b=Hw7ZH9mSgKeNlQZ++PZMRAcJg0Ay5xqKI6dS4w26o6q6xSodd/H1RzRpm+G5v20+i7/l uDLQXL3Xm/+TUG1n7nUkTFr/xzLvc/rGgti5Ivc6j4HERgOf4dMlWK2libUk6qQ4RIHH ULz5qgZZRN5zL9npWhkSLJM2oxGwFylxvV4BJYy+0j5Nc9VJYiHHFRljKdGbjJhlx4nW DVBY4LYF9LN7yvxsNZu827tW/rDZwqEgfmue01Wz8VzSRkUSYeOsq68EGnSvUmk63nHQ O8wmuAEauv1UI0pAj3l+5+1/IT9uOCxGwJqLGo8P808opk8HgUQBsewE2YgDrPkvuSED tw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2ue7buhv3h-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 19 Aug 2019 09:23:19 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 100F331; Mon, 19 Aug 2019 07:23:18 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag6node3.st.com [10.75.127.18]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id EF6932BF9FA; Mon, 19 Aug 2019 09:23:17 +0200 (CEST) Received: from SFHDAG5NODE1.st.com (10.75.127.13) by SFHDAG6NODE3.st.com (10.75.127.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 19 Aug 2019 09:23:17 +0200 Received: from SFHDAG5NODE1.st.com ([fe80::cc53:528c:36c8:95f6]) by SFHDAG5NODE1.st.com ([fe80::cc53:528c:36c8:95f6%20]) with mapi id 15.00.1473.003; Mon, 19 Aug 2019 09:23:17 +0200 From: Hugues FRUCHET To: Sakari Ailus Subject: Re: [PATCH v6 2/4] media: stm32-dcmi: trace the supported fourcc/mbus_code Thread-Topic: [PATCH v6 2/4] media: stm32-dcmi: trace the supported fourcc/mbus_code Thread-Index: AQHVVAq68UiFQiNcNkmXdD8YMRgfcacB9FUA Date: Mon, 19 Aug 2019 07:23:17 +0000 Message-ID: References: <1565790533-10043-1-git-send-email-hugues.fruchet@st.com> <1565790533-10043-3-git-send-email-hugues.fruchet@st.com> <20190816081514.GU6133@paasikivi.fi.intel.com> In-Reply-To: <20190816081514.GU6133@paasikivi.fi.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.50] Content-ID: <02FB72ACF9496F4298AB952A072DDEA0@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-08-19_02:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_002332_285588_0418E5D1 X-CRM114-Status: GOOD ( 20.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yannick FERTRE , Alexandre TORGUE , Mickael GUENE , "linux-kernel@vger.kernel.org" , Philippe CORNU , Hans Verkuil , Benjamin Gaignard , Mauro Carvalho Chehab , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, On 8/16/19 10:15 AM, Sakari Ailus wrote: > Hi Hugues, > > On Wed, Aug 14, 2019 at 03:48:51PM +0200, Hugues Fruchet wrote: >> Add a trace of the set of supported fourcc/mbus_code which >> intersect between DCMI and source sub-device. >> >> Signed-off-by: Hugues Fruchet >> --- >> drivers/media/platform/stm32/stm32-dcmi.c | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c >> index b462f71..18acecf 100644 >> --- a/drivers/media/platform/stm32/stm32-dcmi.c >> +++ b/drivers/media/platform/stm32/stm32-dcmi.c >> @@ -1447,12 +1447,20 @@ static int dcmi_formats_init(struct stm32_dcmi *dcmi) >> /* Code supported, have we got this fourcc yet? */ >> for (j = 0; j < num_fmts; j++) >> if (sd_fmts[j]->fourcc == >> - dcmi_formats[i].fourcc) >> + dcmi_formats[i].fourcc) { >> /* Already available */ >> + dev_dbg(dcmi->dev, "Skipping fourcc/code: %4.4s/0x%x\n", >> + (char *)&sd_fmts[j]->fourcc, >> + mbus_code.code); >> break; >> - if (j == num_fmts) >> + } >> + if (j == num_fmts) { >> /* New */ >> sd_fmts[num_fmts++] = dcmi_formats + i; >> + dev_dbg(dcmi->dev, "Supported fourcc/code: %4.4s/0x%x\n", > > Over 80 characters per line. > This an exception of the "80 chars" in order to be able to grep in kernel messages: https://www.kernel.org/doc/html/v4.10/process/coding-style.html "However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them." This exception is managed in checkpatch.pl (--strict). >> + (char *)&sd_fmts[num_fmts - 1]->fourcc, >> + sd_fmts[num_fmts - 1]->mbus_code); >> + } >> } >> mbus_code.index++; >> } > BR, Hugues. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel