From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 682D3C433DF for ; Fri, 7 Aug 2020 18:18:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 322AB204EA for ; Fri, 7 Aug 2020 18:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YUtz2EwD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hEYA/snm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 322AB204EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Af6YqJPhDKEJX5c6hXQyaGD3nZO5aWJfM0gggtp4F14=; b=YUtz2EwD44lzAUiTfQCNOHMjr 23HwtWzLbdIzG4aMIkFPfiVJG5wn4t4EZtjAYen3qCN8JdK8I2DJiu73Z0T9Kn5o7tEOZlbFbX/Lv zwkgDFk8iAjzYg2r4SK+YyiW60WscfXSGkFBATXM7eX1Dv9wr2ivL118WI9iBxP9S82QozxQFWBUj 9hty7h5LVjwDdW1bcL5bH/eIW7FmUcvRuPXGp4OybHYIuRpxc/tr6wmyEB7DCOCLUhZZLFJj1e88M rQAsVIomn5j3YIDs5pMQIFCvSf1z61+1TBvARXx5LrbRJjgOttS8aTH12l5u5JaYHIcejspUzKtyz JFldJwpdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k46vu-00081u-Ea; Fri, 07 Aug 2020 18:17:34 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k46vr-00081N-NH for linux-arm-kernel@lists.infradead.org; Fri, 07 Aug 2020 18:17:32 +0000 Received: by mail-wm1-x341.google.com with SMTP id g8so2498431wmk.3 for ; Fri, 07 Aug 2020 11:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+RLcMf039Fja7+NVYfWd7LsUb0HLd5N8YbD0HQCYGKs=; b=hEYA/snmkEnBTWT41qnElh5RISovyGYu/KkzthXY5h6DXG3W0hdwlPVFr/1TAoXzeN g3hdpKG0rlvrSWBRhz3pHgXCOMaLU4F64766xythYWHQHlIEwrrFLdcqeFPRyJmojb1E heapMjHWiXzttkUCvdfk+AGwfd5/QdZ4kkv5nO1iVEmH96vtecMuYb4rsXnqnFW2BoXK pLMpM+R+B5IagfhSenzb51rHcZH1tGJMgwVOQRwG6S2/ilDdHL7Dd/kVhwIF3HsUKr17 VHBukSpEB9zVSSuJ5A3A0ny9PKP+RldiUG6Jami6ucXsNk21I6t1AdOCQvr0jFMJott7 F22A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+RLcMf039Fja7+NVYfWd7LsUb0HLd5N8YbD0HQCYGKs=; b=kKV/ZvLUM6hzVv5kgJcziAkNe4zkYnYHYC8BBWklcrPIZjpvaZ8LKHCQzaURSejDFf cu97Yy3omGwV7lEl+GaqjbIkQFWkTSAoORcmNbyNkNNF9pZCJhNnTxZqaCPDgxiAtILv TTTj+n+aBg6pW0AypkXz6mg53geEvvJF5EFOA9V/GWptgWrjGURyAshQeIfbuLbC4Irs XvByGpPkS1BEORYdtRWDsDhX3mRxhf5wT/UyH/5iyKq50oNBOq93QNHy50CdqcgTEEoP /XUfKEv3GmFtzqmz4WVt2ya/i5X/v2qO6hE6NQEeXv63g0Fl+FFR2ZAoQeT3M8k+ZWk0 oXyg== X-Gm-Message-State: AOAM532x4VSEHx9SJrXy7iSKzrcpdGp4ILtKkqwJ8OGXTtaoXiRuBtj0 GibRmMjQUTUwKk2WYJlIWTA= X-Google-Smtp-Source: ABdhPJw1gAmZHJQX55Ci8aLNAo0vKfunS/WHs1CJQjlHAcjBEZCQV97jdptYDEHSsVMoBeR0Tazsvg== X-Received: by 2002:a7b:c38a:: with SMTP id s10mr14609217wmj.13.1596824250547; Fri, 07 Aug 2020 11:17:30 -0700 (PDT) Received: from [10.230.30.107] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id k184sm11289988wme.1.2020.08.07.11.17.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 11:17:29 -0700 (PDT) Subject: Re: [PATCH stable v4.9 v2] arm64: entry: Place an SB sequence following an ERET instruction To: Greg KH , Will Deacon , Will Deacon References: <20200709195034.15185-1-f.fainelli@gmail.com> <20200720130411.GB494210@kroah.com> <9c29080e-8b3a-571c-3296-e0487fa473fa@gmail.com> <20200807131429.GB664450@kroah.com> From: Florian Fainelli Message-ID: Date: Fri, 7 Aug 2020 11:17:23 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200807131429.GB664450@kroah.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200807_141731_859794_8AB83AC1 X-CRM114-Status: GOOD ( 14.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nick Desaulniers , Andrew Jones , Fangrui Song , Suzuki K Poulose , Catalin Marinas , Kristina Martsenko , open list , stable@vger.kernel.org, "open list:KERNEL VIRTUAL MACHINE FOR ARM64 \(KVM/arm64\)" , Mark Brown , James Morse , linux-arm-kernel@lists.infradead.org, Sami Tolvanen , Marc Zyngier , Ard Biesheuvel , Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/7/2020 6:14 AM, Greg KH wrote: > On Thu, Aug 06, 2020 at 01:00:54PM -0700, Florian Fainelli wrote: >> >> >> On 7/20/2020 11:26 AM, Florian Fainelli wrote: >>> On 7/20/20 6:04 AM, Greg KH wrote: >>>> On Thu, Jul 09, 2020 at 12:50:23PM -0700, Florian Fainelli wrote: >>>>> From: Will Deacon >>>>> >>>>> commit 679db70801da9fda91d26caf13bf5b5ccc74e8e8 upstream >>>>> >>>>> Some CPUs can speculate past an ERET instruction and potentially perform >>>>> speculative accesses to memory before processing the exception return. >>>>> Since the register state is often controlled by a lower privilege level >>>>> at the point of an ERET, this could potentially be used as part of a >>>>> side-channel attack. >>>>> >>>>> This patch emits an SB sequence after each ERET so that speculation is >>>>> held up on exception return. >>>>> >>>>> Signed-off-by: Will Deacon >>>>> [florian: Adjust hyp-entry.S to account for the label >>>>> added change to hyp/entry.S] >>>>> Signed-off-by: Florian Fainelli >>>>> --- >>>>> Changes in v2: >>>>> >>>>> - added missing hunk in hyp/entry.S per Will's feedback >>>> >>>> What about 4.19.y and 4.14.y trees? I can't take something for 4.9.y >>>> and then have a regression if someone moves to a newer release, right? >>> >>> Sure, send you candidates for 4.14 and 4.19. >> >> Greg, did you have a chance to queue those changes for 4.9, 4.14 and 4.19? >> >> https://lore.kernel.org/linux-arm-kernel/20200720182538.13304-1-f.fainelli@gmail.com/ >> https://lore.kernel.org/linux-arm-kernel/20200720182937.14099-1-f.fainelli@gmail.com/ >> https://lore.kernel.org/linux-arm-kernel/20200709195034.15185-1-f.fainelli@gmail.com/ > > Nope, I was waiting for Will's "ack" for these. OK, Will, can you review those? Thanks -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel