From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBE70C7EE25 for ; Thu, 8 Jun 2023 08:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WJoicNpi6UqCNZVcEKSYdAg/UHxGXhx8XciM/ROCjjQ=; b=1xFQ3JsmdjPxWi u0VoIEzOqJDGiXJsqKVnCWmrPs0G9mXy7JSRBaLVY+K7jUgsbuNFopX77fXXUKgZ2ylV/IWGZCeDy HrzC6rYPbjFEUuLkOg7s3Bf+TzMXeqRqDrrczsQv8JlCOq8Rkzg4gTuG8BSP5B2VHErYgwY+oBOlr Uw+WKpED56LtYbpnMncIaxVFNZZ4Vki4WONhbv8cbPJSPvwKCZYmKIR8zy5vJ95fwS1/o6PNaSfyL +K7D7U9a3c/HrBY6KsEDyZ+HYFYKQPDJYWFaygWemGw/D9WDhQPtjVgebF5fJgNGUcRp5xSCSJvIZ Mataf82SoM7CvXzS0dqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7BBO-008YmW-0t; Thu, 08 Jun 2023 08:39:50 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7BBL-008Ylt-1R for linux-arm-kernel@lists.infradead.org; Thu, 08 Jun 2023 08:39:48 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-977d02931d1so55541466b.0 for ; Thu, 08 Jun 2023 01:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686213584; x=1688805584; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T60h+W0DC18nxsqz7trELMiyE2WR3VGoPPEa5hHXx+Q=; b=iyAq0hoQryh8EvDralt4E7z318BYMnia1f7pBiPyvP4AF+SIcXMPpSRzvhVbxF1JUH zLxoD7Z/W1y3YSrJ3d8QsupMO4uBHea6A3IJoYsc1TCmiMPwTTn9EcowtqzR5BS3t8+X PtHWFRxR2ljn4Qh94PXTURZW7oabLNX41piHq2O4284la+7jYsDq6S/ll0SKqrA7Ook3 rqMg7w4WzEZZI3KX2DPDiQEPiFrvs09O7xsWFP+sbYSa7nLnusOd7HJyMkwBhxDOhCxz aQu1jVMiUskjy5c60nGo5TNqaNmBBd0NgP96Vm7fk4KFb0HAndFnWgmuYef6ZTMOPHS2 3wEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686213584; x=1688805584; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T60h+W0DC18nxsqz7trELMiyE2WR3VGoPPEa5hHXx+Q=; b=XP/h+hM7JIc4TAoLWO6suW/qVu+FkJEa73oRyqptDgTuFVq5bqEM/S+r28moRjl63O TgEIBEk+XIWfiVSHAGPllTiqOLEcV4Ibqf8weAA9qN6Gj0P+/8W4oasKpL49Cy0m2KYd W7dnsQONXvjo9mezGbLgZhJaABKLQy7KxOzy36eBFTdMB5IrFSAShgPHpKIZ8arTu970 IKlWt62e1VQzA4suRibqFtelt1RuvQ9zOcyC+oJH7TT6OpxMEkUHzVMCslrFb1a4VCGN tnP5zHNeLhL+T0uhqlbkDd7U2mRrLkK/SiouK4LgkJVlo3XbmanrTuyJMmPogg12lLxV abxQ== X-Gm-Message-State: AC+VfDzxY9+R70TkfNISpbR60luNA0TItYi7vcqjVqHGffYy7zLDsLuc UM+zGbawTzwYLhUBKi8WbHWCnw== X-Google-Smtp-Source: ACHHUZ6+DFaOWxwBnwwn5BBCqCuWBnfpxcMfTyfrJlrYZN4vwswZ9T70B750ae6ffwKKz5XAccdyTg== X-Received: by 2002:a17:907:7e84:b0:978:6489:f9f with SMTP id qb4-20020a1709077e8400b0097864890f9fmr9130565ejc.52.1686213584247; Thu, 08 Jun 2023 01:39:44 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id k22-20020a1709065fd600b0096f830337e3sm384465ejv.129.2023.06.08.01.39.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 01:39:43 -0700 (PDT) Message-ID: Date: Thu, 8 Jun 2023 10:39:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [v6 1/4] dt-bindings: pwm: Add ASPEED PWM Control documentation Content-Language: en-US To: Billy Tsai , "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "thierry.reding@gmail.com" , "u.kleine-koenig@pengutronix.de" , "corbet@lwn.net" , "p.zabel@pengutronix.de" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "patrick@stwcx.xyz" References: <20230608021839.12769-1-billy_tsai@aspeedtech.com> <20230608021839.12769-2-billy_tsai@aspeedtech.com> <4dffd320-8e30-fb30-6ded-79519afddc21@linaro.org> <61278e12-ba39-4503-ca74-a7118b0f6e99@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_013947_493674_3589EF67 X-CRM114-Status: GOOD ( 14.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/06/2023 10:21, Billy Tsai wrote: > On 08/06/2023 09:47, Billy Tsai wrote: > >> > >> >> + > >> >> +allOf: > >> >> + - $ref: pwm.yaml# > >> >> + > >> >> +properties: > >> >> + compatible: > >> >> + enum: > >> >> + - aspeed,ast2600-pwm > >> >> + > >> >> + "#pwm-cells": > >> >> + const: 3 > >> > >> > 3 cells? For one PWM? What are they? > >> > >> channel, period and polarity. > > > Don't cut my responses. You wrote you have one PWM output, so only one > > channel. What do you put then in the channel? > > You need to put 0 in the cell of the channel, the example of the dts usage will like following: > > pwm0: pwm0@1e610000 { > compatible = "aspeed,ast2600-pwm"; > reg = <0x1e610000 0x8>; > #pwm-cells = <3>; > #address-cells = <1>; > #size-cells = <0>; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_pwm0_default>; > clocks = <&syscon ASPEED_CLK_AHB>; > resets = <&syscon ASPEED_RESET_PWM>; > status = "okay"; > }; > > pwm1: pwm1@1e610010 { > compatible = "aspeed,ast2600-pwm"; > reg = <0x1e610010 0x8>; > #pwm-cells = <3>; > #address-cells = <1>; > #size-cells = <0>; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_pwm1_default>; > clocks = <&syscon ASPEED_CLK_AHB>; > resets = <&syscon ASPEED_RESET_PWM>; > status = "okay"; BTW, these are not two PWM devices but one. I don't understand why you changed previous design into something like this, but this is not representing your hardware. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel