From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30DD2C4345F for ; Tue, 30 Apr 2024 04:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f8/Odum76SnSw8hw3jfGdgbBPxb51WdRYtyVZ32TfYc=; b=FGQJY6Q3KZWEME /jZByeg8b5ix5Y3WMUlLaFePI4Ou13dGkKNsNYVpm0OVMTJXHnpcok3ErFHXTgD9zFUQP7Pgo/VMZ GOqsYBV1rBizgSxI1cTHbdXAvmcDbrbQq0WtC39DsolWrMAE3uD9c9RNnGJjgoKqE1h8XDn9ikO4o pucTtEWUKdaFfOidRMH8P8GtFEtxFp55kGidVs4eZVY9MzZjvkbaMbo0xHJ5yuKHzq0yZvE3AHDw1 2/OBQlAg3TBiARLQWXXlOZ97oVs6xOXfAqa7xRjvmpKEkYRs/j3fh3Ht0Jg3lUUU9COAxWTJHBx3I fBE75sasY7FRdlbWlErg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1f9c-000000052LD-02k5; Tue, 30 Apr 2024 04:31:44 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1f9X-000000052K5-3ZF8 for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 04:31:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714451498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i13MtWkwJ9CzG5rHobsEqX+W2OhJEVkbAyH/jjvfJXM=; b=Rk75F/O35rMfoj1PUEvUhooEBOOm9F+bpXgOe7kl0h+vfuktsqv68gP4nyGQnez57Zypva luxPaUfM533imFf7jJhz5B78ljJY/Ul+IgzNmvNM4Ax4mZ9WcPOloRYAzrLV5R2uRFstF8 A8LJMiweB/xbSPYQDm4jK6zplFaNGK0= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-QlL_2OaaO2ax_9kX5G5-rA-1; Tue, 30 Apr 2024 00:31:35 -0400 X-MC-Unique: QlL_2OaaO2ax_9kX5G5-rA-1 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-1eab16ca864so58944565ad.2 for ; Mon, 29 Apr 2024 21:31:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714451494; x=1715056294; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i13MtWkwJ9CzG5rHobsEqX+W2OhJEVkbAyH/jjvfJXM=; b=is+TgsPCdWWaOZ0jpJfnF1gOR81ZClqDrVWuLvy4yOviQH3AjEq4ZFc4gWGLQ9tZLW 3Bm49BPxbIJLC/0rvnq8MIs9kgG6Uf/2+kCF+uwNFMjQ/+65Hl+33ijBB0D4x5DZZ+UK GuN0zrb5MjomDcyXsjq81QNaVTbU4SD3WdJjOrKTwclfubMVmROuQqm1BEhFcHPcoaPq ziSRijmMNMo+nRQ+nA3ysKv3QF5Ueouu6p/8VsEJvdG/Kyv8Iw+cNFDgJ35seHZeGeLx EBY8b7zZex5j4l+SZiJjigVX7nIS/VWlCu0pyyfTrT0JlLsOsMF86LwVP998SmNdaKCv SPHg== X-Forwarded-Encrypted: i=1; AJvYcCVUwFfsbMv/RPJTbOVIazWY94M6djMgBtyura497A2GJUdcjaCLf5yB3PMvnWGCUT2j/ClGjRWq6Big2QMuQgH5zWMcQ2XcT9AZWPIhzIocDbtMui8= X-Gm-Message-State: AOJu0YzJQB+TZ+t28HraGUDBuhERW7y67/sHg/yGX1aDFCA/W/oqSshB YgV/LpipsEHdIwrmsqOzSgyGjvo6iS0VvwEhuCEq4rCcVInSoJPtZ6GGVYJ/ks7KRXmfQ3VmKHX to4fS/6vVX3OG48fZsEKWxDx3CGw4k1K0qaXxSIAWEHAXPz5q9cXyFcqj/UEuNYbwOOPWH3Io X-Received: by 2002:a17:902:d2c8:b0:1e4:4000:a576 with SMTP id n8-20020a170902d2c800b001e44000a576mr14606368plc.43.1714451494083; Mon, 29 Apr 2024 21:31:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAw003t6HOSoCLpW/XUCLqCM5arMxu8YIqu/zbz1Hwe4t+r/fC177o/TfutrGEBjD75Dh+aQ== X-Received: by 2002:a17:902:d2c8:b0:1e4:4000:a576 with SMTP id n8-20020a170902d2c800b001e44000a576mr14606349plc.43.1714451493684; Mon, 29 Apr 2024 21:31:33 -0700 (PDT) Received: from [192.168.68.50] ([43.252.112.88]) by smtp.gmail.com with ESMTPSA id jv12-20020a170903058c00b001eab3baad5dsm8939394plb.4.2024.04.29.21.31.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Apr 2024 21:31:33 -0700 (PDT) Message-ID: Date: Tue, 30 Apr 2024 14:31:22 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 13/16] arm64: arch_register_cpu() variant to check if an ACPI handle is now available. To: Jonathan Cameron , Thomas Gleixner , Peter Zijlstra , linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, Russell King , "Rafael J . Wysocki" , Miguel Luis , James Morse , Salil Mehta , Jean-Philippe Brucker , Catalin Marinas , Will Deacon , Marc Zyngier , Hanjun Guo Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , linuxarm@huawei.com, justin.he@arm.com, jianyong.wu@arm.com, Lorenzo Pieralisi , Sudeep Holla References: <20240426135126.12802-1-Jonathan.Cameron@huawei.com> <20240426135126.12802-14-Jonathan.Cameron@huawei.com> From: Gavin Shan In-Reply-To: <20240426135126.12802-14-Jonathan.Cameron@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_213139_973644_F77DA20A X-CRM114-Status: GOOD ( 25.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/26/24 23:51, Jonathan Cameron wrote: > The ARM64 architecture does not support physical CPU HP today. > To avoid any possibility of a bug against such an architecture if defined > in future, check for the physical CPU HP case (not present) and > return an error on any such attempt. > > On ARM64 virtual CPU Hotplug relies on the status value that can be > queried via the AML method _STA for the CPU object. > > There are two conditions in which the CPU can be registered. > 1) ACPI disabled. > 2) ACPI enabled and the acpi_handle is available. > _STA evaluates to the CPU is both enabled and present. > (Note that in absence of the _STA method they are always in this > state). > > If neither of these conditions is met the CPU is not 'yet' ready > to be used and -EPROBE_DEFER is returned. > > Success occurs in the early attempt to register the CPUs if we > are booting with DT (no concept yet of vCPU HP) if not it succeeds > for already enabled CPUs when the ACPI Processor driver attaches to > them. Finally it may succeed via the CPU Hotplug code indicating that > the CPU is now enabled. > > For ACPI if CONFIG_ACPI_PROCESSOR the only path to get to > arch_register_cpu() with that handle set is via > acpi_processor_hot_add_init() which is only called from an ACPI bus > scan in which _STA has already been queried there is no need to > repeat it here. Add a comment to remind us of this in the future. > > Suggested-by: Rafael J. Wysocki > Tested-by: Miguel Luis > Signed-off-by: Jonathan Cameron > --- > V8: No change. (tags collected only) > --- > arch/arm64/kernel/smp.c | 53 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > Reviewed-by: Gavin Shan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel