From: Matthias Brugger <matthias.bgg@gmail.com>
To: Crystal Guo <crystal.guo@mediatek.com>,
linux@roeck-us.net, robh+dt@kernel.org
Cc: linux-watchdog@vger.kernel.org, srv_heupstream@mediatek.com,
seiya.wang@mediatek.com, erin.lo@mediatek.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v2,2/3] dt-bindings: watchdog: add a new head file for toprgu reset-controllers
Date: Wed, 29 Jul 2020 09:42:59 +0200 [thread overview]
Message-ID: <fb7ef8a7-5bbc-8e4b-7a23-c84f151587ba@gmail.com> (raw)
In-Reply-To: <1596004249-28655-3-git-send-email-crystal.guo@mediatek.com>
Hi Crystal,
On 29/07/2020 08:30, Crystal Guo wrote:
> merge all the reset numbers in one head file.
>
> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> ---
> include/dt-bindings/reset-controller/mtk-resets.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
> create mode 100644 include/dt-bindings/reset-controller/mtk-resets.h
>
> diff --git a/include/dt-bindings/reset-controller/mtk-resets.h b/include/dt-bindings/reset-controller/mtk-resets.h
> new file mode 100644
> index 0000000..d73a4ba
> --- /dev/null
> +++ b/include/dt-bindings/reset-controller/mtk-resets.h
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2020 Mediatek Inc.
> + *
> + */
> +
> +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MTK
> +#define _DT_BINDINGS_RESET_CONTROLLER_MTK
> +
> +#define MT2712_TOPRGU_SW_RST_NUM 11
> +#define MT8183_TOPRGU_SW_RST_NUM 19
Maybe I didn't explain myself properly. We want to have all resets in one file
and do not want to have the resets for the watchdog in a different file. That
means I don't thin your patch is correct and the effort should be abandoned.
Regards,
Matthias
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-29 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 6:30 [v2,0/3] mtk_wdt: merge all the reset numbers in one head file Crystal Guo
2020-07-29 6:30 ` [v2, 1/3] dt-bindings: watchdog: modify description for mt2712 and mt8183 Crystal Guo
2020-07-29 6:30 ` [v2, 2/3] dt-bindings: watchdog: add a new head file for toprgu reset-controllers Crystal Guo
2020-07-29 7:42 ` Matthias Brugger [this message]
2020-07-29 8:11 ` [v2,2/3] " Crystal Guo
2020-07-29 8:15 ` Matthias Brugger
2020-07-29 8:35 ` Crystal Guo
2020-07-29 6:30 ` [v3, 3/3] watchdog: mtk_wdt: merge all the reset numbers in one head file Crystal Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb7ef8a7-5bbc-8e4b-7a23-c84f151587ba@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=crystal.guo@mediatek.com \
--cc=erin.lo@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).