Re: [PATCH v2 2/3] dt-bindings: pinctrl: samsung: Add exynos9610-wakeup-eint node

[Krzysztof Kozlowski <krzk@kernel.org>]

On 31/12/2025 13:28, Alexandru Chimac wrote:
> On Tuesday, December 30th, 2025 at 11:51, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>>
>> On Sun, Dec 28, 2025 at 06:05:52PM +0000, Alexandru Chimac wrote:
>>
>>> Add a dedicated compatible for the exynos9610-wakeup-eint node,
>>> which is compatbile with Exynos850's implementation (and the
>>> Exynos7 fallback).
>>>
>>> Signed-off-by: Alexandru Chimac alex@chimac.ro
>>> ---
>>> .../devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>>> index f3c433015b12..deb2730855bd 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>>> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>>> @@ -48,6 +48,7 @@ properties:
>>> - enum:
>>> - google,gs101-wakeup-eint
>>> - samsung,exynos2200-wakeup-eint
>>> + - samsung,exynos9610-wakeup-eint
>>> - samsung,exynos9810-wakeup-eint
>>> - samsung,exynos990-wakeup-eint
>>> - samsung,exynosautov9-wakeup-eint
>>> @@ -107,6 +108,7 @@ allOf:
>>> contains:
>>> enum:
>>> - samsung,exynos850-wakeup-eint
>>> + - samsung,exynos9610-wakeup-eint
>>
>>
>> This is not needed. Device has 850 fallback, no?
> It's not required, but I guess it would make the device tree look better. If this patch isn't to be merged, it doesn't functionally affect anything so it can just be dropped instead of requiring another patchset revision.

Please wrap your replies.

I did not comment on the patch. Comments are in specific places
discussing specific lines. I asked why do you need this enum to grow?


Best regards,
Krzysztof