From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Paul Cercueil <paul@crapouillou.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: samsung: exynos4210-i9100: Enable RTS/CTS in Bluetooth node
Date: Wed, 9 Sep 2026 07:57:08 +0200 [thread overview]
Message-ID: <fba04516-9f78-49dd-978c-53d4256a7d88@kernel.org> (raw)
In-Reply-To: <62afdbc4-f21a-477a-b0ab-de20c96b4b6d@samsung.com>
On 07/09/2026 10:16, Marek Szyprowski wrote:
> On 03.09.2026 15:29, Paul Cercueil wrote:
>> Le mercredi 02 septembre 2026 à 10:36 +0200, Marek Szyprowski a écrit :
>>> On 29.08.2026 12:15, Paul Cercueil wrote:
>>>> The BCM4330 is connected using CTS/RTS too, so add the 'uart-has-
>>>> rtscts'
>>>> property.
>>>>
>>>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>> Indeed the CTS/RTS pins are used for BT on most of the ARM Exynos
>>> boards,
>>> as the "<&uartX_fctl>" property is assigned for pinctl-0. This is not
>>> really
>>> specific to i9100, so maybe this property should be added to other
>>> dts?
>> I can add it to all exynos4 boards that use the "uartX_fctl" property.
>>
>>
>>> However I wonder if Samsung UART driver actually use this "uart-has-
>>> rtscts"
>>> DT property? A quick "git grep uart-has-rtscts drivers/tty" shows
>>> nothing
>>> related to Samsung Exynos...
>> It looks like it does not. I still think the DT property should be here
>> but I won't fight over this.
> I also don't have strong opinion on this issue. Krzysztof: do You see
> any benefit from adding this "uart-has-rtscts" property, just to describe
> precisely the actual hardware, even if it won't be used by any driver?
>
Yes, it makes sense, because drivers could be improved or DTS could be
used in other project, but it also does not really matter in such case.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-09 5:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260829101532eucas1p29f4e04d4dfd169377793c276221059a6@eucas1p2.samsung.com>
2026-08-29 10:15 ` [PATCH v2] ARM: dts: samsung: exynos4210-i9100: Enable RTS/CTS in Bluetooth node Paul Cercueil
2026-09-01 14:27 ` Paul Cercueil
2026-09-02 8:36 ` Marek Szyprowski
2026-09-03 13:29 ` Paul Cercueil
2026-09-07 8:16 ` Marek Szyprowski
2026-09-09 5:57 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba04516-9f78-49dd-978c-53d4256a7d88@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=paul@crapouillou.net \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox