From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] OPP: Create _remove_device_opp() for freeing dev_opp
Date: Mon, 15 Jun 2015 17:27:28 +0530 [thread overview]
Message-ID: <fba1ec728e2ecf9303e13372a2557d886aa7e49c.1434369079.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1434369079.git.viresh.kumar@linaro.org>
This will be used from multiple places later. Lets create a separate
routine for that.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/base/power/opp.c | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index 8c3fd57975fb..7895fdd64192 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -449,6 +449,22 @@ static void _kfree_device_rcu(struct rcu_head *head)
}
/**
+ * _remove_device_opp() - Removes a device OPP table
+ * @dev_opp: device OPP table to be removed.
+ *
+ * Removes/frees device OPP table it it doesn't contain any OPPs.
+ */
+static void _remove_device_opp(struct device_opp *dev_opp)
+{
+ if (!list_empty(&dev_opp->opp_list))
+ return;
+
+ list_del_rcu(&dev_opp->node);
+ call_srcu(&dev_opp->srcu_head.srcu, &dev_opp->rcu_head,
+ _kfree_device_rcu);
+}
+
+/**
* _kfree_opp_rcu() - Free OPP RCU handler
* @head: RCU head
*/
@@ -481,11 +497,7 @@ static void _opp_remove(struct device_opp *dev_opp,
list_del_rcu(&opp->node);
call_srcu(&dev_opp->srcu_head.srcu, &opp->rcu_head, _kfree_opp_rcu);
- if (list_empty(&dev_opp->opp_list)) {
- list_del_rcu(&dev_opp->node);
- call_srcu(&dev_opp->srcu_head.srcu, &dev_opp->rcu_head,
- _kfree_device_rcu);
- }
+ _remove_device_opp(dev_opp);
}
/**
--
2.4.0
next prev parent reply other threads:[~2015-06-15 11:57 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 11:57 [PATCH 00/10] OPP: Add code to support operating-points-v2 bindings Viresh Kumar
2015-06-15 11:57 ` [PATCH 01/10] opp: Relocate few routines Viresh Kumar
2015-07-02 1:25 ` Stephen Boyd
2015-07-24 17:08 ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` Viresh Kumar [this message]
2015-07-02 1:25 ` [PATCH 02/10] OPP: Create _remove_device_opp() for freeing dev_opp Stephen Boyd
2015-07-24 17:13 ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 03/10] OPP: Allocate dev_opp from _add_device_opp() Viresh Kumar
2015-07-02 1:02 ` Stephen Boyd
2015-07-02 6:24 ` Viresh Kumar
2015-07-02 23:46 ` Stephen Boyd
2015-07-03 6:45 ` Viresh Kumar
2015-07-06 22:31 ` Stephen Boyd
2015-07-24 17:25 ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 04/10] OPP: Break _opp_add_dynamic() into smaller functions Viresh Kumar
2015-07-24 17:42 ` Bartlomiej Zolnierkiewicz
2015-06-15 11:57 ` [PATCH 05/10] opp: Add support to parse "operating-points-v2" bindings Viresh Kumar
2015-07-02 1:13 ` Stephen Boyd
2015-07-02 6:38 ` Viresh Kumar
2015-07-02 16:07 ` Stephen Boyd
2015-07-03 6:08 ` Viresh Kumar
2015-07-08 13:41 ` Bartlomiej Zolnierkiewicz
2015-07-09 5:18 ` Viresh Kumar
2015-07-24 18:02 ` Bartlomiej Zolnierkiewicz
2015-07-27 3:14 ` Viresh Kumar
2015-07-27 3:02 ` Viresh Kumar
2015-07-28 23:03 ` Stephen Boyd
2015-07-29 6:53 ` Viresh Kumar
2015-07-30 10:17 ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 06/10] OPP: Add clock-latency-ns support Viresh Kumar
2015-07-02 1:27 ` Stephen Boyd
2015-06-15 11:57 ` [PATCH 07/10] opp: Add OPP sharing information to OPP library Viresh Kumar
2015-07-17 22:51 ` Stephen Boyd
2015-07-18 6:33 ` Viresh Kumar
2015-07-20 17:46 ` Stephen Boyd
2015-07-21 2:18 ` Viresh Kumar
2015-07-27 3:20 ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 08/10] OPP: Add support for opp-suspend Viresh Kumar
2015-07-17 19:22 ` Stephen Boyd
2015-07-18 6:32 ` Viresh Kumar
2015-06-15 11:57 ` [PATCH 09/10] opp: Add helpers for initializing CPU OPPs Viresh Kumar
2015-06-15 11:57 ` [PATCH 10/10] cpufreq-dt: Add support for operating-points-v2 bindings Viresh Kumar
2015-07-09 16:13 ` Bartlomiej Zolnierkiewicz
2015-07-09 16:44 ` Bartlomiej Zolnierkiewicz
2015-07-15 2:59 ` Viresh Kumar
2015-06-30 16:44 ` [PATCH 00/10] OPP: Add code to support " Viresh Kumar
2015-07-17 2:36 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba1ec728e2ecf9303e13372a2557d886aa7e49c.1434369079.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).