From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] phy: meson8b-usb2: fix offsets for some of the registers
Date: Mon, 27 Mar 2017 15:36:47 +0530 [thread overview]
Message-ID: <fbac4a02-6aae-c763-b632-7b3d3fb3a413@ti.com> (raw)
In-Reply-To: <CAFBinCB_Om_XJ4ubTQbFcGzqYxGrVYhn1fJpB5Um1b-S7k3ohA@mail.gmail.com>
On Saturday 25 March 2017 12:49 AM, Martin Blumenstingl wrote:
> Hi Kishon,
>
> On Sat, Mar 4, 2017 at 11:20 AM, Martin Blumenstingl
> <martin.blumenstingl@googlemail.com> wrote:
>> The register offsets for REG_DBG_UART (and all following) were off by
>> 0x4. This was not a problem yet because these registers are currently
>> not used by the driver.
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
> gentle ping - please let me know if something is missing (for example
> some ACK orreview) before you are going to apply this
>
merged it now.
Thanks
Kishon
>> ---
>> changes since v1:
>> - added Jerome's Reviewed-By
>>
>> drivers/phy/phy-meson8b-usb2.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/phy/phy-meson8b-usb2.c b/drivers/phy/phy-meson8b-usb2.c
>> index 33c9f4ba157d..30f56a6a411f 100644
>> --- a/drivers/phy/phy-meson8b-usb2.c
>> +++ b/drivers/phy/phy-meson8b-usb2.c
>> @@ -81,9 +81,9 @@
>> #define REG_ADP_BC_ACA_PIN_GND BIT(25)
>> #define REG_ADP_BC_ACA_PIN_FLOAT BIT(26)
>>
>> -#define REG_DBG_UART 0x14
>> +#define REG_DBG_UART 0x10
>>
>> -#define REG_TEST 0x18
>> +#define REG_TEST 0x14
>> #define REG_TEST_DATA_IN_MASK GENMASK(3, 0)
>> #define REG_TEST_EN_MASK GENMASK(7, 4)
>> #define REG_TEST_ADDR_MASK GENMASK(11, 8)
>> @@ -93,7 +93,7 @@
>> #define REG_TEST_DATA_OUT_MASK GENMASK(19, 16)
>> #define REG_TEST_DISABLE_ID_PULLUP BIT(20)
>>
>> -#define REG_TUNE 0x1c
>> +#define REG_TUNE 0x18
>> #define REG_TUNE_TX_RES_TUNE_MASK GENMASK(1, 0)
>> #define REG_TUNE_TX_HSXV_TUNE_MASK GENMASK(3, 2)
>> #define REG_TUNE_TX_VREF_TUNE_MASK GENMASK(7, 4)
>> --
>> 2.12.0
>>
>
>
> Regards,
> Martin
>
prev parent reply other threads:[~2017-03-27 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 18:53 [PATCH] phy: meson8b-usb2: fix offsets for some of the registers Martin Blumenstingl
2017-02-03 20:05 ` Martin Blumenstingl
2017-02-10 9:27 ` Jerome Brunet
2017-03-04 10:20 ` [PATCH v2] " Martin Blumenstingl
2017-03-24 19:19 ` Martin Blumenstingl
2017-03-27 10:06 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbac4a02-6aae-c763-b632-7b3d3fb3a413@ti.com \
--to=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox