From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22DC0C432C3 for ; Fri, 15 Nov 2019 14:52:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3BC120730 for ; Fri, 15 Nov 2019 14:52:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z2FTkA7F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3BC120730 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pw5MeYl24aw9ldTPdY9LS/+HjDwezFQRpdIIvP/7RPg=; b=Z2FTkA7FSJorYl McXMvbiVEy1CkJm9ECjCWjlYGwIBw1AiFGsiciFnlw37YstLQGcsBOJkvGs+rMV6S1SvFom+9EGDL N5C8I5KQMdGDI/Jy6ufM3DvznH93Ohec4PYa4ii5rMSQng4BACKnH/33zT/2KjojkbfC5LQPBdluD d7kKiCJHvcNu2bwkkq1WUtb/eSePzJRkfzK3mg6/T7lh/UcJYEIsGp5b88EnRYAR2NeniE8bCJ392 vLnObrVvcur8PZ14AU/6b9/Vm172G4OfVvLVjYI33kccPAGhfMWpIMPMZwG/UZmcle+3P0FHIBNK9 FQjUY+i2JWEeoLxcRgmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVcxd-0002GX-8A; Fri, 15 Nov 2019 14:52:33 +0000 Received: from rtits2.realtek.com ([211.75.126.72] helo=rtits2.realtek.com.tw) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVcxX-0002Fl-Rr; Fri, 15 Nov 2019 14:52:30 +0000 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID xAFEqHBg010614, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (RTITCAS12.realtek.com.tw[172.21.6.16]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id xAFEqHBg010614 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Nov 2019 22:52:17 +0800 Received: from RTEXMB03.realtek.com.tw (172.21.6.96) by RTITCAS12.realtek.com.tw (172.21.6.16) with Microsoft SMTP Server (TLS) id 14.3.468.0; Fri, 15 Nov 2019 22:52:17 +0800 Received: from RTEXMB03.realtek.com.tw (172.21.6.96) by RTEXMB03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Fri, 15 Nov 2019 22:52:16 +0800 Received: from RTEXMB03.realtek.com.tw ([::1]) by RTEXMB03.realtek.com.tw ([fe80::3d7d:f7db:e1fb:307b%12]) with mapi id 15.01.1779.005; Fri, 15 Nov 2019 22:52:16 +0800 From: James Tai To: =?utf-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: RE: [PATCH v3 2/2] arm64: dts: realtek: Add RTD1619 SoC and Realtek Mjolnir EVB Thread-Topic: [PATCH v3 2/2] arm64: dts: realtek: Add RTD1619 SoC and Realtek Mjolnir EVB Thread-Index: AdWZPm2tRLsPwxTXS12xPqXOk/yn2wA93OMAAGNK7sA= Date: Fri, 15 Nov 2019 14:52:16 +0000 Message-ID: References: <73fb8106ec1a4665b59a2d187a576b71@realtek.com> <9cadb78c-99af-8948-e76f-c26f263693b3@suse.de> In-Reply-To: <9cadb78c-99af-8948-e76f-c26f263693b3@suse.de> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [114.37.161.94] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191115_065228_177223_C21C116F X-CRM114-Status: GOOD ( 18.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , 'DTML' , "linux-realtek-soc@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Rob Herring , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > Add Device Trees for Realtek RTD1619 SoC family, RTD1619 SoC and > > Realtek Mjolnir EVB. > > > > Signed-off-by: James Tai > > --- > > Lacking the requested changelog. > > > arch/arm64/boot/dts/realtek/Makefile | 2 + > > .../boot/dts/realtek/rtd1619-mjolnir.dts | 40 +++++ > > arch/arm64/boot/dts/realtek/rtd1619.dtsi | 12 ++ > > arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 163 > ++++++++++++++++++ > > 4 files changed, 217 insertions(+) > > create mode 100644 arch/arm64/boot/dts/realtek/rtd1619-mjolnir.dts > > create mode 100644 arch/arm64/boot/dts/realtek/rtd1619.dtsi > > create mode 100644 arch/arm64/boot/dts/realtek/rtd16xx.dtsi > > Somehow the last hunk (rtd16xx.dtsi) didn't apply with git-am or patch -p1, not > sure why. I have manually copied the file into place and fixed up some more > nits below: > > > > > diff --git a/arch/arm64/boot/dts/realtek/Makefile > > b/arch/arm64/boot/dts/realtek/Makefile > > index 555638ada721..fb5f05978ecc 100644 > > --- a/arch/arm64/boot/dts/realtek/Makefile > > +++ b/arch/arm64/boot/dts/realtek/Makefile > > @@ -7,3 +7,5 @@ dtb-$(CONFIG_ARCH_REALTEK) += > rtd1295-probox2-ava.dtb > > dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-zidoo-x9s.dtb > > > > dtb-$(CONFIG_ARCH_REALTEK) += rtd1296-ds418.dtb > > + > > +dtb-$(CONFIG_ARCH_REALTEK) += rtd1619-mjolnir.dtb > > diff --git a/arch/arm64/boot/dts/realtek/rtd1619-mjolnir.dts > > b/arch/arm64/boot/dts/realtek/rtd1619-mjolnir.dts > > new file mode 100644 > > index 000000000000..6ab791af3896 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/realtek/rtd1619-mjolnir.dts > > @@ -0,0 +1,40 @@ > > +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > > +/* > > + * Copyright (c) 2019 Realtek Semiconductor Corp. > > + */ > > + > > +/dts-v1/; > > + > > +#include "rtd1619.dtsi" > > + > > +/ { > > + compatible = "realtek,rtd1619", "realtek,mjolnir"; > > Order not fixed from v2. This is a schema violation and logically wrong. > > > + model= "Realtek Mjolnir EVB"; > > Space missing before =. Missed that in v2. > > > + > > + memory@0 { > > + device_type = "memory"; > > + reg = <0x0 0x80000000>; > > + }; > > + > > + chosen { > > + stdout-path = "serial0:115200n8"; > > + }; > > + > > + aliases { > > + serial0 = &uart0; /* The UART0 is debug console */ > > + serial1 = &uart1; /* The UART1 is on M.2 slot */ > > + serial2 = &uart2; /* The UART2 is on GPIO connector */ > > + }; > > +}; > > + > > +&uart0 { > > + status = "okay"; > > +}; > > + > > +&uart1 { > > + status = "disabled"; > > +}; > > + > > +&uart2 { > > + status = "disabled"; > > +}; > > The comments were intended to go above each node, not after the aliases. > I've taken the liberty to annotate them further with their PCB label. > > > diff --git a/arch/arm64/boot/dts/realtek/rtd1619.dtsi > > b/arch/arm64/boot/dts/realtek/rtd1619.dtsi > > new file mode 100644 > > index 000000000000..e52bf708b04e > > --- /dev/null > > +++ b/arch/arm64/boot/dts/realtek/rtd1619.dtsi > > @@ -0,0 +1,12 @@ > > +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > > +/* > > + * Realtek RTD1619 SoC > > + * > > + * Copyright (c) 2019 Realtek Semiconductor Corp. > > + */ > > + > > +#include "rtd16xx.dtsi" > > + > > +/ { > > + compatible = "realtek,rtd1619"; > > +}; > > diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi > > b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi > > new file mode 100644 > > index 000000000000..d9b572a870f5 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi > > @@ -0,0 +1,163 @@ > > +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > > +/* > > + * Realtek RTD16xx SoC family > > + * > > + * Copyright (c) 2019 Realtek Semiconductor Corp. > > + */ > > + > > +#include > > +#include > > + > > +/{ > > Space missing. Missed that in v2. > > > + interrupt-parent = <&gic>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu0: cpu@0 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a55"; > > + reg = <0x0>; > > + enable-method = "psci"; > > + next-level-cache = <&l2>; > > + }; > > + > > + cpu1: cpu@100 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a55"; > > + reg = <0x100>; > > + enable-method = "psci"; > > + next-level-cache = <&l3>; > > + }; > > + > > + cpu2: cpu@200 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a55"; > > + reg = <0x200>; > > + enable-method = "psci"; > > + next-level-cache = <&l3>; > > + }; > > + > > + cpu3: cpu@300 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a55"; > > + reg = <0x300>; > > + enable-method = "psci"; > > + next-level-cache = <&l3>; > > + }; > > + > > + cpu4: cpu@400 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a55"; > > + reg = <0x400>; > > + enable-method = "psci"; > > + next-level-cache = <&l3>; > > + }; > > + > > + cpu5: cpu@500 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a55"; > > + reg = <0x500>; > > + enable-method = "psci"; > > + next-level-cache = <&l3>; > > + }; > > + > > + l2: l2-cache { > > + compatible = "cache"; > > + next-level-cache = <&l3>; > > + > > + }; > > + > > + l3: l3-cache { > > + compatible = "cache"; > > + }; > > + }; > > + > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = , > > + , > > + , > > + ; > > + }; > > + > > + arm_pmu: pmu { > > + compatible = "arm,armv8-pmuv3"; > > + interrupts = ; > > + }; > > + > > + psci { > > + compatible = "arm,psci-1.0"; > > + method = "smc"; > > + }; > > + > > + osc27M: osc { > > + compatible = "fixed-clock"; > > + clock-frequency = <27000000>; > > + clock-output-names = "osc27M"; > > + #clock-cells = <0>; > > + }; > > + > > + soc@98000000 { > > If the node has a unit address, it also needs a reg property with that value. So > let's drop the unit address. > > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0x98000000 0x98000000 0x68000000>; > > + > > + rbus: r-bus@98000000 { > > + compatible = "simple-bus"; > > + reg = <0x98000000 0x200000>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0x0 0x98000000 0x200000>; > > + > > + uart0: serial0@7800 { > > + compatible = "snps,dw-apb-uart"; > > + reg = <0x7800 0x400>; > > + reg-shift = <2>; > > + reg-io-width = <4>; > > + interrupts = ; > > + clock-frequency = <27000000>; > > + status = "disabled"; > > + }; > > + > > + uart1: serial1@1b200 { > > + compatible = "snps,dw-apb-uart"; > > + reg = <0x1b200 0x400>; > > + reg-shift = <2>; > > + reg-io-width = <4>; > > + interrupts = ; > > + clock-frequency = <432000000>; > > + status = "disabled"; > > + }; > > + > > + uart2: serial2@1b400 { > > + compatible = "snps,dw-apb-uart"; > > + reg = <0x1b400 0x400>; > > + reg-shift = <2>; > > + reg-io-width = <4>; > > + interrupts = ; > > + clock-frequency = <432000000>; > > + status = "disabled"; > > + }; > > + }; > > + > > + gic: interrupt-controller@ff100000 { > > + compatible = "arm,gic-v3"; > > + reg = <0xff100000 0x10000>, > > + <0xff140000 0xc0000>; > > + interrupt-controller; > > + #interrupt-cells = <3>; > > + interrupts = ; > > + }; > > + }; > > +}; > > + > > +&arm_pmu { > > + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, > > + <&cpu3>, <&cpu4>, <&cpu5>; > > +}; > > Now that they're in the same file, this can just go into the node. > I'll correct these mistakes in next version. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel