From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24720C388F9 for ; Tue, 27 Oct 2020 14:26:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCA6322265 for ; Tue, 27 Oct 2020 14:26:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G5ST2g5r"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R/Uxb9xV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCA6322265 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fsmJOtXndJrQcfvvrD0drhTI3drL8Vp6ZcL2An/g8H4=; b=G5ST2g5rS2G2vnXr64k58AavJ hmNEVmLTRldQRiHfMjMIukNoGZ4Uexig4yGzYFn/hllFrR9aEob3dWclBBwX4/G+/oS/4obMUoIs4 vWxxYMbXvODaZ43rattRo9inB89KJAYyGb41ZmQKMAOFrEwJ6yR+URjcW8AgflkJWTmUNhYif26cg ZCJzfGOc7l3Aa4yZQSuPXssvR/1NPpYpCAJ52zn0gvRBr9Y/Nr5+6zgDU6Q5CjuTRD77uWNWCs2Mo Ce11lPcTXLBKEcyfJdsvrY05i47XsvcKBEreHgmM+mdw7NuarZgUkv5FrCdh7acDpdwunQpwwsovV 1dBlUdfIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXPuH-0006DD-AU; Tue, 27 Oct 2020 14:25:01 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXPuE-0006CV-CH for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 14:24:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603808697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZIQtSRPpP7bzkDKojGKr85+f7UAm051h+6PAJvhRak=; b=R/Uxb9xVGlD75HTc/lKboXRkcNghEZVycKC69m23FKqsnlHwAyOa5MHJAUiNtHfjvtK4iB 7vowcci4Kt8FwJHzH1sULsR1okTs7H04FGn6zLvxACEE+Uv34bIuTzm//cicuK3rRbKbHF 7Z2k4+Q41GRKWeQxJ0pcfblC/8RKCyQ= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-JCyYWHF4OQesyRLFbVfgWw-1; Tue, 27 Oct 2020 10:24:53 -0400 X-MC-Unique: JCyYWHF4OQesyRLFbVfgWw-1 Received: by mail-ej1-f71.google.com with SMTP id z8so973061ejw.3 for ; Tue, 27 Oct 2020 07:24:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lZIQtSRPpP7bzkDKojGKr85+f7UAm051h+6PAJvhRak=; b=qWGplwWwdJFCMTd/X27YpBS9vhw1vXSunAP0YgwG+q50DI1rFlP+Mey7WwyiOr9VCi wmRunaZHacFzFRbH4nDu2lHwJ45qqgWd94LFrZ7s2HfDMly1z0rbk/j0uJNCHbhFYfFh hu2i4EAD0YSQ+YPKEwCJKRUazl7a/w3jmAsWFufiIEQ5tL89mG92c98WZTYLmAiroQ7d IUsHonw7P0zXgT53Nq5GGYv1LQhDnmKez+jzo3mcN2RUgfncicPHT9aoelZQLGqoo62Y RGfcHluice6uEAU5ZgdFDqD6S6Q67d2wk2F8FwHR8yc4u3FHyrkH7K3lJII/W8c2zLWI TleA== X-Gm-Message-State: AOAM532+QE6iA+zzGOShzU0FW/296EJlY82rArk5HlirENiJuAERy0R1 6JJExBIeuW0M7WkoCyopJE3Adql9UjY4emcsuAZhHXUquHHlkD+hCBSwRzU6HLOZ+qILjYjRaDP OdeZaETa1KIoL5F/x6HElMmHQrxiZi7B9sB4= X-Received: by 2002:a50:88e5:: with SMTP id d92mr2549986edd.145.1603808692524; Tue, 27 Oct 2020 07:24:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzApUcUk9SzoxZFdV+Ugcey7NYFu4EhTJ1o513dIeIc3FxXZD5QyjvKBq96p8qkWB9wFeMMfw== X-Received: by 2002:a50:88e5:: with SMTP id d92mr2549968edd.145.1603808692276; Tue, 27 Oct 2020 07:24:52 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id yw17sm1147190ejb.97.2020.10.27.07.24.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 07:24:51 -0700 (PDT) Subject: Re: [PATCH 4/7] irqchip/irq-mvebu-icu: Remove the double SATA ports interrupt hack To: sven.auhagen@voleatech.de, axboe@kernel.dk, robh+dt@kernel.org, tglx@linutronix.de, maz@kernel.org, gregory.clement@bootlin.com References: <20201007154554.66650-1-sven.auhagen@voleatech.de> <20201007154554.66650-5-sven.auhagen@voleatech.de> From: Hans de Goede Message-ID: Date: Tue, 27 Oct 2020 15:24:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201007154554.66650-5-sven.auhagen@voleatech.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_102458_470079_3FF2411D X-CRM114-Status: GOOD ( 22.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, jason@lakedaemon.net, devicetree@vger.kernel.org, antoine.tenart@bootlin.com, viresh.kumar@linaro.org, rjw@rjwysocki.net, maxime.chevallier@bootlin.com, linux-ide@vger.kernel.org, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 10/7/20 5:45 PM, sven.auhagen@voleatech.de wrote: > From: Miquel Raynal > > When writing the driver, a hack was introduced to configure both SATA > interrupts regardless of the port in use to overcome a limitation in > the SATA core. Now that this limitation has been addressed and the > hack moved in the (historically) responsible SATA driver, > ahci_{platform,mvebu}.c, let's clean this driver section. > > Signed-off-by: Miquel Raynal > Acked-by: Marc Zyngier Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/irqchip/irq-mvebu-icu.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/irqchip/irq-mvebu-icu.c b/drivers/irqchip/irq-mvebu-icu.c > index 91adf771f185..3e29f8d5b33b 100644 > --- a/drivers/irqchip/irq-mvebu-icu.c > +++ b/drivers/irqchip/irq-mvebu-icu.c > @@ -38,8 +38,6 @@ > > /* ICU definitions */ > #define ICU_MAX_IRQS 207 > -#define ICU_SATA0_ICU_ID 109 > -#define ICU_SATA1_ICU_ID 107 > > struct mvebu_icu_subset_data { > unsigned int icu_group; > @@ -111,22 +109,6 @@ static void mvebu_icu_write_msg(struct msi_desc *desc, struct msi_msg *msg) > } > > writel_relaxed(icu_int, icu->base + ICU_INT_CFG(d->hwirq)); > - > - /* > - * The SATA unit has 2 ports, and a dedicated ICU entry per > - * port. The ahci sata driver supports only one irq interrupt > - * per SATA unit. To solve this conflict, we configure the 2 > - * SATA wired interrupts in the south bridge into 1 GIC > - * interrupt in the north bridge. Even if only a single port > - * is enabled, if sata node is enabled, both interrupts are > - * configured (regardless of which port is actually in use). > - */ > - if (d->hwirq == ICU_SATA0_ICU_ID || d->hwirq == ICU_SATA1_ICU_ID) { > - writel_relaxed(icu_int, > - icu->base + ICU_INT_CFG(ICU_SATA0_ICU_ID)); > - writel_relaxed(icu_int, > - icu->base + ICU_INT_CFG(ICU_SATA1_ICU_ID)); > - } > } > > static struct irq_chip mvebu_icu_nsr_chip = { > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel