From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D7FCC4707B for ; Thu, 18 Jan 2024 09:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n2tC6+gCAydyJPu4v4NAkIxPht6C4y0zXqXSok+i3d0=; b=ceupAUu38D0brt nFvHov8j5kXRlTn9mmt0njyVII2Wc9VRzrPcoC6YNsrUgHqpTdnkaO1tq+leHTAiEvjskqKgaw86+ GNmhrPuq+BA1YB1ObU5MGkkUNiInGFb4ceQDZD880HanMIo0cpYe50hGpC6J7jyoERqmwhlO7zDes vOOnzBJoPVEYGTwVHvkCAOKOqfNB+B3dVJB07ZbhjTxKMjPxJLKKLnKebOuTYimkoFW2CVeUXtCFD RlaKOhcfKFV10C9qtHSfZi8ImUnTeAAZctlW+U6Fj63VV5rWfpQx7pbz/ScQjrodwM5cr779we3yb cFbN9tJ0uux6Yl+p9Iyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQOiU-002HtU-1Z; Thu, 18 Jan 2024 09:29:42 +0000 Received: from mx4.securetransport.de ([178.254.6.145]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQOiR-002HsE-1M for linux-arm-kernel@lists.infradead.org; Thu, 18 Jan 2024 09:29:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1705570152; bh=aA3cPGIs/7zKZafcN4vYuW4EjRaFhlfin5ohb5+4zCk=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=BfH4+tCMw3tbOktJp6Wvqu3pOZ3TSs9Sgb1HrMuut60YAeLkBOJnJ9cGqLFj6llwW 5bkoB+uF/R1CCHn8VXQYpwfp94a+PeE4kdSG7x3RIdQStzY1tjoTlg0ZbU8wnYfsM3 P6yZiX4lSi1N2pcM48xn/N5ekyQHNDjeqvAgNdyDVwhJOjLKeoFZYhPJv4mUKXqiJk vXFVcWdfCxtzXM+OzrZVrTqaN9fKrSxnORhSEeLZl88r+6Y2iYsTz4wANin95c7tPF 65Ta06ZkL+YHE1lsY6d4Sht4CLnWqXRNXaC5kGfm0vkMdo1GAJg6FGHw/ZGkh4lxC0 p0E0HOGQTgUnA== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Greg KH CC: "crescentcy.hsieh@moxa.com" , "jirislaby@kernel.org" , "LinoSanfilippo@gmx.de" , "lukas@wunner.de" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v6 1/2] tty: serial: Cleanup the bit shift with macro Thread-Topic: [PATCH v6 1/2] tty: serial: Cleanup the bit shift with macro Thread-Index: AQHaSJT/2G6HCu2q+UioazhsZhzEcrDeCL+AgAENyACAADkvsA== Date: Thu, 18 Jan 2024 09:29:10 +0000 Message-ID: References: <20231201071554.258607-2-crescentcy.hsieh@moxa.com> <20240117145623.3556-1-cniedermaier@dh-electronics.com> <2024011836-glimmer-seventh-f2a7@gregkh> In-Reply-To: <2024011836-glimmer-seventh-f2a7@gregkh> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240118_012939_759218_F0906416 X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Greg KH Sent: Thursday, January 18, 2024 8:02 AM > On Wed, Jan 17, 2024 at 03:56:23PM +0100, Christoph Niedermaier wrote: >> Hi everyone, >> >>> This patch replaces the bit shift code with "_BITUL()" macro inside >>> "serial_rs485" struct. >>> >>> Signed-off-by: Crescent CY Hsieh >>> --- >>> include/uapi/linux/serial.h | 17 +++++++++-------- >>> 1 file changed, 9 insertions(+), 8 deletions(-) >>> >>> diff --git a/include/uapi/linux/serial.h b/include/uapi/linux/serial.h >>> index 53bc1af67..6c75ebdd7 100644 >>> --- a/include/uapi/linux/serial.h >>> +++ b/include/uapi/linux/serial.h >>> @@ -11,6 +11,7 @@ >>> #ifndef _UAPI_LINUX_SERIAL_H >>> #define _UAPI_LINUX_SERIAL_H >>> >>> +#include >>> #include >>> >>> #include >>> @@ -140,14 +141,14 @@ struct serial_icounter_struct { >>> */ >>> struct serial_rs485 { >>> __u32 flags; >>> -#define SER_RS485_ENABLED (1 << 0) >>> -#define SER_RS485_RTS_ON_SEND (1 << 1) >>> -#define SER_RS485_RTS_AFTER_SEND (1 << 2) >> >> In the old definition (1 << 3) wasn't used. >> >>> -#define SER_RS485_RX_DURING_TX (1 << 4) >>> -#define SER_RS485_TERMINATE_BUS (1 << 5) >>> -#define SER_RS485_ADDRB (1 << 6) >>> -#define SER_RS485_ADDR_RECV (1 << 7) >>> -#define SER_RS485_ADDR_DEST (1 << 8) >>> +#define SER_RS485_ENABLED _BITUL(0) >>> +#define SER_RS485_RTS_ON_SEND _BITUL(1) >>> +#define SER_RS485_RTS_AFTER_SEND _BITUL(2) >>> +#define SER_RS485_RX_DURING_TX _BITUL(3) >> >> Isn't it a break if number 3 isn't skipped here as well? > > Ugh, yes it is, good catch! > > Care to send a patch to fix this up? OK, I'll make a patch. Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel