From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33036C76196 for ; Mon, 10 Apr 2023 18:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L3Pi5EFsL4fn3vyr4sNtVqfyaQoFWcTR7ztq6RZCATg=; b=jCB4COP814ddZC HLquRdLxkJPrHf3/559aMRzBFegTZJw8hELMjs3BoP/s/8AKcfNdMj7AnOK+v38XqaHF0qSuyTw6j g+y8rIyiorhyS7gE5JIMhY9h81FO0KUgB4LqIzwxD6pFQw38RjvEjQl9h+vA/JBqJTRS0X0vg5PL0 I8+Ra9mHRHB1IcnlnBWEXcYAgBp7YNMxXp+pXaon0HuztpuqCxtmeO8p4LEh3dbhyndy8Sq9tj4CZ 7+KsqL1MuYuMH1Biy+HawHgzcfKiAJuK7yxU9lxq7+fiBd8QkimSgW5IclmMKaCCUwE87FNWTpZRC 0Y5bxr0SiImUq+p587fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1plwHK-00FjXb-18; Mon, 10 Apr 2023 18:30:10 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1plwHI-00FjWu-0A for linux-arm-kernel@lists.infradead.org; Mon, 10 Apr 2023 18:30:09 +0000 Received: by mail-io1-xd2a.google.com with SMTP id ca18e2360f4ac-7606cf95ab8so2817439f.0 for ; Mon, 10 Apr 2023 11:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1681151405; x=1683743405; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cYKDJKwn10X7KLBuY10/um2m58nz9p5VC59dotIeEO0=; b=FRdjAn56JBxgc+W8+zwgpjOs3Nr2+xBM+V86kQ+EGBTwrajmGuxhQUI/puxV05pZUX Cvtj62XK1mKeWW2jbxDR6jettZuvK6HGogF8sFXdwKaXnwUJqn1O5IVgIjUDDCXBS3EW UQwPhR4S/Av81m64se7slJLAVXyzIqvzRyUa8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681151405; x=1683743405; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cYKDJKwn10X7KLBuY10/um2m58nz9p5VC59dotIeEO0=; b=0kba4GX4AV1Q9Unb/iK8B+ssy0XvUed+sAnxeTH4sXOaY8a9hzqAiTnYozxTw6QDM2 G8HDqRVek6XcYLChCX1S+fM7Lrxt3CnA0n1qO1Ta94npkWOEDHdVxemLwyfVU+Z2g1eK ObelRCrfmAiGLpRH/eRCRNeiuldEmk3NtXOLB8599tqnRwJfnyYU/dEbjDFRzvncaPIB hbyIjrR1i0Hy2YRlrbjAqpA4wFdtZBqNzHbBsjMp4IImc5ZqrNaZgBFMXp+1rKUWst+j WQtJanlpSHsIBmGoa4wnaDIhy+Elsj4OHTHW4v49nAMp8IUYe7D49bOsyWj3G9Mjm92W jYJw== X-Gm-Message-State: AAQBX9c/vwuHTvP/9Y1ObInaVALuuTuROrZqukNiUFUTo94wHIMQ/ezO ALkFs91UvgPZF4OpaB5+a/XXAg== X-Google-Smtp-Source: AKy350aTt/4xClTAoIKpBxclNxt+cGRKJn1lsW7n0DD5/6/9nxr7cWLFWKFlG0cHJgwC7hfmKNtssQ== X-Received: by 2002:a05:6602:13d4:b0:757:f2a2:affa with SMTP id o20-20020a05660213d400b00757f2a2affamr6532981iov.1.1681151405345; Mon, 10 Apr 2023 11:30:05 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id cx4-20020a056638490400b0040bd4f2fcedsm588700jab.105.2023.04.10.11.30.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 11:30:04 -0700 (PDT) Message-ID: Date: Mon, 10 Apr 2023 12:30:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 1/3] tools/nolibc/stdio: Implement vprintf() Content-Language: en-US To: paulmck@kernel.org, Willy Tarreau Cc: Mark Brown , Shuah Khan , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20230405-kselftest-nolibc-v2-0-2ac2495814b5@kernel.org> <20230405-kselftest-nolibc-v2-1-2ac2495814b5@kernel.org> From: Shuah Khan In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230410_113008_113757_4932C443 X-CRM114-Status: GOOD ( 18.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/6/23 12:43, Paul E. McKenney wrote: > On Thu, Apr 06, 2023 at 08:26:09PM +0200, Willy Tarreau wrote: >> On Thu, Apr 06, 2023 at 05:19:10PM +0100, Mark Brown wrote: >>> vprintf() is equivalent to vfprintf() to stdout so implement it as a simple >>> wrapper for the existing vfprintf(), allowing us to build kselftest.h. >>> >>> Suggested-by: Willy Tarreau >>> Signed-off-by: Mark Brown >>> --- >>> tools/include/nolibc/stdio.h | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/tools/include/nolibc/stdio.h b/tools/include/nolibc/stdio.h >>> index 96ac8afc5aee..6cbbb52836a0 100644 >>> --- a/tools/include/nolibc/stdio.h >>> +++ b/tools/include/nolibc/stdio.h >>> @@ -273,6 +273,12 @@ int vfprintf(FILE *stream, const char *fmt, va_list args) >>> return written; >>> } >>> >>> +static __attribute__((unused)) >>> +int vprintf(const char *fmt, va_list args) >>> +{ >>> + return vfprintf(stdout, fmt, args); >>> +} >>> + >>> static __attribute__((unused, format(printf, 2, 3))) >>> int fprintf(FILE *stream, const char *fmt, ...) >>> { >> >> Perfect, thank you Mark, I'm glad that it simplified the rest of >> your series. >> >> Acked-by: Willy Tarreau >> >> Paul, feel free to directly queue this one for 6.5. If you prefer I >> can as well queue it on my side and send it later, it's just that I >> have exactly zero extra value on top of this one ;-) > > Alternatively, if it would be more convenient for Mark to send this > up via kselftest: > > Acked-by: Paul E. McKenney > > It currently merges cleanly with the -rcu tree's dev branch, so this > should not be a problem. > > Either way, please let me know, Mark! > > I can take these through kselftest or can go through arm64 Acked-by: Shuah Khan thanks, -- Shuah _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel