From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95DBEC7618D for ; Mon, 20 Mar 2023 16:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h5DzW5/uj4rucKgVuP3GOmlm7YY2PKolrx3i4JCbAkw=; b=CaFwVLZDDN+AON Kn7iliJqNlu/1fA16FuNnNqp4rbyP8ZZrpKThxFRzuWbCm8EcRfS5xuIqW2F6Xoo0sQuGNIgLSKFc OH9Usk9YWYKtTPl6KP3e3rJaz+Z96bfGFj2kwUWOMVG8fLGQrRmaJtlnJhLxpaZVkME8vs3ywxzWk IeOaw3borud8Z0ZaPXP8+ZOjZxeCa/b06ll3Xju64dNN24c1rJhgiCWQtLyCoHMzQqyyQeelGmnKk T0vCz8UXSSkpGji1NgodwFRWX83CCf8NX3muTJntcRlTWLk9kj5hHWdl/ZoJYfSmS3f486126W87E jvoEALlTgLr99Y1wjGvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peIM8-009lUE-0T; Mon, 20 Mar 2023 16:27:32 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peIM4-009lSU-0p for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 16:27:29 +0000 Received: by mail-ed1-x534.google.com with SMTP id r11so49027904edd.5 for ; Mon, 20 Mar 2023 09:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679329644; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XnwEPxx5YL7Zi9KDhWj9Zn5PB5/beeG3PJ/g8T7eV2A=; b=xRcg+DCrSBd/eo+qM0Lw4k0Vt8NlLOOh1A3iakfND6UM34tnNbgLXSoa8tQ0643p4j DJcZZ9pZ4pSmJf+q7NSbi4iNO1V0OKB7oshHqnN86H2OGSweWdKpXAyiS+nINaiZKv40 5jLYZ6OUxuykProx0xFju8xLeQb61h+pf6sB6OqW9TOUqhQfG4CThGLnMD5OSwSOP8J8 p1N2HqgnfCQWiuyJt1H6588nhuWjKxktwKWH4m1SXzQbSSog9XiuR/OzBgerpzIMZsc3 9z0qF1JmwUpBSFeUGN8NjLGvzTSECMvi+l1Tk4lo9vl7Ig50bwHLL0LuFSt/hBOKTgRP /Jtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679329644; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XnwEPxx5YL7Zi9KDhWj9Zn5PB5/beeG3PJ/g8T7eV2A=; b=qO/UEBSBLPRJzrlCsVnnPbv+zh2PGV5kNWqND44wqE/5gYlx/kTGgAh5I3l8MB4xPA lzjPxP9l6luvd+iF0MRdqeHyHzpXZP2RFBxZVzBQEKrWXa9OCqEnawT9qFy4AuOYzJ3o phM2rMrhRMOcpnWYkJufANQqgI0pYKBbEhfTqQ13HZXBESTkCWt3b82EqEXaD8uIje0B +zEXMdQBkTYUTNOlaxkb9uwgkDPB78WxrzUHA9YUpaG2Fv/2XdrnxhcKmgc1TSl9FS8T /p5iwUU7I7iog+w3dBfXNRrKKE1epAF0gWg7uNgioBrL5m24s/VJPa8MdLZN1jFRjiyy ZXig== X-Gm-Message-State: AO0yUKXEmyDXvR4hvdGPegpKcDCtxyof8hlxEB93MRVUoaGenUllyE0W 7CiETl40YjHNzVB1h05XWRhPHw== X-Google-Smtp-Source: AK7set/Pob6U/DYlrD/H/KyyBeppvFxPMq7piDaQGnQG1fbu46kGcOBrV0ICBwN/T15mV1Z0zOGACw== X-Received: by 2002:a17:906:2b56:b0:922:d34e:2ba1 with SMTP id b22-20020a1709062b5600b00922d34e2ba1mr10035489ejg.63.1679329644492; Mon, 20 Mar 2023 09:27:24 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:458e:64e7:8cf1:78b0? ([2a02:810d:15c0:828:458e:64e7:8cf1:78b0]) by smtp.gmail.com with ESMTPSA id r5-20020a1709064d0500b00923f05b2931sm4588816eju.118.2023.03.20.09.27.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 09:27:23 -0700 (PDT) Message-ID: Date: Mon, 20 Mar 2023 17:27:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [EXT] Re: [PATCH v2 1/3] dt-bindings: usb: cdns-imx8qm: add imx8qm cdns3 glue bindings To: Frank Li , "shawnguo@kernel.org" Cc: "devicetree@vger.kernel.org" , "festevam@gmail.com" , "imx@lists.linux.dev" , "kernel@pengutronix.de" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "s.hauer@pengutronix.de" References: <20230316212712.2426542-1-Frank.Li@nxp.com> <20230316212712.2426542-2-Frank.Li@nxp.com> <1fd1fe42-3da6-1598-a04d-cb99a9b4b145@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_092728_300786_821D6DCD X-CRM114-Status: GOOD ( 14.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/03/2023 17:22, Frank Li wrote: >>>>>>> + assigned-clocks: >>>>>>> + items: >>>>>>> + - description: Phandle and clock specifier of >> IMX_SC_PM_CLK_PER. >>>>>>> + - description: Phandle and clock specifoer of >>>> IMX_SC_PM_CLK_MISC. >>>>>>> + - description: Phandle and clock specifoer of >>>>>> IMX_SC_PM_CLK_MST_BUS. >>>>>>> + >>>>>>> + assigned-clock-rates: >>>>>>> + items: >>>>>>> + - description: Must be 125 Mhz. >>>>>>> + - description: Must be 12 Mhz. >>>>>>> + - description: Must be 250 Mhz. >>>>>> >>>>>> I would argue that both properties above are not needed. If your >>>>>> hardware requires fixed frequencies, clock provider can fix them, can't >> it? >>>>> >>>>> Clock provider don't know fixed value and turn on only used by client. >>>> >>>> So maybe fix the clock provider? Or this device driver? Requiring by >>>> binding specific frequencies for every board is a bit redundant. >>> >>> It is not for every boards, it is common for a chip family. Only a place to set >> for >>> QM and QXP. >>> >>> The similar case is network driver, which require a specific frequency at >> clock assign. >>> Generally frequency is fixed, clock source name may change at difference >> chips. >> >> If frequency is always fixed, I don't understand why this is in DT >> bindings. I would even say it should not be in DTS. We don't put into >> DTS properties which are always the same, because otherwise they would >> grow crazy big. > > Although frequency is fixed, clock name may change for difference platform. > > assigned-clocks = <&clk IMX_SC_R_USB_2 IMX_SC_PM_CLK_PER>, > <&clk IMX_SC_R_USB_2 IMX_SC_PM_CLK_MISC>, > <&clk IMX_SC_R_USB_2 IMX_SC_PM_CLK_MST_BUS>; > assigned-clock-rates = <125000000>, <12000000>, <250000000>; > > some platform use IMX_SC_R_USB_2, other platform may use IMX_SC_R_USB_3. This I understand, you wrote it above, so nothing new and my concerns are still there. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel