From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Qin Jian <qinjian@cqplus1.com>, sboyd@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
mturquette@baylibre.com, linux@armlinux.org.uk, arnd@arndb.de,
olof@lixom.net, soc@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v17 10/10] ARM: dts: Add Sunplus SP7021-Demo-V3 board device tree
Date: Tue, 7 Jun 2022 14:02:09 +0200 [thread overview]
Message-ID: <fc7a6f0e-e93d-a645-8078-2d747c4208d0@linaro.org> (raw)
In-Reply-To: <e54fac0acbcedddb37a572e47face7edbacbec5d.1654565776.git.qinjian@cqplus1.com>
On 07/06/2022 03:58, Qin Jian wrote:
> Add the basic support for Sunplus SP7021-Demo-V3 board.
>
> Signed-off-by: Qin Jian <qinjian@cqplus1.com>
> ---
> Fix the comments from Krzysztof.
> ---
> +
> + pctl: pinctl@9c000100 {
Wrong node name - the schema requires "pinctrl" or "pinmux".
> + compatible = "sunplus,sp7021-pctl";
> + reg = <0x9C000100 0x100>,
> + <0x9C000300 0x100>,
> + <0x9C0032e4 0x1C>,
> + <0x9C000080 0x20>;
> + reg-names = "moon2", "gpioxt", "first", "moon1";
> + gpio-controller;
> + #gpio-cells = <2>;
> + clocks = <&clkc CLK_GPIO>;
> + resets = <&rstc RST_GPIO>;
> +
> + leds_pins: pinmux_gpio_leds-pins {
> + sunplus,pins = < SPPCTL_IOPAD(0,SPPCTL_PCTL_G_GPIO,0,SPPCTL_PCTL_L_OUT) >;
> + };
> +
> + emmc_pins: emmc-pins {
> + function = "CARD0_EMMC";
> + groups = "CARD0_EMMC";
> + };
> +
> + sdcard-pins {
> + function = "SD_CARD";
> + groups = "SD_CARD";
> + sunplus,pins = < SPPCTL_IOPAD(91, SPPCTL_PCTL_G_GPIO, 0, 0) >;
> + };
> +
> + emac_pins: pinmux_emac_demo_board_v3-pins {
> + sunplus,pins = <
> + SPPCTL_IOPAD(49,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_CLK_OUT,0)
> + SPPCTL_IOPAD(44,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_MAC_SMI_MDC,0)
> + SPPCTL_IOPAD(43,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_MAC_SMI_MDIO,0)
> + SPPCTL_IOPAD(52,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_TXEN,0)
> + SPPCTL_IOPAD(50,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_TXD0,0)
> + SPPCTL_IOPAD(51,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_TXD1,0)
> + SPPCTL_IOPAD(46,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_CRSDV,0)
> + SPPCTL_IOPAD(47,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_RXD0,0)
> + SPPCTL_IOPAD(48,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_RXD1,0)
> + SPPCTL_IOPAD(45,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P0_MAC_RMII_RXER,0)
> + SPPCTL_IOPAD(59,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_TXEN,0)
> + SPPCTL_IOPAD(57,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_TXD0,0)
> + SPPCTL_IOPAD(58,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_TXD1,0)
> + SPPCTL_IOPAD(54,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_CRSDV,0)
> + SPPCTL_IOPAD(55,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_RXD0,0)
> + SPPCTL_IOPAD(56,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_RXD1,0)
> + SPPCTL_IOPAD(53,SPPCTL_PCTL_G_PMUX,MUXF_L2SW_P1_MAC_RMII_RXER,0)
> + >;
> + sunplus,zerofunc = <
> + MUXF_L2SW_LED_FLASH0
> + MUXF_L2SW_LED_FLASH1
> + MUXF_L2SW_LED_ON0
> + MUXF_L2SW_LED_ON1
> + MUXF_DAISY_MODE
> + >;
> + };
> +
> + uart0_pins: pinmux_uart0-pins {
> + function = "UA0";
> + groups = "UA0";
> + };
> +
> + uart1_pins: pinmux_uart1-pins {
No underscores in node names.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-07 12:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 1:58 [PATCH v17 00/10] Add Sunplus SP7021 SoC Support Qin Jian
2022-06-07 1:58 ` [PATCH v17 01/10] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-06-07 11:56 ` Krzysztof Kozlowski
2022-06-07 1:58 ` [PATCH v17 02/10] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-06-07 11:57 ` Krzysztof Kozlowski
2022-06-07 1:58 ` [PATCH v17 03/10] reset: Add Sunplus " Qin Jian
2022-06-07 1:58 ` [PATCH v17 04/10] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-06-07 11:57 ` Krzysztof Kozlowski
2022-06-07 1:58 ` [PATCH v17 05/10] clk: Add Sunplus " Qin Jian
2022-06-12 10:43 ` kernel test robot
2022-06-07 1:58 ` [PATCH v17 06/10] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-06-07 1:58 ` [PATCH v17 07/10] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-06-11 16:22 ` kernel test robot
2022-06-07 1:58 ` [PATCH v17 08/10] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-06-07 1:58 ` [PATCH v17 09/10] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2022-06-07 1:58 ` [PATCH v17 10/10] ARM: dts: Add Sunplus SP7021-Demo-V3 board device tree Qin Jian
2022-06-07 12:02 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc7a6f0e-e93d-a645-8078-2d747c4208d0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).