From: <Tudor.Ambarus@microchip.com>
To: <ryder.lee@mediatek.com>, <marek.vasut@gmail.com>,
<computersforpeace@gmail.com>, <boris.brezillon@bootlin.com>
Cc: devicetree@vger.kernel.org, weijie.gao@mediatek.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-mtd@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 3/3] mtd: spi-nor: mtk-quadspi: rename config to a common one
Date: Tue, 15 Jan 2019 07:34:41 +0000 [thread overview]
Message-ID: <fc95a69a-6a2e-fc98-d047-b0c93843fc56@microchip.com> (raw)
In-Reply-To: <45dc2817e7f4baf5113de247b1a2cb30bf252d93.1547442452.git.ryder.lee@mediatek.com>
Hi, Ryder,
On 01/14/2019 07:12 AM, Ryder Lee wrote:
> The quadspi is a generic communication interface which could be shared
> with other MediaTek SoCs. Hence rename it to a common one.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Changes since v1: rebase to v5.0-rc1.
The patch doesn't apply on v5.0-rc1 or rc2.
> ---
> drivers/mtd/spi-nor/Kconfig | 16 ++++++++--------
> drivers/mtd/spi-nor/Makefile | 2 +-
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index b433e5f..99d9d53 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -7,14 +7,6 @@ menuconfig MTD_SPI_NOR
>
> if MTD_SPI_NOR
>
> -config MTD_MT81xx_NOR
> - tristate "Mediatek MT81xx SPI NOR flash controller"
> - depends on HAS_IOMEM
> - help
> - This enables access to SPI NOR flash, using MT81xx SPI NOR flash
> - controller. This controller does not support generic SPI BUS, it only
> - supports SPI NOR Flash.
> -
> config MTD_SPI_NOR_USE_4K_SECTORS
> bool "Use small 4096 B erase sectors"
> default y
> @@ -68,6 +60,14 @@ config SPI_NXP_SPIFI
> Flash. Enable this option if you have a device with a SPIFI
> controller and want to access the Flash as a mtd device.
>
> +config SPI_MTK_QUADSPI
Since you are moving the config into the file, would you mind to put your config
in an alphabetical order?
Thanks,
ta
> + tristate "MediaTek Quad SPI controller"
> + depends on HAS_IOMEM
> + help
> + This enables support for the Quad SPI controller in master mode.
> + This controller does not support generic SPI. It only supports
> + SPI NOR.
> +
> config SPI_INTEL_SPI
> tristate
>
> diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile
> index 2adedbe..189a15c 100644
> --- a/drivers/mtd/spi-nor/Makefile
> +++ b/drivers/mtd/spi-nor/Makefile
> @@ -3,7 +3,7 @@ obj-$(CONFIG_MTD_SPI_NOR) += spi-nor.o
> obj-$(CONFIG_SPI_ASPEED_SMC) += aspeed-smc.o
> obj-$(CONFIG_SPI_CADENCE_QUADSPI) += cadence-quadspi.o
> obj-$(CONFIG_SPI_HISI_SFC) += hisi-sfc.o
> -obj-$(CONFIG_MTD_MT81xx_NOR) += mtk-quadspi.o
> +obj-$(CONFIG_SPI_MTK_QUADSPI) += mtk-quadspi.o
> obj-$(CONFIG_SPI_NXP_SPIFI) += nxp-spifi.o
> obj-$(CONFIG_SPI_INTEL_SPI) += intel-spi.o
> obj-$(CONFIG_SPI_INTEL_SPI_PCI) += intel-spi-pci.o
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-15 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 5:12 [PATCH v1 1/3] dt-bindings: mtd: mtk-quadspi: update bindings for MT7629 SoC Ryder Lee
2019-01-14 5:12 ` [PATCH v1 2/3] mtd: spi-nor: mtk-quadspi: add SNOR_HWCAPS_READ for capcity setting Ryder Lee
2019-01-15 6:59 ` Tudor.Ambarus
2019-01-15 7:44 ` Guochun Mao
2019-01-14 5:12 ` [PATCH v1 3/3] mtd: spi-nor: mtk-quadspi: rename config to a common one Ryder Lee
2019-01-15 7:34 ` Tudor.Ambarus [this message]
2019-01-15 7:57 ` Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc95a69a-6a2e-fc98-d047-b0c93843fc56@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox