From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE24EC636D4 for ; Thu, 2 Feb 2023 08:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mmcxHJ5OFBccAkDSmYlyp152+LnyW9nRPfX65kXPQtA=; b=kQk/wCUUwpV2ZJ 2+1aaltYN8fQj5nlqpO+iWyPUypJgxNYDYx4SN/WgQlRjpSbT+bRp5hzbPYjVwzM5MBWWxbFt6ugK LjFR8GPZECMt04raqSj15V6aVIRvAEjzMNVlub0xOBCowkk0djFHVZlP7bgfRBHjxASX0iyDoDe80 Q351Z9pES8zYElPA9bcFG04zvyLwPKJbK9uglZapdX1S3Blz/1oF/ckejlg0YgaB0bCeQSgjbndq4 d4y60bZqkWn5t+ivsBkichRyLRdWe7kBHI4p9hm69UpAxKByURE9E7/zj64u+cCkKNIkD2eV5oC4l dt5QdfKUY71LM6W33ong==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNVKw-00F2bE-Hy; Thu, 02 Feb 2023 08:52:54 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNVKt-00F2a5-8j for linux-arm-kernel@lists.infradead.org; Thu, 02 Feb 2023 08:52:52 +0000 Received: by mail-wm1-x32c.google.com with SMTP id l8so796922wms.3 for ; Thu, 02 Feb 2023 00:52:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UP/sXG6BbiZp8djPCPgh/7Unv00A4lZ4qBzipf/bhsw=; b=XwN8l9XYFjm4ZrMbgDED4aiv0zeRcUNbp5GZihY8LHKMp2UwRH2Rceypz6EYWj1aAd pUkIYqwM+QGYyHpBD4u00DZGyaUeYeRJLjBr3ODdsWyS8nV3+7IZT4u7bDXN/UaP+068 1g2lKw7gO2oNZ4c8vC2s+WYt1ssRJ6836EB9ErE/ke2SCLndciXjSXIsi5/GrOm2Vib5 bl35tk9xx+TuvQug7Q95iHzAhgrXMdwHtl+OxPNtqGcgxWPQGrHS8rP9zJX9IOgn508u Ut9iBVlktBP8cd56jpz7uDkbRayVArniaM24SadAEdomOMrHeCmm3+oQu8iNGsJyqY9+ 0PTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UP/sXG6BbiZp8djPCPgh/7Unv00A4lZ4qBzipf/bhsw=; b=EDyL+mQAln7ZzTIWFom19qqbxTOMtB2h+Hril6wXqJQxFtL0Ay9u5GQuIkJFRdbpHT ykjQggtKxUEWpwWlJUY9P4Du1qzEFd091lGbLARlbtlEcs/Pc0wRR9GuEjEwbAdTJGcT KBygQSG1nlWAnD9SQHmobFLYpQpPrlGbMAke1hTedJpTa2pcnkm8FmOB88FUW/mhW3YZ d03N9PiUn0wtCCuBuTjXVpzOs6B6S9+QTtpMBQXC0y8Qyr0hmrLOV6gSt8fF0IjiZidX 2g4oe/p55kfkP4uaYfV/R4tPMZo6dksfyfgYekaTFcJRjceJtZxNCS7hJrzmaVzHxL0O lOZA== X-Gm-Message-State: AO0yUKVQbcSg0LxjmN8hQu3TcImgs/7e/TmyAzcrfGVnecsfhQaGPPfj QWtn/byRRZHicc7rKWzqJwbSLzvCrPGfdqQc X-Google-Smtp-Source: AK7set9B04peanV4wBhLfFzs1g9pGIOA4lkMICSMs7zldQ2TUJBQMnQJ7ne0vOW2lLc8zPNnsIbVVQ== X-Received: by 2002:a05:600c:4f41:b0:3dc:53da:329b with SMTP id m1-20020a05600c4f4100b003dc53da329bmr5029207wmq.17.1675327968137; Thu, 02 Feb 2023 00:52:48 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id c7-20020a05600c0ac700b003d1d5a83b2esm3976373wmr.35.2023.02.02.00.52.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 00:52:47 -0800 (PST) Message-ID: Date: Thu, 2 Feb 2023 09:52:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v4 1/3] dt-bindings: i2c-ast2600: Add support for AST2600 I2C global controller Content-Language: en-US To: Ryan Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Philipp Zabel , openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20230201103359.1742140-1-ryan_chen@aspeedtech.com> <20230201103359.1742140-2-ryan_chen@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20230201103359.1742140-2-ryan_chen@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_005251_342214_63459839 X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/02/2023 11:33, Ryan Chen wrote: > AST2600 I2C global register controller, add bindings document > to support driver of i2c global register set. > > Signed-off-by: Ryan Chen > --- > .../i2c/aspeed,i2c-ast2600-global.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml > new file mode 100644 > index 000000000000..d92a0878d03b > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/aspeed,i2c-ast2600-global.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AST2600 I2C Global Register on the AST26XX SoCs Device Tree Bindings Drop "Device Tree Bindings" > + > +maintainers: > + - Ryan Chen > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-i2c-global Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). I'll stop review till you test the patches before sending. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel