Re: [PATCH v1 1/4] dt-bindings: iio: adc: amlogic,meson-saradc: add S4 compatible

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/02/2026 12:18, Krzysztof Kozlowski wrote:
> On Sat, Feb 28, 2026 at 02:58:37PM +0800, Nick Xie wrote:
>> Add the compatible string for the SARADC (Successive Approximation
>> Register ADC) IP block found in the Amlogic Meson S4 SoC.
> 
> ... which is fully compatible with g12a?
> 
> Write proper explanations.
> 
>>
>> Signed-off-by: Nick Xie <nick@khadas.com>
>> ---
>>  .../devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml        | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
>> index bb9825e7346dd..5496a0dc714aa 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
>> @@ -27,6 +27,7 @@ properties:
>>                - amlogic,meson-gxm-saradc
>>                - amlogic,meson-axg-saradc
>>                - amlogic,meson-g12a-saradc
>> +              - amlogic,meson-s4-saradc
> 
> If this is compatible with other device, you need proper fallback.
> 
>>            - const: amlogic,meson-saradc
> 
> And this one is now kind of fake - how does this device use it?

I checked now - NOTHING uses it. This is completely useless fallback,
don't write such schema. Add a comment that usage of this fallback is
not allowed for new devices and instead create proper compatibility
(look at your driver code).

Best regards,
Krzysztof