From: vzapolskiy@gmail.com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: MX3: Fixed typo in declared enum type name.
Date: Thu, 21 Jan 2010 12:35:22 +0300 [thread overview]
Message-ID: <fcda838a1001210135w38a52098m112c6055324b60e1@mail.gmail.com> (raw)
In-Reply-To: <20100121092619.GV8970@buzzloop.caiaq.de>
According to this issue I have not met problems with mx31lite board,
surely that's just a typo. Anyway I plan to continue to work with this
board setup for a while and make some tests of the recent changes
found in 2.6.33.
On Thu, Jan 21, 2010 at 12:26 PM, Daniel Mack <daniel@caiaq.de> wrote:
> On Thu, Jan 21, 2010 at 12:12:52PM +0300, Vladimir Zapolskiy wrote:
>> To distinguish between mx31lite and mx31lilly boards better to use
>> different enum types.
>
> True, even though it shouldn't have any impact unless you include both
> headers. I assume you didn't meet any real-life problem with that?
>
>> Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
>
> Acked-by: Daniel Mack <daniel@caiaq.de>
>
>
>> ---
>> ?arch/arm/plat-mxc/include/mach/board-mx31lite.h | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/plat-mxc/include/mach/board-mx31lite.h b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
>> index 0184b63..2b2da03 100644
>> --- a/arch/arm/plat-mxc/include/mach/board-mx31lite.h
>> +++ b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
>> @@ -25,7 +25,7 @@
>>
>> ?#ifndef __ASSEMBLY__
>>
>> -enum mx31lilly_boards {
>> +enum mx31lite_boards {
>> ? ? ? MX31LITE_NOBOARD ? ? ? ?= 0,
>> ? ? ? MX31LITE_DB ? ? ? ? ? ? = 1,
>> ?};
>> --
>> 1.6.5.4
>>
>
next prev parent reply other threads:[~2010-01-21 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 9:12 [PATCH] ARM: MX3: Fixed typo in declared enum type name Vladimir Zapolskiy
2010-01-21 9:26 ` Daniel Mack
2010-01-21 9:35 ` Vladimir Zapolskiy [this message]
2010-01-21 9:52 ` Daniel Mack
2010-01-21 13:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcda838a1001210135w38a52098m112c6055324b60e1@mail.gmail.com \
--to=vzapolskiy@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).