Re: [RESEND PATCH 01/42] mfd: arizona: use PLATFORM_DEVID_NONE

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Milo Kim <milo.kim@ti.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-kernel@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Ray Jui <rjui@broadcom.com>,
	linux-samsung-soc@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Andy Shevchenko <andy@kernel.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Scott Branden <sbranden@broadcom.com>,
	patches@opensource.cirrus.com,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [RESEND PATCH 01/42] mfd: arizona: use PLATFORM_DEVID_NONE
Date: Tue, 16 Mar 2021 14:28:18 +0100	[thread overview]
Message-ID: <fcee4721-1d91-d909-8a03-1c1b0b0ad83b@kernel.org> (raw)
In-Reply-To: <20201028223009.369824-1-krzk@kernel.org>

On 28/10/2020 23:29, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Hi Lee,

I sent this patchset some time ago, then made a resend. I did not get
any feedback from you so I just wonder - are you still considering this
patchset and shall I resend?

Best regards,
Krzysztof

> ---
>  drivers/mfd/arizona-core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 000cb82023e3..bf48372db605 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -1043,8 +1043,9 @@ int arizona_dev_init(struct arizona *arizona)
>  	case CS47L24:
>  		break; /* No LDO1 regulator */
>  	default:
> -		ret = mfd_add_devices(arizona->dev, -1, early_devs,
> -				      ARRAY_SIZE(early_devs), NULL, 0, NULL);
> +		ret = mfd_add_devices(arizona->dev, PLATFORM_DEVID_NONE,
> +				      early_devs, ARRAY_SIZE(early_devs),
> +				      NULL, 0, NULL);
>  		if (ret != 0) {
>  			dev_err(dev, "Failed to add early children: %d\n", ret);
>  			return ret;
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel